From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eMMsC0m+wWGcbQEAgWs5BA (envelope-from ) for ; Tue, 21 Dec 2021 12:45:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SHHWBkm+wWEJEgAAB5/wlQ (envelope-from ) for ; Tue, 21 Dec 2021 11:45:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C897118260 for ; Tue, 21 Dec 2021 12:45:12 +0100 (CET) Received: from localhost ([::1]:58154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzdZv-0006pD-F3 for larch@yhetil.org; Tue, 21 Dec 2021 06:45:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzdZm-0006oo-CJ for bug-guix@gnu.org; Tue, 21 Dec 2021 06:45:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41060) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzdZm-0002Ed-3X for bug-guix@gnu.org; Tue, 21 Dec 2021 06:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzdZm-0007Cg-30 for bug-guix@gnu.org; Tue, 21 Dec 2021 06:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51968: Missing dependency for Xournal++ Resent-From: Daniel =?UTF-8?Q?Mei=C3=9Fner?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 21 Dec 2021 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51968 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Alexander Asteroth Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , 51968@debbugs.gnu.org Received: via spool by 51968-submit@debbugs.gnu.org id=B51968.164008704727596 (code B ref 51968); Tue, 21 Dec 2021 11:45:02 +0000 Received: (at 51968) by debbugs.gnu.org; 21 Dec 2021 11:44:07 +0000 Received: from localhost ([127.0.0.1]:52606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzdYt-0007B2-0m for submit@debbugs.gnu.org; Tue, 21 Dec 2021 06:44:07 -0500 Received: from out1.mail.ruhr-uni-bochum.de ([134.147.53.149]:10116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzdYm-0007AI-Jn for 51968@debbugs.gnu.org; Tue, 21 Dec 2021 06:44:05 -0500 Received: from mx1.mail.ruhr-uni-bochum.de (localhost [127.0.0.1]) by out1.mail.ruhr-uni-bochum.de (Postfix mo-ext) with ESMTP id 4JJF3G3ZhCz8XKJ; Tue, 21 Dec 2021 12:43:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ruhr-uni-bochum.de; s=mail-2017; t=1640087034; bh=8H89MHt9w6VNx++17xWVDMmdiil9WehArrZ8UyuBcYM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=1iNo8sSObPKpJaY8eI7VEXOW/9jDkGV4JI19zyJsq8MFx5LcI/7s73WrBAhnwIMcx T0oZCTLAgHhqOHukvkJvs7jnQF1m89RY0rnb86fgjMszurGOkUWN52EWdcDyCfcOPF 1ieTAPRQWB/qk3RUkpoERMgwHrMBXAGAErVaLttI= Received: from out1.mail.ruhr-uni-bochum.de (localhost [127.0.0.1]) by mx1.mail.ruhr-uni-bochum.de (Postfix idis) with ESMTP id 4JJF3G328nz8XKD; Tue, 21 Dec 2021 12:43:54 +0100 (CET) X-RUB-Notes: Internal origin=134.147.42.236 X-Envelope-Sender: Received: from mail2.mail.ruhr-uni-bochum.de (mail2.mail.ruhr-uni-bochum.de [134.147.42.236]) by out1.mail.ruhr-uni-bochum.de (Postfix mi-int) with ESMTP id 4JJF3F70fqz8X9F; Tue, 21 Dec 2021 12:43:53 +0100 (CET) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.1 at mx1.mail.ruhr-uni-bochum.de Received: from think (dslb-002-204-216-024.002.204.pools.vodafone-ip.de [2.204.216.24]) by mail2.mail.ruhr-uni-bochum.de (Postfix) with ESMTPSA id 4JJF3F14P4zDgyN; Tue, 21 Dec 2021 12:43:53 +0100 (CET) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.104.1 at mail2.mail.ruhr-uni-bochum.de In-Reply-To: <87ee66e3wp.fsf@h-brs.de> References: <87fsrsijtk.fsf@ruhr-uni-bochum.de> <87k0gca8lj.fsf@gnu.org> <87a6gzv94l.fsf@ruhr-uni-bochum.de> <87czlvkxd7.fsf@h-brs.de> <875yrj5qxf.fsf@ruhr-uni-bochum.de> <87ee66e3wp.fsf@h-brs.de> Date: Tue, 21 Dec 2021 12:43:45 +0100 Message-ID: <87wnjy18um.fsf@ruhr-uni-bochum.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Daniel =?UTF-8?Q?Mei=C3=9Fner?= From: Daniel =?UTF-8?Q?Mei=C3=9Fner?= via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640087112; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=X+U9k+EbVer10uqYeeLGni4ulLBDD+WtYBxbpVUP3s4=; b=k0fm/ml+0n9Ld9Wn+XJti4gB546/BFasTL9L7Hh+3hli/lqiVi4LQ0Pp/LY1K6YQmq0XCv sH8Lvr7xwnLb3BXL5w/FUcY5UYNo/RHKhAWdHjqE22qxcGOEIS3dsfdArQ7ugwUA4TOmzC /5BBbCWtwLT1dEbTM6eqOFl4i0nR7tWVCeQ6aoW3243YgPV1B76qmsWTgkh9yIrBiuxCz5 jP5fs+9mlFhM3E6oJHh6MQozm1C6nyr2oMITyWKy1NGk+MTmig/WkyUpqL5tHJO7hZ/tNm CIgTwdMr5W8cq3Yq+9HHDaqRVj7xZjDBRvkcbDOkd+4dhFafi0m22PrC+o8W7A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640087112; a=rsa-sha256; cv=none; b=mB+2v+ZNdEb0Kz1S3+GLV8E+m5rfTPLwsZnKRzWUkZSlka95XszDSVVlYaHzOLzUkZc8VH grTXaUpYYXjyxHnxgeMBYRdB9+8Hcvvb7GrEvJCrQtKY3VvWrZxjVe2RcKHcD2XvgJRRdH v0nvUYdE9d0VIxhoQciOIcScCcseBWxQpdwHCXUbEfdnBUEbX+7RLYj40gWHez8qQJjKoX sMcB75C771bsaFBi2r/y8NCPAHRQ3urKSqkAgCZ5alrW0CGGSgTxbMWi2bSqJlm5o9szTp gCIOv4NvpoFc1pdjRh3YZgX+6vZwS2PuwaOdodS1JJaK0qv/88uUvKMNngBa6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ruhr-uni-bochum.de header.s=mail-2017 header.b=1iNo8sSO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ruhr-uni-bochum.de header.s=mail-2017 header.b=1iNo8sSO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C897118260 X-Spam-Score: -4.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: F5MeIGyv2e+5 Alexander Asteroth writes: > On Mon, Dec 20 2021, 14:47:24, Daniel Mei=C3=9Fner wrote: >>> I can reproduce the missing icons issue by running=20 >>> >>>> guix shell --pure -f xournalpp-fix.scm -- xournalpp >>> >>> as suggested below. Wondering why the icons are not missing when I run >>> xournalpp in my environment I discovered that >>> >>>> guix shell --pure gtk+ -f xournalpp-fix.scm -- xournalpp >>> >>> resolves this problem. >> >> This is weird since gtk+ already is an input to xournalpp (despite not a >> propagated one). What desktop environment are you using? > > That is *really* strange, is it? I'm using no desktop environment. Just > EXWM as window manager. > I can confirm that adding gtk+ to the profile makes Xournal++ find its icons. I did a comparison of the environment variables of the two =E2=80= =98guix shell=E2=80=99 invocations and here=E2=80=99s the thing: --8<---------------cut here---------------start------------->8--- $ guix shell --pure -f xournalpp-fix.scm -- /usr/bin/env LOGNAME=3Ddaniel XAUTHORITY=3D/run/user/1000/gdm/Xauthority HOME=3D/home/daniel TERM=3Ddumb USER=3Ddaniel DISPLAY=3D:1 PATH=3D/gnu/store/jrhzgh2pjzq2jbvcp4jgy7zznprkigh4-profile/bin GUIX_ENVIRONMENT=3D/gnu/store/jrhzgh2pjzq2jbvcp4jgy7zznprkigh4-profile $ guix shell --pure gtk+ -f xournalpp-fix.scm -- /usr/bin/env LOGNAME=3Ddaniel XAUTHORITY=3D/run/user/1000/gdm/Xauthority HOME=3D/home/daniel TERM=3Ddumb USER=3Ddaniel DISPLAY=3D:1 PATH=3D/gnu/store/n6fkzsjvppxaqaw5a2whgxw0zzs85563-profile/bin:/gnu/store/n= 6fkzsjvppxaqaw5a2whgxw0zzs85563-profile/sbin GUIX_GTK3_PATH=3D/gnu/store/n6fkzsjvppxaqaw5a2whgxw0zzs85563-profile/lib/gt= k-3.0 XDG_DATA_DIRS=3D/gnu/store/n6fkzsjvppxaqaw5a2whgxw0zzs85563-profile/share XCURSOR_PATH=3D/gnu/store/n6fkzsjvppxaqaw5a2whgxw0zzs85563-profile/share/ic= ons GDK_PIXBUF_MODULE_FILE=3D/gnu/store/n6fkzsjvppxaqaw5a2whgxw0zzs85563-profil= e/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache GUIX_ENVIRONMENT=3D/gnu/store/n6fkzsjvppxaqaw5a2whgxw0zzs85563-profile --8<---------------cut here---------------end--------------->8--- As you can see: among others the XDG_DATA_DIRS is set which causes Xournal++ to find its icons. Plus the GDK_PIXBUF_MODULE_FILE also resolves the problem that Xournal++ cannot recognize the file format of its application icon =E2=80=98pixmaps/com.github.xournalpp.xournalpp.svg=E2= =80=99 which also happens with =E2=80=98guix shell --pure -f xournalpp-fix.scm -- xourna= lpp=E2=80=99. These missing environment variables are probably because the package definition does not use glib-or-gtk-build-system but cmake-build-system. WDYT? Maxime, can you confirm this and how should we fix this? >> This =E2=80=98modify-input=E2=80=99 form is actually a macro and it is d= ocumented in the >> latest version of the manual [1]. This macro is part of a big surface >> level syntax change for packages which arrived with the >> core-updates-frozen merge. See [2] for a nice blog post. > > In the meantime I found that as well. But the documentation (from my > perspective) is unfortunately incomplete. It neither specifies the full > semantics (without looking into the macro-code) nor does it tell me, > what kind of clauses I can put e.g. into (modify-input ...). How is > (append ...) translated? The web document links to the list append > function which it might somehow translate to but that is not documented > either (at least I dont find it). As Maxime writes, the examples show how to use the syntax. However, honestly, I looked up the definition of =E2=80=98modify-inputs=E2=80=99 in = (guix packages) because I felt a bit like guessing which is probably what you were feeling while reading the manual. It could indeed state more clearly that each of CLAUSES can be one of the following forms: (append names ...) (prepend names ...) (delete names ...) (replace name replacement) Especially because =E2=80=98replace=E2=80=99 breaks the pattern. Also it w= ould be nice to mention that the names can be specified be either the package name as a string or a package object. Best Daniel