From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +rEqKWXwNmL3KgEAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 10:14:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iGXTIGXwNmIhXAEAG6o9tA (envelope-from ) for ; Sun, 20 Mar 2022 10:14:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BED0EE50A for ; Sun, 20 Mar 2022 10:14:12 +0100 (CET) Received: from localhost ([::1]:56232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVrdb-0000Ne-EH for larch@yhetil.org; Sun, 20 Mar 2022 05:14:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVrdT-0000NP-9F for bug-guix@gnu.org; Sun, 20 Mar 2022 05:14:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38927) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVrdT-0000Ux-1H for bug-guix@gnu.org; Sun, 20 Mar 2022 05:14:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVrdS-00075A-Dv for bug-guix@gnu.org; Sun, 20 Mar 2022 05:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Resent-From: Roman Scherer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 20 Mar 2022 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50329 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Received: via spool by submit@debbugs.gnu.org id=B.164776759327146 (code B ref -1); Sun, 20 Mar 2022 09:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Mar 2022 09:13:13 +0000 Received: from localhost ([127.0.0.1]:32824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVrcf-00073m-2y for submit@debbugs.gnu.org; Sun, 20 Mar 2022 05:13:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:33620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVrcc-00073d-M4 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 05:13:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVrca-0000H7-AC for guix-patches@gnu.org; Sun, 20 Mar 2022 05:13:08 -0400 Received: from [2a00:1450:4864:20::52e] (port=33787 helo=mail-ed1-x52e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVrcY-0000Lw-0N for guix-patches@gnu.org; Sun, 20 Mar 2022 05:13:08 -0400 Received: by mail-ed1-x52e.google.com with SMTP id r23so14890339edb.0 for ; Sun, 20 Mar 2022 02:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20210112.gappssmtp.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=/z6RXIX2mvJVBz3aNlz591C2ZhjsPjfAfez7QqQkSPA=; b=YFfnzj3GWkqoWLPjaOiOjdjdOOu0dJoPcklbkXSbj+ZHKxKvGGjzzHT+HsCylOQMdp GxpbU8f5dSdU2rBQ3OZY7pRxyj6LjBHX1gVnuPLc8L5vK84M8JN5NzP1a6S2WRTPz5Tm vMm9VoHOTbMec+bMqNQdW4b/teBIsVYh+k+rGtBq343dAqUVRYAUyxbzLIVmA92jB22R vHB30tHhSw4pSY3aJ3pRw+WEc7D4z00x3I8MflRciyyA74Rdp8XUAxz0dH1nM//D3KpG n7/YGwX9KELlfrNv6HteDKDbt56Do/na7jujOmtNehmu5bqcLs/Z1DaDzDK17sVPJyuS D0ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=/z6RXIX2mvJVBz3aNlz591C2ZhjsPjfAfez7QqQkSPA=; b=hz606DciVX5Eve8vBnWjZKcdYHtJP/u6XvLXgbeLn48H+mPTWOY65cAcBgjlOk0Hl4 lDhNOPTM7PPnfkj0zCcsn649yx0H9ctn/VScCLxtFyalf0HnwKs/KDQGhCKNZ2DyeHQp T8PDfwlcD3bYQAz72FArysukk+GINgNAxvr1q4F/6dbf3p0SJzEP+/5xu2KfeU4kFKRu RF3CiceOUGzKHI84oypKO8IcV3ztcrjqRQ9eOIkecibvlr0mEq8z5qExVbW7PisTrGys IheSdRixPqAHqyUQ8XrEsBACbN7ClkhvzVNcSHIbgLnEDaNf5H90HaiGw0IunbpOOpCx sqfw== X-Gm-Message-State: AOAM531hVMOvn7Zrn25PSODsZpLWuyv1JHfDN8NYT03oCG99QD27tQ8R 1OS5CKzs0Lt3aVKB+Tf5J1KZ6Q== X-Google-Smtp-Source: ABdhPJzZm55L9TO6tXDQg10v1JA4ZBO1nyAG7n2ayYwu8ThkKYOkqpT8oRu7E7FdNou351pu1TiQxg== X-Received: by 2002:a50:9d49:0:b0:418:681b:f6d with SMTP id j9-20020a509d49000000b00418681b0f6dmr17691266edk.160.1647767582607; Sun, 20 Mar 2022 02:13:02 -0700 (PDT) Received: from thinkpad (tmo-116-11.customers.d1-online.com. [80.187.116.11]) by smtp.gmail.com with ESMTPSA id z7-20020a05640240c700b00416cee953dasm6706723edb.24.2022.03.20.02.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 02:13:02 -0700 (PDT) References: <87fsnevtxi.fsf@burningswell.com> <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 28.0.50 From: Roman Scherer Date: Sun, 20 Mar 2022 09:59:31 +0100 In-reply-to: <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> Message-ID: <87wngp6l7n.fsf@burningswell.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52e (failed) Received-SPF: none client-ip=2a00:1450:4864:20::52e; envelope-from=roman.scherer@burningswell.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-patches@gnu.org, Nicolas Goaziou Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647767652; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/z6RXIX2mvJVBz3aNlz591C2ZhjsPjfAfez7QqQkSPA=; b=UuLZX9NM1xu/Q/zssujGn0tUDwtEWiPaj3/jD1cvTxNRm+U5Sl4N7dJHboJ+kSF/nWVBqb rrA5TsiMT/5zF9FMmdD13PhsQUxKJQIvuoagFFm0LrMXgbTr/tLMiQGpfRjONiAu1jaBFq BFQ6wt0CD5r5ExVtxtKcXZuEKhJY2+vIqSJiFA0ZDrjZ5Jh+VwyogcjsxhCzn+Fd/HGeoj fs4osnaRJsfbHGsvGjtfkKouygGr+AysbuvwMgkAWYXkHT2334efkDF6G6iyEwwWMXsg4s 5WbB8q0Wi0ES6yVVAr6xJjZDkQMdXbpx5AHjPD4t9D9lOxkvhO/F/2ioKOfs+g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647767652; a=rsa-sha256; cv=none; b=XIdr/DJHuKw7/9wjGbpk07K8/Geg7Ze1l3I30gBhLaqhYXYqG2xX6wKX9opbn7+o7Mhs/o YmQV0Tm4CeJf6A3jfODcjtTHjcB22QoKwLCYGbt90qn8wYy2+sNfJwc3micGjmOr6l+w3l S45NjOCEeP+yAks9tKnrYj02sNujoIjtZWFys2Xwa44uVF6jZ5jJBzh8Y7bIkRYLfF9tEM 1iee0zM/sOdUGh8XvLlBzhPVydDqQ0qN8UAe906tecnIZrSc14OCZIzI0qrDnLT8ax9m6e fGRMBBf290v13zuoYGW1SiNQJwGcoMgAaF7Krqt6HjSRufCuJddjInOLFzD07w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=YFfnzj3G; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.73 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=YFfnzj3G; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BED0EE50A X-Spam-Score: -2.73 X-Migadu-Scanner: scn0.migadu.com X-TUID: SqGF8bdztz5X --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Maxime, thanks for taking a look at my patch and uncovering this license issue. I was not aware of that. When I said the emacs-lsp-treemacs package is not bundling it's icons, I meant that the Guix emacs-lsp-treemacs package does not install them. So, without my patch, I see the following files installed on my system: [roman@thinkpad ~]$ find /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-= lsp-treemacs-0.4 /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4 /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp/lsp-treemacs-0.4 /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp/lsp-treemacs-0.4/lsp-treemacs-pkg.el /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp/lsp-treemacs-0.4/lsp-treemacs.elc /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp/lsp-treemacs-0.4/lsp-treemacs-autoloads.el /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp/lsp-treemacs-0.4/lsp-treemacs-themes.el /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp/lsp-treemacs-0.4/lsp-treemacs.el /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp/lsp-treemacs-0.4/lsp-treemacs-themes.elc /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/em= acs/site-lisp/lsp-treemacs-0.4/lsp-treemacs-autoloads.elc /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/doc /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/do= c/emacs-lsp-treemacs-0.4 /gnu/store/z634qq81f0qfvqzr0rcavpc16bdc9zs3-emacs-lsp-treemacs-0.4/share/do= c/emacs-lsp-treemacs-0.4/LICENSE Since the icons are not installed on a Guix system right now, I think we can leave the Guix emacs-lsp-treemacs packages as it is for now. Once upstream has added the licenses for the icons, we could take another look and maybe only install the ones that we are allowed to include. What do you think? Thanks, Roman. Maxime Devos writes: > [[PGP Signed Part:Undecided]] > Roman Scherer schreef op za 19-03-2022 om 16:29 [+0100]: >> the emacs-lsp-treemacs package does not bundle it's icons. This patch >> fixes the issue by copying the icons to `share/emacs-lsp- >> treemacs/icons` and patching the paths in `lsp-treemacs-themes.el`. > > That might technically solves matter, though instead of copying, why > not just change > > (string-append "\"" out "/share/" ,name "/icons/" name "\"") > > to the location of the icons? Unless you meant something else with > bundling here ... > > Also, what do you mean with bundling exactly? AFAICT, the icons _are_ > bundled, in the directory 'icons', and so far they have not yet been > unbundled in Guix -- the problem is that they are not installed (yet) > -- in that case, the patch seems reasonable to me. > > Additionally, there may be some licensing problems. The icons > apparently come from =E2=80=98eclipse=E2=80=99, =E2=80=98idea=E2=80=99 an= d =E2=80=98netbeans=E2=80=99. I don't > actually know which license these have, but: > > * idea is propietary, so probably its icons are as well > * Eclipse is ASL, which probably has some kind of requirement > that you need to preserve license and copyright information, > which seems to be completely ignored here. > * the relevant licenses don't appear to be entioned in the > 'licenses' field. > > As such, if these problems are not resolved, I think it will be > necessary to remove emacs-lsp-treemacs. > > It seems like emacs-company-box > (https://github.com/sebastiencs/company-box/tree/master/images) > has the same problem as well. > > Also seem upstream . > > Greetings, > Maxime. > > [[End of PGP Signed Part]] --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFTBAEBCAA9FiEE0iajOdjfRIFd3gygPdpSUn0qwZkFAmI28BwfHHJvbWFuLnNj aGVyZXJAYnVybmluZ3N3ZWxsLmNvbQAKCRA92lJSfSrBmepdB/4rlqm3wtys21gb Dn0K3EziKih4SKRM1TXgTgdHai++fhZlMAqUrbxMCsB7k54CzEpGMRShgR3ZHE5h UyQwe3exuOrlp7wQzr4hGC1ld5yetHFxXAaTprkjdCnr8RWTv8EeAxewPE7kHy1B PqriCti9vNNe/lbsiN0v6QtVW+w90GwQ/mCQjASTnGnaeZYKjkEv66d+tfF52vNB 0p+7PzLzA2zMbvflTMIR9+JhSZU3n/CiJ3CkVH8CtrJxyovT4yafkP2DoJBBPqj0 TDGiDlbc+ZWy7i9Rr02MAxcWEyMfTTfz2scNKd9MybvSai8i/D+VGcYKd1GY52Sb i3TEbHB6 =oshl -----END PGP SIGNATURE----- --=-=-=--