From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KPsuHCiRV2XYxgAAG6o9tA:P1 (envelope-from ) for ; Fri, 17 Nov 2023 17:13:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KPsuHCiRV2XYxgAAG6o9tA (envelope-from ) for ; Fri, 17 Nov 2023 17:13:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 41CA616E00 for ; Fri, 17 Nov 2023 17:13:28 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=TRq26dvn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700237608; a=rsa-sha256; cv=none; b=QY7yKCNsVo2uTrz8IzjPl1/XidaJ0EIx88i9sFMVVgbjda9aJEafmZ3HF2gIWGxI0Q9Wxx YOa1PJTNWgq9rWGgjQdiw15dCviHD71YNEaesi89e3QJa4FNUEKNJPKElb3tVv79W5y/Hi Yydi0cmpKApiUrCS84gHjGFfG09YctI+tIXeS10xI2ijlG0CK018GcUC/lm9+LXZPkqXiT 3zyAlSJ//H6whnM19dn24kSzjc+MEeBAPleFRb2d5uNnogvEL2zRJe5Evi150MSVXrPsGx QsDnjKDdszC0nVZUzg5IUsXwHIkAIccrHUYaLZ7Ny1pjzQnBP14U8dM6y77TTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700237608; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=lTYWpQovDckvoJNTt8atNJMYLGRAqpeBJp0APIftF2o=; b=m+EjPX6Qy0tFDvmx2MUd/xSqlTFZDK6vxSVPsLxaZCd8TDMu5VtR2xwF1BJ+wA9wGPwd5p veswCcvcxJVc7E6ARqCh6kAjJvIsWs/ebeBIUZH+jwonAEm+NDojjtb7p9GBVx1e4jI4/q OZ6CrNQlApmjzCN1egsRA1FNFiYgUZz2jKa2s8/tT3vlzZJI30DGD3FJrs6HHkiGkyEOWn TRZYLYLsosdkzOJWPBaD/B5trpFySAPM/Ih8jQ8dONVg1KNFbV5zGkJg/yRSnZjDuwOt3s TzgRxHAoUGPmPeOFYp4DKEzxuMzOIPeftydmDZZBDCAL6oO/cv8/uMcU3oM+lA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=TRq26dvn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r41Ss-0002l7-Qr; Fri, 17 Nov 2023 11:13:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r41Sn-0002kr-NJ for bug-guix@gnu.org; Fri, 17 Nov 2023 11:13:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r41Sn-0008OR-FP for bug-guix@gnu.org; Fri, 17 Nov 2023 11:13:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r41Sn-00052U-NO for bug-guix@gnu.org; Fri, 17 Nov 2023 11:13:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#67240: dev: =?UTF-8?Q?=E2=80=9Cmake=E2=80=9D?= of Guix fails, non-existent .git/hooks directory Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 17 Nov 2023 16:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67240 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 67240@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170023756319339 (code B ref -1); Fri, 17 Nov 2023 16:13:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Nov 2023 16:12:43 +0000 Received: from localhost ([127.0.0.1]:47025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r41SU-00051r-Nf for submit@debbugs.gnu.org; Fri, 17 Nov 2023 11:12:43 -0500 Received: from lists.gnu.org ([2001:470:142::17]:58776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r41SS-00051a-4K for submit@debbugs.gnu.org; Fri, 17 Nov 2023 11:12:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r41SL-0002co-51 for bug-guix@gnu.org; Fri, 17 Nov 2023 11:12:33 -0500 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r41SJ-0008If-CS for bug-guix@gnu.org; Fri, 17 Nov 2023 11:12:32 -0500 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c6f4bc7738so5787931fa.0 for ; Fri, 17 Nov 2023 08:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700237549; x=1700842349; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=lTYWpQovDckvoJNTt8atNJMYLGRAqpeBJp0APIftF2o=; b=TRq26dvnNLxtuR9fGEjX7XUr3FriwZt7fyvkEKT8grluHyJasZ9rc+hbKzlnn1tJ/a 64R08iYIV9yypeXrdcV3cC5nmoB6ERAobU3wNQAAXTAceVqk6CznNRPQ+zU0+AWFUw/A Z4bMqu81v1T+sHlRp/Tn45cGjBGLObKA0xy9g3YM+ZKsVLzUlr0X+BO1ADzg2nHhZC4Q up77KvRfGtyJOqyoOONC7jWkVrugiejO7opAUEQm0Mr3ZSROXEnE4cQVoXykdZSt1xfo iAjMjBzPM+wu891Mwa6f8SKEzJKnNAqeW48HVV8wIsJPl7YyfB1IbhqPRAZtwmb+tPXI xAqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700237549; x=1700842349; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lTYWpQovDckvoJNTt8atNJMYLGRAqpeBJp0APIftF2o=; b=R/HTkD14SIgQmm8I/7E4B22ZtJQcSqXi1ZJGPDWxJGyoBse2G6TvsvD09IEf/7eavr NXeT2ZdxVix4OSeFLdpZBzvUAVwY263ZjwsXwoRuXeBaGhtmvEMWopssX7uKVqRSW422 VJ8mTsYslas7SlY/ZAagQdF76hf2pS4hQwsPxrtMJEKHYzQ9YRoRA1FZV4jK5vWjiYWo m+rsJ+HdhQCNnF1MRVnmn6nJs4+451Z5oUn2M2/vLSkM90Y0Jn1s6rBThl6j+bT5HUiM pXY6TeURPz+uE33WfYm6NzjUUyPXzx5rGtQbgw1mS5P0QU8SdfFvWVXSySglFgZrMEuN 0xgw== X-Gm-Message-State: AOJu0Yzt5u6ONjlGtEdejHk11H7Or6ukrP7r3w9REeRhe5TJTMz/dopa FCRucrmjwRJHFPRr+GSvHpewWKVus6E= X-Google-Smtp-Source: AGHT+IHdGjFepl0GCa0BcWk0theNvhWo23+vuLt7TIoiIsKy/WtAC+mySz69Y/id3BYvlf/q3V1SXg== X-Received: by 2002:a05:651c:30b:b0:2c5:6ab:b817 with SMTP id a11-20020a05651c030b00b002c506abb817mr15198ljp.5.1700237549181; Fri, 17 Nov 2023 08:12:29 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-44.net.univ-paris-diderot.fr. [194.254.61.44]) by smtp.gmail.com with ESMTPSA id h20-20020a05600c315400b004063c9f68f2sm3304052wmo.26.2023.11.17.08.12.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 08:12:28 -0800 (PST) From: Simon Tournier Date: Fri, 17 Nov 2023 16:46:59 +0100 Message-ID: <87wmug9ybw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=zimon.toutoune@gmail.com; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: 4.41 X-Migadu-Queue-Id: 41CA616E00 X-Migadu-Spam-Score: 4.41 X-TUID: OEkgfltQlKfl --=-=-= Content-Type: text/plain Hi, On a very fresh install of a system, I have just cloned the Guix repository then run the dance ./bootstrap, ./configure and make. It fails because: --8<---------------cut here---------------start------------->8--- cp: cannot create regular file '.git/hooks/pre-push': No such file or directory make[2]: *** [Makefile:7454: .git/hooks/pre-push] Error 1 make[2]: Leaving directory '/home/simon/src/guix/guix' make[1]: *** [Makefile:6137: all-recursive] Error 1 make[1]: Leaving directory '/home/simon/src/guix/guix' make: *** [Makefile:4253: all] Error 2 --8<---------------cut here---------------end--------------->8--- In the file Makefile.am, nothing check that the directory .git/hooks exists before copying to it. By default, it does not seem created. At least, it was not with a fresh clone using Git from Guix revision fc6bdaa. I propose this patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=p.patch Content-Description: p.patch diff --git a/Makefile.am b/Makefile.am index cbc3191dfc..6e9a22fae5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1170,6 +1170,7 @@ cuirass-jobs: $(GOBJECTS) # Git auto-configuration. .git/hooks/pre-push: etc/git/pre-push $(AM_V_at)if test -d .git; then \ + mkdir -p .git/hooks; \ cp etc/git/pre-push .git/hooks/pre-push; \ fi --=-=-= Content-Type: text/plain Cheers, simon --=-=-=--