From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Netpbm Date: Sun, 20 Jan 2013 23:08:45 +0100 Message-ID: <87vcarqzgy.fsf@gnu.org> References: <201301191803.17290.andreas@enge.fr> <201301192324.50088.andreas@enge.fr> <87y5fovtoo.fsf@gnu.org> <201301201631.57914.andreas@enge.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:58492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tx34R-00041o-3z for bug-guix@gnu.org; Sun, 20 Jan 2013 17:08:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tx34P-0005P7-QL for bug-guix@gnu.org; Sun, 20 Jan 2013 17:08:55 -0500 Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:54582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tx34P-0005Ow-Jn for bug-guix@gnu.org; Sun, 20 Jan 2013 17:08:53 -0500 In-Reply-To: <201301201631.57914.andreas@enge.fr> (Andreas Enge's message of "Sun, 20 Jan 2013 16:31:57 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Andreas Enge Cc: bug-guix@gnu.org Andreas Enge skribis: > Ah, so many options! I tried the daemon with --debug. Here is the result: > In unknown file: > ?: 0 [mkdir "/nix/store/mv7v3y702k1yfml8067gn15r3n6pzjxm-user- > environment///nix/store/agjc4rdsvi4wvbz6dymgid5pb85nqcf7- > netpbm-10.61.01/VERSION" ...] > ERROR: In procedure mkdir: > ERROR: In procedure mkdir: No such file or directory Hmm, that still means there=E2=80=99s a bug with top-level file handling in (guix union). I=E2=80=99ll investigate later. A few comments: > + (copy-file (string-append out "/link/libnetpbm.a") > + (string-append out "/lib/libnetpbm.a")) > + ;; copy static library This comment should be just above. > + (system* "rm" "-r" (string-append out "/link")) > + (system* "rm" "-r" (string-append out "/misc")) This reminds me we need an =E2=80=98rm -rf=E2=80=99 in (guix build utils). = (There=E2=80=99s one using =E2=80=98file-system-fold=E2=80=99 in mysql.scm, if you=E2=80=99re cu= rious, but it=E2=80=99s OK to call out to Coreutils in the meantime. ;-)) > + (delete-file (string-append out "/config_template")) > + (delete-file (string-append out "/pkginfo")) > + (delete-file (string-append out "/README")) > + (delete-file (string-append out "/VERSION")))) > + ;; remove superfluous folders and files The comment should be above, and you could instead write: (with-directory-excursion out (for-each delete-file '("config_template" "pkginfo" "README" "VERSION"))) > + (license gpl2) It seems to be more complex than this. Some files in lib/ have this: ** Permission to use, copy, modify, and distribute this software and its ** documentation for any purpose and without fee is hereby granted, provi= ded ** that the above copyright notice appear in all copies and that both that ** copyright notice and this permission notice appear in supporting ** documentation. This software is provided "as is" without express or ** implied warranty. Others in analyzer/ have GPLv2+, others have this: All work has been contributed to the public domain by its authors. Debian lists a number of other issues, including unknown-status and non-free parts: http://packages.debian.org/changelogs/pool/main/n/netpbm-free/netpbm-free= _10.0-12.2/libnetpbm10.copyright The software black-list (http://libreplanet.org/wiki/Software_blacklist) doesn=E2=80=99t mention it. So perhaps we should remove things that Debian remove, and use something more representative in the =E2=80=98license=E2=80=99 field? (You really picked up a hard one. ;-)) Thanks, Ludo=E2=80=99.