Re: Netpbm

[ludo@gnu.org (Ludovic Courtès)]

Andreas Enge <andreas@enge.fr> skribis:

> Ah, so many options! I tried the daemon with --debug. Here is the result:
> In unknown file:
>    ?: 0 [mkdir "/nix/store/mv7v3y702k1yfml8067gn15r3n6pzjxm-user-
> environment///nix/store/agjc4rdsvi4wvbz6dymgid5pb85nqcf7-
> netpbm-10.61.01/VERSION" ...]
> ERROR: In procedure mkdir:
> ERROR: In procedure mkdir: No such file or directory

Hmm, that still means there’s a bug with top-level file handling in
(guix union).  I’ll investigate later.

A few comments:

> +         (copy-file (string-append out "/link/libnetpbm.a")
> +                    (string-append out "/lib/libnetpbm.a"))
> +          ;; copy static library

This comment should be just above.

> +         (system* "rm" "-r" (string-append out "/link"))
> +         (system* "rm" "-r" (string-append out "/misc"))

This reminds me we need an ‘rm -rf’ in (guix build utils).  (There’s one
using ‘file-system-fold’ in mysql.scm, if you’re curious, but it’s OK to
call out to Coreutils in the meantime.  ;-))

> +         (delete-file (string-append out "/config_template"))
> +         (delete-file (string-append out "/pkginfo"))
> +         (delete-file (string-append out "/README"))
> +         (delete-file (string-append out "/VERSION"))))
> +          ;; remove superfluous folders and files

The comment should be above, and you could instead write:

  (with-directory-excursion out
    (for-each delete-file
              '("config_template" "pkginfo" "README" "VERSION")))

> +   (license gpl2)

It seems to be more complex than this.  Some files in lib/ have this:

  ** Permission to use, copy, modify, and distribute this software and its
  ** documentation for any purpose and without fee is hereby granted, provided
  ** that the above copyright notice appear in all copies and that both that
  ** copyright notice and this permission notice appear in supporting
  ** documentation.  This software is provided "as is" without express or
  ** implied warranty.

Others in analyzer/ have GPLv2+, others have this:

  All work has been contributed to the public domain by its authors.

Debian lists a number of other issues, including unknown-status and
non-free parts:

  http://packages.debian.org/changelogs/pool/main/n/netpbm-free/netpbm-free_10.0-12.2/libnetpbm10.copyright

The software black-list (http://libreplanet.org/wiki/Software_blacklist)
doesn’t mention it.

So perhaps we should remove things that Debian remove, and use something
more representative in the ‘license’ field?

(You really picked up a hard one.  ;-))

Thanks,
Ludo’.