unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: 19599@debbugs.gnu.org
Subject: bug#19599: strace test suite failures
Date: Sun, 25 Jan 2015 22:33:26 +0100	[thread overview]
Message-ID: <87vbjubl5l.fsf@gnu.org> (raw)
In-Reply-To: <87y4p5xmrb.fsf@netris.org> (Mark H. Weaver's message of "Wed, 14 Jan 2015 13:03:52 -0500")

Mark H Weaver <mhw@netris.org> skribis:

> ../strace: Bad OS release string: '3.14-2-amd64'

The relevant code in strace.c in 4.7 is this:

--8<---------------cut here---------------start------------->8---
	/* u.release has this form: "3.2.9[-some-garbage]" */
	rel = 0;
	p = u.release;
	for (;;) {
		if (!(*p >= '0' && *p <= '9'))
			error_msg_and_die("Bad OS release string: '%s'", u.release);
		/* Note: this open-codes KERNEL_VERSION(): */
		rel = (rel << 8) | atoi(p);
		if (rel >= KERNEL_VERSION(1,0,0))
			break;
		while (*p >= '0' && *p <= '9')
			p++;
		if (*p != '.')
			error_msg_and_die("Bad OS release string: '%s'", u.release);
		p++;
	}
	return rel;
--8<---------------cut here---------------end--------------->8---

Basically it expects A.B.C where A, B, and C are numbers, which is not
the case on this particular build machine.

This is really an strace bug since there are occasionally two-number
version strings for Linux:
<https://www.kernel.org/pub/linux/kernel/v3.x/>.
We should report it there.

Ludo’.

  reply	other threads:[~2015-01-25 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 18:03 bug#19599: strace test suite failures Mark H Weaver
2015-01-25 21:33 ` Ludovic Courtès [this message]
2018-03-08 12:40 ` bug#19599: Closing, upstream fixed the issue Gábor Boskovits

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbjubl5l.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=19599@debbugs.gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).