From: ludo@gnu.org (Ludovic Courtès)
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 32184@debbugs.gnu.org
Subject: bug#32184: ‘guix pack --bootstrap’ is ineffective
Date: Fri, 19 Oct 2018 18:43:14 +0200 [thread overview]
Message-ID: <87va5xevkt.fsf@gnu.org> (raw)
In-Reply-To: <87r2k1ul77.fsf@gmail.com> (Chris Marusich's message of "Tue, 17 Jul 2018 23:11:56 -0700")
Hi Chris,
Chris Marusich <cmmarusich@gmail.com> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> While preparing the 0.15 release I realized that ‘guix pack --bootstrap’
>> had become ineffective. Concretely, ‘tests/guix-pack.sh’ would attempt
>> to build the world.
>>
>> This is a consequence of c45477d2a1a651485feede20fe0f3d15aec48b39w, which
>> introduced a dependency on guile-sqlite3 in derivations that build
>> packs, even if they don’t actually produce a ‘db.sqlite’ file in there.
[...]
> Basically, we're manually doing dependency injection here depending on
> whether or not --bootstrap was given, right? Instead of parameterizing
> the dependencies, what if we used a dependency injector (or "oracle", or
> "container", or whatever you want to call it) that, when invoked, would
> give us the dependency that is appropriate for the current context?
> Perhaps we could control the context via a single parameter. For
> example, something like this:
>
> (parameterize ((test-environment? #t))
> (injector-get-dependency guile))
>
> would return the bootstrap guile, but something like this:
>
> (parameterize ((test-environment? #f))
> (injector-get-dependency guile))
>
> would return the usual guile. This isn't much different from using
> parameters like we're already doing, except that it might save us from
> having to remember multiple parameters, and it might make the code
> cleaner by hiding the dependency selection/construction logic behind the
> injector abstraction.
>
> What do you think of that idea?
It was sad to see these tests were not running so I decided to bite the
bullet. :-)
In commit 19c924af4f3726688ca155a905ebf1cb9acdfca2, I went for a
different solution: now these ‘guix pack’ tests run using the user’s
store (normally /gnu/store) rather than the test store
($builddir/test-tmp), when possible.
This allows us to run these tests and possibly write other more complex
tests.
WDYT?
At this point I think we can remove ‘--bootstrap’ from ‘guix pack’
altogether.
Thoughts?
Thanks,
Ludo’.
prev parent reply other threads:[~2018-10-19 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 9:24 bug#32184: ‘guix pack --bootstrap’ is ineffective Ludovic Courtès
2018-07-18 6:11 ` Chris Marusich
2018-07-26 13:26 ` Ludovic Courtès
2018-10-19 16:43 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va5xevkt.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=32184@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).