From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#35640: Make USB modems just work on Guix
Date: Wed, 12 Jun 2019 22:42:36 +0200
Message-ID: <87v9xasfgj.fsf@gnu.org>
References: <20190514103555.1b2a6316@scratchpost.org>
 <20190514205648.nl4s4lwvc4t67gho@pelzflorian.localdomain>
 <87ef4zvpm7.fsf@gnu.org>
 <20190522162909.tds5wz7lj6npkgy4@pelzflorian.localdomain>
 <87ef4nx3s2.fsf@gnu.org>
 <20190524201210.bzeyua7lv2mamf52@pelzflorian.localdomain>
 <20190525111856.jfu5ly2p6ynn3rdk@pelzflorian.localdomain>
 <87lfyupgxm.fsf@gnu.org>
 <20190612121312.hobngtkentkiavai@pelzflorian.localdomain>
 <874l4vxadq.fsf@gnu.org>
 <20190612195120.bg7yuvjghf2d546f@pelzflorian.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:53742)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hbA5H-0005ph-42
 for bug-guix@gnu.org; Wed, 12 Jun 2019 16:43:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hbA5G-0007Bs-2n
 for bug-guix@gnu.org; Wed, 12 Jun 2019 16:43:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:48841)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hbA5F-0007Bk-VH
 for bug-guix@gnu.org; Wed, 12 Jun 2019 16:43:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hbA5F-0007OI-RK
 for bug-guix@gnu.org; Wed, 12 Jun 2019 16:43:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.35640.B35640.156037216528380@debbugs.gnu.org>
In-Reply-To: <20190612195120.bg7yuvjghf2d546f@pelzflorian.localdomain>
 (pelzflorian@pelzflorian.de's message of "Wed, 12 Jun 2019 21:51:20
 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 35640@debbugs.gnu.org

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:

> On Wed, Jun 12, 2019 at 02:21:05PM +0200, Ludovic Court=C3=A8s wrote:
>> "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
>> > On Sat, May 25, 2019 at 07:44:37PM +0200, Ludovic Court=C3=A8s wrote:
>> >> >> +                 (substitute* "usb_modeswitch_dispatcher"
>> >> >> +                   (("!/usr/bin/tclsh")
>> >> >> +                    (string-append "!" jimtcl "/bin/jimsh"))
>> [=E2=80=A6]
>> I meant that the =E2=80=98patch-shebangs=E2=80=99 phase should take care=
 of this, so you
>> can remove this substitution and save two lines.
>>=20
>> Ludo=E2=80=99.
>
> It is needed.  Upstream USB_Modeswitch bundles jimtcl.  Its Makefile
> uses jimsh0 from the bundled jimtcl, if possible, and replaces the
> shebang using sed.  Therefore it seems right to use jimsh for Guix=E2=80=
=99
> USB_ModeSwitch as well.
>
> patch-shebang fails because the basename of #!/usr/bin/tclsh is not
> jimsh.
>
> patch-shebang: /gnu/store/24yzny7szv1fnmq6ci1x2ndyy7dzyigk-usb-modeswitch=
-2.5.2-dispatcher/bin/usb_modeswitch_dispatcher: warning: no binary for int=
erpreter `tclsh' found in $PATH

Oh got it, thanks for explaining.

Ludo=E2=80=99.