From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#39551: Cannot declare an NFS mount using the <file-system> record
Date: Tue, 18 Feb 2020 12:28:33 -0500
Message-ID: <87v9o3yfcu.fsf@gmail.com>
References: <87pnem2ps1.fsf@gmail.com> <87d0akfao2.fsf@gmail.com>
 <878sl7bqud.fsf@roquette.mug.biscuolo.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:53711)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j46gB-0005ay-VI
 for bug-guix@gnu.org; Tue, 18 Feb 2020 12:29:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j46gA-0007Da-Q2
 for bug-guix@gnu.org; Tue, 18 Feb 2020 12:29:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:35260)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j46gA-0007DP-M3
 for bug-guix@gnu.org; Tue, 18 Feb 2020 12:29:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j46gA-0007YE-Js
 for bug-guix@gnu.org; Tue, 18 Feb 2020 12:29:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.39551.D39551.158204692228992.done@debbugs.gnu.org>
In-Reply-To: <878sl7bqud.fsf@roquette.mug.biscuolo.net> (Giovanni Biscuolo's
 message of "Wed, 12 Feb 2020 19:30:50 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Giovanni Biscuolo <g@xelera.eu>
Cc: 39551-done@debbugs.gnu.org

Giovanni Biscuolo <g@xelera.eu> writes:

> Hello,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> The attached patch fixes this issue
>
> [...]
>
>> diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
>> index b0386a1392..26a1599a93 100644
>> --- a/guix/scripts/system.scm
>> +++ b/guix/scripts/system.scm
>> @@ -566,6 +566,8 @@ any, are available.  Raise an error if they're not."
>>                (and (file-system-mount? fs)
>>                     (not (member (file-system-type fs)
>>                                  %pseudo-file-system-types))
>> +                   ;; Fixes issue #39551 (see: https://bugs.gnu.org/39551).
>> +                   (not (string-prefix? "nfs" (file-system-type fs)))
>>                     (not (memq 'bind-mount (file-system-flags fs)))))
>>              file-systems))
>
> Please is it possible to also add nfs4 to this fix?
>
> Thanks! Gio'

Done with commit adbdf188c28c503a9c875b793bc88548d3cd702f.  Please not
that booting with NFS still seems to be problematic, at least in my
experience.  I had to use set mount? to #f and check? to #f as well in
the <file-system> record.  I'll try to address these issues separately.

Maxim