From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#40493: installer: Provide a way to select multiple keyboard
 layouts
Date: Thu, 09 Apr 2020 09:54:54 +0200
Message-ID: <87v9m93xgx.fsf@gnu.org>
References: <87369fmd8d.fsf@gmail.com>
 <20200407175002.uzjqzm7fdgxftrrn@pelzflorian.localdomain>
 <87wo6r6ngn.fsf@gnu.org>
 <20200408095812.v3kuwakueh44g6mp@pelzflorian.localdomain>
 <87k12q5cyt.fsf@gnu.org>
 <20200409041411.yhi2qpkybn5grsaj@pelzflorian.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:45818)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMS2c-0001nn-Vc
 for bug-guix@gnu.org; Thu, 09 Apr 2020 03:56:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMS2b-00013t-TK
 for bug-guix@gnu.org; Thu, 09 Apr 2020 03:56:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41647)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jMS2b-00013f-QU
 for bug-guix@gnu.org; Thu, 09 Apr 2020 03:56:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMS2b-0005FP-PA
 for bug-guix@gnu.org; Thu, 09 Apr 2020 03:56:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.40493.D40493.158641890520100@debbugs.gnu.org>
In-Reply-To: <20200409041411.yhi2qpkybn5grsaj@pelzflorian.localdomain>
 (pelzflorian@pelzflorian.de's message of "Thu, 9 Apr 2020 06:14:11
 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 40493-done@debbugs.gnu.org

Hi Florian,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:

> On Wed, Apr 08, 2020 at 03:22:34PM +0200, Ludovic Court=C3=A8s wrote:
>> Go for it, thank you!
>
> I added some more heuristics on whether a layout is Latin or not and
> after much testing pushed as 91c231a2223440081426929828a23c7baa0214fd.
> There are still few false positives like non-Kana Japanese layouts
> that are Latin but toggle to U.S.  They can be fixed later.

Awesome!

> More importantly with 7bc71025ccd0fabd739803889825e10341fbabdf I also
> fixed a layout=E2=80=99s empty variant "" not being a choice in the insta=
ller.
> The "" variant is the only variant of the Azerbaijani layout providing
> the Latin script Azerbaijan uses since a few decades, so it is
> important.  I hope the code is alright; maybe I should not have just
> pushed, but I believe it is alright.

Good, it=E2=80=99s great you=E2=80=99re paying close attention to this.  Th=
e patch seems
reasonable to me.

> P.S. Don=E2=80=99t brag with Arabic support in Guix=E2=80=99 installer ju=
st yet
> because Arabs still have to confusedly read from left to right.
>
> https://bugs.gnu.org/35319
>
> But that is something to solve later.

Yeah.

I=E2=80=99ll run the =E2=80=9Cgui-installed=E2=80=9D tests to make sure eve=
rything=E2=80=99s is still
fine, then run =E2=80=9Cmake release=E2=80=9D and upload files for testing =
later today.

Thanks a lot, Florian!

Ludo=E2=80=99.