unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 40493-done@debbugs.gnu.org
Subject: bug#40493: installer: Provide a way to select multiple keyboard layouts
Date: Thu, 09 Apr 2020 09:54:54 +0200	[thread overview]
Message-ID: <87v9m93xgx.fsf@gnu.org> (raw)
In-Reply-To: <20200409041411.yhi2qpkybn5grsaj@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Thu, 9 Apr 2020 06:14:11 +0200")

Hi Florian,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:

> On Wed, Apr 08, 2020 at 03:22:34PM +0200, Ludovic Courtès wrote:
>> Go for it, thank you!
>
> I added some more heuristics on whether a layout is Latin or not and
> after much testing pushed as 91c231a2223440081426929828a23c7baa0214fd.
> There are still few false positives like non-Kana Japanese layouts
> that are Latin but toggle to U.S.  They can be fixed later.

Awesome!

> More importantly with 7bc71025ccd0fabd739803889825e10341fbabdf I also
> fixed a layout’s empty variant "" not being a choice in the installer.
> The "" variant is the only variant of the Azerbaijani layout providing
> the Latin script Azerbaijan uses since a few decades, so it is
> important.  I hope the code is alright; maybe I should not have just
> pushed, but I believe it is alright.

Good, it’s great you’re paying close attention to this.  The patch seems
reasonable to me.

> P.S. Don’t brag with Arabic support in Guix’ installer just yet
> because Arabs still have to confusedly read from left to right.
>
> https://bugs.gnu.org/35319
>
> But that is something to solve later.

Yeah.

I’ll run the “gui-installed” tests to make sure everything’s is still
fine, then run “make release” and upload files for testing later today.

Thanks a lot, Florian!

Ludo’.

      parent reply	other threads:[~2020-04-09  7:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 17:12 bug#40493: installer: Provide a way to select multiple keyboard layouts Mathieu Othacehe
2020-04-07 17:50 ` pelzflorian (Florian Pelz)
2020-04-07 20:38   ` Ludovic Courtès
2020-04-07 21:56     ` pelzflorian (Florian Pelz)
2020-04-08  9:58     ` pelzflorian (Florian Pelz)
2020-04-08 13:22       ` Ludovic Courtès
2020-04-09  4:14         ` pelzflorian (Florian Pelz)
2020-04-09  4:21           ` pelzflorian (Florian Pelz)
2020-04-09  7:25           ` Mathieu Othacehe
2020-04-09  7:36             ` pelzflorian (Florian Pelz)
2020-04-09 15:24               ` Ludovic Courtès
2020-04-09  7:54           ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9m93xgx.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=40493-done@debbugs.gnu.org \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).