bug#41791: [Shepherd] loses track of Tor

bug#41791: [Shepherd] loses track of Tor

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

All,

--8<---------------cut here---------------start------------->8---
~ λ while :; do sudo herd restart tor; done
Service tor is not running.
Service tor has been started.
Service tor has been stopped.
Service tor could not be started.
Service tor is not running.
Service tor could not be started.
^C
~ λ pgrep tor
22926
23004
--8<---------------cut here---------------end--------------->8---

This has (this year) happened to nginx in tight edit.conf/restart 
loops too, but I can't say if the two are at all related.

Here's the output of ‘herd status’ but it's not very useful to me:

--8<---------------cut here---------------start------------->8---
λ sudo herd status
Started:
 + dovecot
 + file-system-/dev/pts
 + file-system-/dev/shm
 + file-system-/gnu/store
 + file-systems
 + guix-daemon
 + loopback
 + mcron
 + networking
 + nginx
 + root
 + root-file-system
 + smtpd
 + ssh-daemon
 + syslogd
 + term-tty1
 + udev
 + urandom-seed
 + user-file-systems
 + user-processes
 + virtual-terminal
Stopped:
 - tor
One-shot:
 * host-name
 * user-homes
--8<---------------cut here---------------end--------------->8---

He looks guilty:

--8<---------------cut here---------------start------------->8---
λ sudo cat /var/run/tor/tor.pid
cat: /var/run/tor/tor.pid: No such file or directory
--8<---------------cut here---------------end--------------->8---

From ps auxwww:

--8<---------------cut here---------------start------------->8---
~ λ head -n6 /gnu/store/5ivhkbd0pzhnnmk38yn7cygcyd02kkk5-torrc
### These lines were generated from your system configuration:
User tor
DataDirectory /var/lib/tor
PidFile /var/run/tor/tor.pid
Log notice syslog
### End of automatically generated lines.
--8<---------------cut here---------------end--------------->8---

No contradictory lines added.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#41791: [Shepherd] loses track of Tor

[Ludovic Courtès]

Hi Tobias,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> ~ λ while :; do sudo herd restart tor; done
> Service tor is not running.
> Service tor has been started.
> Service tor has been stopped.
> Service tor could not be started.
> Service tor is not running.
> Service tor could not be started.
> ^C
> ~ λ pgrep tor
> 22926
> 23004

Oops, this one is fixed by b6b95685d0b478698d648f13afd927b1e1700d99.
It’s a regression introduced when switching to the Shepherd 0.8.1.

> This has (this year) happened to nginx in tight edit.conf/restart 
> loops too, but I can't say if the two are at all related.

The nginx issue may be different.  The Shepherd 0.8.0 included fixes
that should help for multi-process services like nginx.  Let me know if
it happens again.

Thanks for reporting the issue… and apologies for grumpily pushing you
to do so on IRC.  It’s a positive outcome at any rate!

Ludo’.

bug#41791: [Shepherd] loses track of Tor

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

Ludovic Courtès 写道：
> Oops, this one is fixed by 
> b6b95685d0b478698d648f13afd927b1e1700d99.

Impressive fanservice as always.

> The nginx issue may be different.  The Shepherd 0.8.0 included 
> fixes
> that should help for multi-process services like nginx.  Let me 
> know if
> it happens again.

I will.  It's possible that it hasn't happened since 0.8.0.

> Thanks for reporting the issue… and apologies for grumpily 
> pushing you
> to do so on IRC.  It’s a positive outcome at any rate!

The day I get to berate anyone for being grumpy will be a strange 
day in hell.

Thanks!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#41791: [Shepherd] loses track of Tor

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

All,

Unfortunately, this bug seems to have recropped up: 
<https://lists.gnu.org/archive/html/help-guix/2021-11/msg00126.html>.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#41791: [Shepherd] loses track of Tor

[Attila Lendvai]

i'm not sure this is related, but it's certainly a bug in MAKE-KILL-DESTRUCTOR
that it doesn't wait for the process to quit after sending it a signal, and thus
may restart the service while the previous instance is still running.

it's also not sending it a kill -9 after a timeout if the process is not
responsive.

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“[Design] Patterns mean "I have run out of language."”
	— Rich Hickey

bug#41791: [Shepherd] loses track of Tor

[Ludovic Courtès]

Hi Tobias,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> ~ λ while :; do sudo herd restart tor; done
> Service tor is not running.
> Service tor has been started.
> Service tor has been stopped.
> Service tor could not be started.
> Service tor is not running.
> Service tor could not be started.
> ^C
> ~ λ pgrep tor
> 22926
> 23004

I don’t see that happening with the Shepherd 0.9.3.  I believe this was
fixed by making ‘stop’ synchronous:

  https://issues.guix.gnu.org/58485

Closing!

Ludo’.