unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 43843@debbugs.gnu.org
Subject: bug#43843: git-annex is not Reproducible
Date: Mon, 12 Oct 2020 12:36:00 +0200	[thread overview]
Message-ID: <87v9ffybn3.fsf@elephly.net> (raw)
In-Reply-To: <CAJ3okZ2ND1sfC5yjhtmySb9WvrM9JDdonQnn56gTXNirLDKZgw@mail.gmail.com>


zimoun <zimon.toutoune@gmail.com> writes:

> On Sat, 10 Oct 2020 at 11:34, Ricardo Wurmus <rekado@elephly.net> wrote:
>
>> > --8<---------------cut here---------------start------------->8---
>> > 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2 is the first bad commit
>> > commit 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2
>> > Author: Ricardo Wurmus <rekado@elephly.net>
>> > Date:   Tue Jun 16 22:25:48 2020 +0200
>> >
>> >     build-system/haskell: Support parallel builds.
>> >
>> >     * guix/build-system/haskell.scm (haskell-build): Add keyword
>> >       PARALLEL-BUILD?
>> >     and pass it on to the builder.
>> >     * guix/build/haskell-build-system.scm (build): Accept keyword
>> >       PARALLEL-BUILD?
>> >     and pass the number of parallel jobs to GHC.
>> >
>> >  guix/build-system/haskell.scm       | 2 ++
>> >  guix/build/haskell-build-system.scm | 7 +++++--
>> >  2 files changed, 7 insertions(+), 2 deletions(-)
>> > bisect run success
>> > --8<---------------cut here---------------end--------------->8---
>>
>> Shall we revert it?  Previously the build system also supported parallel
>> builds, but didn’t seem to pass the right arguments to actually make it
>> happen.
>
> What do the Haskellers think about that?

Let me answer as an ex-Haskeller :)

> Does the parallel build save a lot of time and CPU?  If yes, maybe we
> could to provide a transformation for the expert, something like
> "haskell-build-system-with-parellel-build" which tweaks
> "PARALLEL-BUILD?", similarly to the recent "no tests".  WDYT?

We shouldn’t compromise reproducibility for parallel builds.  Ideally we
would figure out what exactly causes the differences and fix that
instead of disabling parallel builds, but if that turns out to be too
difficult I think we should just revert this until we have a good fix.

Perhaps something can be done by fixing the order of files somewhere.

-- 
Ricardo




  reply	other threads:[~2020-10-12 10:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 10:35 bug#43843: git-annex is not Reproducible zimoun
2020-10-08  3:04 ` Kyle Meyer
2020-10-08  6:17   ` Efraim Flashner
2020-10-09 20:33     ` zimoun
2020-10-10  9:35       ` Ricardo Wurmus
2020-10-12  9:31         ` zimoun
2020-10-12 10:36           ` Ricardo Wurmus [this message]
2020-10-12 11:55             ` zimoun
2020-10-13 13:05               ` Ludovic Courtès
2020-10-13 13:28                 ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9ffybn3.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=43843@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).