From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2JMHGTDxjV8EeAAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 20:04:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uIGYFDDxjV8zfAAA1q6Kng (envelope-from ) for ; Mon, 19 Oct 2020 20:04:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B9CD9418E1 for ; Mon, 19 Oct 2020 20:01:41 +0000 (UTC) Received: from localhost ([::1]:39148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUbLe-0005TA-M8 for larch@yhetil.org; Mon, 19 Oct 2020 16:01:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUbL4-0005PL-Oz for bug-guix@gnu.org; Mon, 19 Oct 2020 16:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUbL4-0000J2-Ep for bug-guix@gnu.org; Mon, 19 Oct 2020 16:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUbL4-0001Ea-Cr for bug-guix@gnu.org; Mon, 19 Oct 2020 16:01:02 -0400 Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Mon, 19 Oct 2020 20:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44027 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Mail-Followup-To: 44027@debbugs.gnu.org, rosen644835@gmail.com, mail@brendan.scot Received: via spool by 44027-done@debbugs.gnu.org id=D44027.16031376474706 (code D ref 44027); Mon, 19 Oct 2020 20:01:02 +0000 Received: (at 44027-done) by debbugs.gnu.org; 19 Oct 2020 20:00:47 +0000 Received: from localhost ([127.0.0.1]:42547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUbKp-0001Dq-3F for submit@debbugs.gnu.org; Mon, 19 Oct 2020 16:00:47 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUbKn-0001Da-D9 for 44027-done@debbugs.gnu.org; Mon, 19 Oct 2020 16:00:45 -0400 Received: by mail-wr1-f65.google.com with SMTP id e17so1044970wru.12 for <44027-done@debbugs.gnu.org>; Mon, 19 Oct 2020 13:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ih8gg5zo0scoUNUvL+BcY2tZX2kEPv1o9+5seyQAmaE=; b=DdQhkt73K+pZ+XfzorcuQSxJZnc5HgvTOrk/n+nRk7mfAZqo8yxYhfegARu5wg4UpJ 3KNgfm+CGUwJBSWU2uovUR2P1e9DqjC/Beutw1z1WABYAmj8pC5mlTHm+fPpvHq4zLgb rrlhot3IULg5mWx179h6sOYV78uWaZImFfA9su+iGo1WXAqmDE+j43iB0p7ILMKUaGFH 8Ryjie32JpNFtq79UGi5cYyUy/PEQCjJM9/9Tu6vXsFVSo6KTK5G1libCv2xgF7VnXF5 xwI8W2wVtBXBi77jp2Fm9sDQyjryLYEeKU83cubz43ymoMtQy7V0g5wybL6tBtfjSI34 NXaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ih8gg5zo0scoUNUvL+BcY2tZX2kEPv1o9+5seyQAmaE=; b=JK+w15Dqpa4zb+chjnydg8vRbLuLxUqE5kxMJl1A51UdE8TKFr812axoR+Me6fH6aA DcIN47KZc5MC3hiYtsUwPf7ZmIeJvlJaW0U4oZY1EXEvbwUk36hcmpVvjLNaPfSFxX5f 0vgzpRFKGf4lgItwgf6Z4GiOGCzQgju73ZEmA+GbFEVuHNQ41R31OknFX6WyYCFMmU2v q6MsuJsgTNxCK2mCCcpPwSjYtB4hB71MHTDLxZ+hMVnpMFVpsrtEYawggfAth1GDOAnu ojqtnQh0qzgeNBYVXz1WizK0f0tm1dOZ9ihQ/D1saBbct8YMp9YQf0t3Xts46bwM/GeZ Q3tQ== X-Gm-Message-State: AOAM533tgG9xG7Yl63YQ74NYNRZqFRnKlcsneac3tazVw15LbSnPZnUG 7J0VCdrdVZ4LnZMgU7YgYjStVvTbzudeNZ0F X-Google-Smtp-Source: ABdhPJwPTGKUiEmoDLVsF4BdERSGlHVYUB9YP/1erbV4haikGY30k3IUEh/G5NFz+AYBLqLaJAGaiw== X-Received: by 2002:a5d:410a:: with SMTP id l10mr961285wrp.274.1603137638993; Mon, 19 Oct 2020 13:00:38 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id 1sm1146816wre.61.2020.10.19.13.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 13:00:37 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> <87pn5emqzc.fsf@gnu.org> <87pn5enygh.fsf@gmail.com> <871rhukycl.fsf@gnu.org> Date: Mon, 19 Oct 2020 21:59:30 +0200 In-Reply-To: <871rhukycl.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 19 Oct 2020 17:51:54 +0200") Message-ID: <87v9f6kmvx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brendan Tildesley , 44027-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-TUID: xk+5AE09VyFw --=-=-= Content-Type: text/plain Hi, Mathieu Othacehe writes: > Hello Miguel, > >> Is there any other issue remaining? It doesn't modify this logic at >> all. Should I apply this patch to master then? > > Yes, your patch LGTM. Please make sure that system tests are still > working by running: > > make check-system TESTS="gui-installed-os gui-installed-os-encrypted > gui-installed-desktop-os-encrypted" I pushed it to master as 19c14d95b3 after running successfully these system tests. Thank you very much, and happy hacking! Miguel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+N8CMACgkQY0xuiXn6 vsLjHwwAqGKUU3mWw6i+MuU8ie7iYBWDl+nWcSTZ0QU2a+gWKapdrywyx0Bv5YGt dVow6MXGjhoelnrG2yiotitcb2Qrduck39Uj1RnXbfkfT0nAl/sNjY3L4ui2aqos jBz/F2lVgwqOFHeL1H2dp63DWH31kV3gQ55R7zbRZ1kcNFBywclv88QkIiov6P0g 6r54YwNhABqzZGOOQEGnWRXZAnOaeu4HXTwlqWIv4nVbzMRS0oEbe+Of9asUGGj3 xeZRUYo7zkcdW1pVvHctdoFDzGc+7XmzGO0ALomQiPvAI3Q44+W0qP/iaGkvOVrY RqKShVa5BjXNFoHjGymYuNWfiavO0FkQQw0WAGe6dgY8n4lHp5Cj7GKLHMMgcuff cFbZUA51GjjCoQiAds/a9hQwZvXPhSon0sfrHzO5qA824FeSCHb65Rz67UONekoG uoqYHIQZcK8jydPR0j/B/+DjyShsFSQIiV0Nd8A14BDfZW9ht4IRTpOXlboSN+LO MNjw50zi =5ywC -----END PGP SIGNATURE----- --=-=-=--