From: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: Brendan Tildesley <mail@brendan.scot>, 44027-done@debbugs.gnu.org
Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed.
Date: Mon, 19 Oct 2020 21:59:30 +0200 [thread overview]
Message-ID: <87v9f6kmvx.fsf@gmail.com> (raw)
In-Reply-To: <871rhukycl.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 19 Oct 2020 17:51:54 +0200")
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
Hi,
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hello Miguel,
>
>> Is there any other issue remaining? It doesn't modify this logic at
>> all. Should I apply this patch to master then?
>
> Yes, your patch LGTM. Please make sure that system tests are still
> working by running:
>
> make check-system TESTS="gui-installed-os gui-installed-os-encrypted
> gui-installed-desktop-os-encrypted"
I pushed it to master as 19c14d95b3 after running successfully these
system tests.
Thank you very much, and happy hacking!
Miguel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]
next prev parent reply other threads:[~2020-10-19 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 8:03 bug#44027: 1.2-29a2eb3 Installer fails at final stage installing GRUB Brendan Tildesley
2020-10-16 14:32 ` Ludovic Courtès
2020-10-16 22:55 ` Brett Gilio
2020-10-17 13:09 ` bug#44027: [PATCH] installer: Create bios_grub partition when it is needed Miguel Ángel Arruga Vivas
2020-10-18 2:02 ` Brendan Tildesley
2020-10-18 4:07 ` Brendan Tildesley
2020-10-18 15:52 ` Miguel Ángel Arruga Vivas
2020-10-18 17:03 ` Mathieu Othacehe
2020-10-19 5:57 ` Brendan Tildesley
2020-10-19 10:48 ` Mathieu Othacehe
2020-10-19 13:21 ` Miguel Ángel Arruga Vivas
2020-10-19 15:51 ` Mathieu Othacehe
2020-10-19 19:59 ` Miguel Ángel Arruga Vivas [this message]
2020-10-20 5:33 ` Bengt Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9f6kmvx.fsf@gmail.com \
--to=rosen644835@gmail.com \
--cc=44027-done@debbugs.gnu.org \
--cc=mail@brendan.scot \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).