From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YBsYIdEZbGBaXgAAgWs5BA (envelope-from ) for ; Tue, 06 Apr 2021 10:20:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iXvdGtEZbGD8RgAAbx9fmQ (envelope-from ) for ; Tue, 06 Apr 2021 08:20:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B35401603F for ; Tue, 6 Apr 2021 10:20:32 +0200 (CEST) Received: from localhost ([::1]:35502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTgwo-0000R6-Qj for larch@yhetil.org; Tue, 06 Apr 2021 04:20:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTgtS-0006Em-Qa for bug-guix@gnu.org; Tue, 06 Apr 2021 04:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTgtS-0004xx-HT for bug-guix@gnu.org; Tue, 06 Apr 2021 04:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lTgtS-0007R1-Ce for bug-guix@gnu.org; Tue, 06 Apr 2021 04:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#33848: Store references in SBCL-compiled code are "invisible" Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 06 Apr 2021 08:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33848 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Received: via spool by 33848-submit@debbugs.gnu.org id=B33848.161769699128538 (code B ref 33848); Tue, 06 Apr 2021 08:17:02 +0000 Received: (at 33848) by debbugs.gnu.org; 6 Apr 2021 08:16:31 +0000 Received: from localhost ([127.0.0.1]:39152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTgsx-0007QE-B8 for submit@debbugs.gnu.org; Tue, 06 Apr 2021 04:16:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTgsv-0007Q2-T4 for 33848@debbugs.gnu.org; Tue, 06 Apr 2021 04:16:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46292) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTgsp-0004WI-8n; Tue, 06 Apr 2021 04:16:23 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48682 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lTgso-00014Z-PW; Tue, 06 Apr 2021 04:16:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87r2e8jpfx.fsf@gnu.org> <87muoqhk62.fsf@ambrevar.xyz> <87zhsq8wkj.fsf@gnu.org> <87d0pmhbgn.fsf@ambrevar.xyz> <87r2e28tkv.fsf@gnu.org> <874laygkiy.fsf@ambrevar.xyz> <87lfa5eymf.fsf@ambrevar.xyz> <87tuoscsk9.fsf@gnu.org> <87im57b8u7.fsf@ambrevar.xyz> <87czvebky2.fsf@netris.org> <87eefu30a4.fsf@gnu.org> <87im56l6es.fsf@yamatai> <87wntm8j18.fsf@ambrevar.xyz> <87a6qil4b1.fsf@yamatai> <87a6qiz5b3.fsf@ambrevar.xyz> <871rbtc3j5.fsf@netris.org> <87r1js9udv.fsf@netris.org> <87sg47vp16.fsf@ambrevar.xyz> <875z139liy.fsf@netris.org> <87ft04sefs.fsf@gnu.org> <8735w472oo.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 Germinal an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 06 Apr 2021 10:16:20 +0200 In-Reply-To: <8735w472oo.fsf@netris.org> (Mark H. Weaver's message of "Mon, 05 Apr 2021 19:04:44 -0400") Message-ID: <87v98zomjv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pierre Neidhardt , 33848@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617697233; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=6YpvfJqKOqui2wSU2OtSCyrIZLpivplV+2VfS2Jo6wU=; b=nrFwGzNJEJp7VcIS/+ScRNgzGmmpsM2d3TEWPbOVwLT+EvKsMND2YVlFbx+p3FjxN82nhU /H+F/tj9/P0mfwJWHMlgtlW8urVUsrNlU42Yiddbfice9DJDTY/ZGYNxkWaYSEueP6pdaP 6kv7d4kFUg5LT+p4PCzs5YgmEd3b2SheQyfgiVlARk3YH62UonIQHNOJryoqq0jNI6SEZv Xcr8hTrUMRdvro6QykkEQRiYSu3CRCJECMNmvKrLxGcPdVn1JDJ4z5cYyYk9rgcHz1XiEx GueivWpjCs6nDHBSRIVMLh63YYaclN1XJqfs89a790xFEu61xVdn1YQaGEHItw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617697233; a=rsa-sha256; cv=none; b=D7HcEBBgfWIwKC9PG4Nw0/0YjR2ZRljFgONIEi6729sWz9GzfqVxQdzalLHDJglX1ebNa8 6U/Y1IqHqLONLVqxC1xOrHTnVrwG8i/+l6hpsSjxkDsrM761yC7VmNJUs2YTqT0X/UeKWH DOc9prW6Aphf81GvhvBJTtr52YWRNDW+P2xuUnE1VwAvpLO3KIHgHZE+dB8GRdkG1Y8sKO brzdCkWpMnjeqFO7bQXgE2jmIPSd2Q59BQVLVJlOn++Nd3/n9NFfU1z87mE365KkAOMpvM n9q4NzXVnfb7FPf2tHcGHnOExmzHqn5yKXeHcDmKLm40euI7hKsIHKggIHd5Ww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: B35401603F X-Spam-Score: -1.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: nWy58YpVCW/k Hi Mark, Mark H Weaver skribis: > That the scanner fails to find all references is clearly an important > problem that should be fixed ASAP, but as far as I can tell, improving > the grafter would not make that problem any worse or create any new > problems. > > Improving the grafter should have the following effects: > > (1) Reducing the number of cases where ungrafted code with security > flaws is being used on our systems. > > (2) Fixing problems in our Fish, Nyxt, and Common Lisp packages. These are cases where the scanner may get the references wrong in the first place though. OTOH, there are also cases where the scanner gets the references right. For example, earlier Pierre mentioned that grafting breaks the reference of nyxt to glib: https://issues.guix.gnu.org/33848#26 It turns out that the scanner does find a reference to glib =E2=80=9Cby cha= nce=E2=80=9D: --8<---------------cut here---------------start------------->8--- $ guix gc --references $(guix build nyxt --no-grafts) | grep glib-2 /gnu/store/4vmhbc31cpbnlw3c96kcc094ihmaf7dv-glib-2.62.6 $ grep -r 4vmhbc31cpbnlw3c96kcc094ihmaf7dv $(guix build nyxt --no-grafts) Duuma dosiero /gnu/store/5pgh0cn1kzyajaanj7f1iyp91hd917d6-nyxt-2-pre-releas= e-6/bin/.nyxt-real kongruas --8<---------------cut here---------------end--------------->8--- So in this case, the fixed grafter is a net win. After applying the patch you sent, I confirm that Nyxt starts just fine when running: ./pre-inst-env guix environment --ad-hoc nyxt -CN -E ^DISPLAY --share=3D/= tmp/.X11-unix -- nyxt =E2=80=A6 whereas on master it fails to start with: --8<---------------cut here---------------start------------->8--- Unhandled SIMPLE-ERROR in thread #: Problem running initialization hook GLIB::RUN-INITIALIZERS: Unable to load any of the alternatives: ("/gnu/store/4vmhbc31cpbnlw3c96kcc094ihmaf7dv-glib-2.62.6/lib/libglib-2.= 0.so.0" "/gnu/store/4vmhbc31cpbnlw3c96kcc094ihmaf7dv-glib-2.62.6/lib/libglib-2.= 0.so") --8<---------------cut here---------------end--------------->8--- > Improving the scanner, or adding phases to selected packages or build > systems to copy hidden references to an ASCII file, should have the > following effects: > > (1) Reducing the number of cases where run-time dependencies are not > known to Guix, which could lead to dependencies being prematurely > GC'd or excluded from things like "guix pack". > > So, it seems to me that we should persue both of these improvements > concurrently, and I see no practical advantage to postponing one for the > sake of rolling them both out at the same time. Of course, I welcome > other opinions on this. As always I worry about added complexity. In this case, I think you=E2=80= =99re right: the UTF-{16,32}-capable grafter would most likely fix a number of issues right away, including this Nyxt issue. Thanks! Ludo=E2=80=99.