unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#52598: Clojure-build-system failure at the unpack phase
@ 2021-12-18 11:34 Aleksandr Vityazev
  2021-12-18 12:47 ` Maxime Devos
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Aleksandr Vityazev @ 2021-12-18 11:34 UTC (permalink / raw)
  To: 52598

Hello,

Tried to build all the packages from gnu/package/clojure.scm that use
clojure-build-system. All have the same error:

--8<---------------cut here---------------start------------->8---
starting phase `unpack'
error: in phase 'unpack': uncaught exception:
wrong-type-arg "string-suffix?" "Wrong type argument in position ~A (expecting ~A): ~S" (2 "string" #f) (#f) 
phase `unpack' failed after 0.0 seconds
Backtrace:
           9 (primitive-load "/gnu/store/rw9rz7hahnvmlgk8ii1nfd94yc0…")
In guix/build/gnu-build-system.scm:
    904:2  8 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #)
In ice-9/boot-9.scm:
  1752:10  7 (with-exception-handler _ _ #:unwind? _ # _)
In srfi/srfi-1.scm:
    634:9  6 (for-each #<procedure 7ffff25c7540 at guix/build/gnu-b…> …)
In ice-9/boot-9.scm:
  1752:10  5 (with-exception-handler _ _ #:unwind? _ # _)
In guix/build/gnu-build-system.scm:
   925:23  4 (_)
In guix/build/ant-build-system.scm:
    147:6  3 (unpack #:source _)
In unknown file:
           2 (string-suffix? ".jar" #f #<undefined> #<undefined> #<…> …)
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure string-suffix?: Wrong type argument in position 2 (expecting string): #f
builder for `/gnu/store/8zzfxjymy042l28d3mryqgxgdq3f6pv3-clojure-tools-cli-1.0.206.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

-- 
Best regards,
Aleksandr Vityazev




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52598: Clojure-build-system failure at the unpack phase
  2021-12-18 11:34 bug#52598: Clojure-build-system failure at the unpack phase Aleksandr Vityazev
@ 2021-12-18 12:47 ` Maxime Devos
  2021-12-23 19:29 ` bug#52598: [PATCH] build-system: clojure: Allow clojure-build-system to pass source to ant Reily Siegel
  2022-01-12  8:11 ` bug#52598: Clojure-build-system failure at the unpack phase Ricardo Wurmus
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Devos @ 2021-12-18 12:47 UTC (permalink / raw)
  To: Aleksandr Vityazev, 52598

Aleksandr Vityazev schreef op za 18-12-2021 om 11:34 [+0000]:
> Hello,
> 
> Tried to build all the packages from gnu/package/clojure.scm that use
> clojure-build-system. All have the same error: [...]

I think the problem is that #:source is included in the private-
keywords in (guix build-system clojure), so the source isn't passed to
the builder, instead #false is passed. (untested)

While we're at it, we might want to modify 'unpack' in ant-build-system
to fail gracefully if there's no source (e.g. print an error like
‘source code is missing’ or something). That would probably incur many
rebuilds (though only of Java packages?), so that might need to be done
on a separate branch.


Greetings,
Maxime.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52598: [PATCH] build-system: clojure: Allow clojure-build-system to pass source to ant.
  2021-12-18 11:34 bug#52598: Clojure-build-system failure at the unpack phase Aleksandr Vityazev
  2021-12-18 12:47 ` Maxime Devos
@ 2021-12-23 19:29 ` Reily Siegel
  2022-01-12  8:11 ` bug#52598: Clojure-build-system failure at the unpack phase Ricardo Wurmus
  2 siblings, 0 replies; 4+ messages in thread
From: Reily Siegel @ 2021-12-23 19:29 UTC (permalink / raw)
  To: 52598


Fixes http://bugs.gnu.org/52598.

* guix/build-system/clojure.scm (lower): Remove #:source from private
keywords, preventing an error in ant-build-system.
---
 guix/build-system/clojure.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index 39b7f44e89..634854cf1b 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -81,8 +81,7 @@ (define* (lower name
                 #:allow-other-keys
                 #:rest arguments)
   "Return a bag for NAME."
-  (let ((private-keywords '(#:source #:target
-                            #:inputs #:native-inputs
+  (let ((private-keywords '(#:target #:inputs #:native-inputs
                             #:clojure #:jdk #:zip)))
 
     (if target
-- 
2.34.0





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52598: Clojure-build-system failure at the unpack phase
  2021-12-18 11:34 bug#52598: Clojure-build-system failure at the unpack phase Aleksandr Vityazev
  2021-12-18 12:47 ` Maxime Devos
  2021-12-23 19:29 ` bug#52598: [PATCH] build-system: clojure: Allow clojure-build-system to pass source to ant Reily Siegel
@ 2022-01-12  8:11 ` Ricardo Wurmus
  2 siblings, 0 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2022-01-12  8:11 UTC (permalink / raw)
  To: 52598-done

Thank you.  I applied this and pushed it to the master branch with
commit ee6c43f8cd46897bbe1a5a16c68049d7237ea806.

My apologies for the delay.

-- 
Ricardo




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-12  8:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-18 11:34 bug#52598: Clojure-build-system failure at the unpack phase Aleksandr Vityazev
2021-12-18 12:47 ` Maxime Devos
2021-12-23 19:29 ` bug#52598: [PATCH] build-system: clojure: Allow clojure-build-system to pass source to ant Reily Siegel
2022-01-12  8:11 ` bug#52598: Clojure-build-system failure at the unpack phase Ricardo Wurmus

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).