bug#55596: subversion segfaul on `guix import texlive`

bug#55596: subversion segfaul on `guix import texlive`

[Jack Hill]

Hi Guix,

With Guix commit 4ba4cb1d49d70a00f7236f60bd92e5eccef573dd on Linux x86-64, 
I have the following problem trying to import a texlive package:

"""
$ guix import texlive qrcode
command "svn" "export" "--non-interactive" "--trust-server-cert" "-r" "59745" "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/qrcode/" "/tmp/guix-directory.6aY7Gk/doc/latex/qrcode/" failed with signal 11
guix import: error: failed to import package 'qrcode'
"""

It seems something is unwell with our subversion package?

Best,
Jack

bug#55596: subversion segfaul on `guix import texlive`

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Jack Hill 写道：
> """
> $ guix import texlive qrcode
> command "svn" "export" "--non-interactive" "--trust-server-cert" 
> "-r"
> "59745"
> "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/qrcode/"
> "/tmp/guix-directory.6aY7Gk/doc/latex/qrcode/" failed with 
> signal 11
> guix import: error: failed to import package 'qrcode'
> """
>
> It seems something is unwell with our subversion package?

I don't know why I didn't think of this sooner, but I ran that svn 
command by hand (only replacing the output directory, say 
/tmp/foo) and… it ran fine.

So I checked my dmesg and it's actually Guix that's getting 
killed:

[146565.315921] guix[1767]: segfault at c0 ip 000076c46ae99e70 sp 
00007fffcbe9cb30 error 4 cpu 5 in 
libc-2.33.so[76c46ae57000+141000]
[146565.315937] Code: 56 41 55 41 54 55 48 89 fd 53 48 81 ec f8 04 
00 00 48 8b 05 ea 1f 15 00 48 89 34 24 89 4c 24 48 64 8b 00 89 84 
24 80 00 00 00 <8b> 87 c0 00 00 00 85 c0 0f 85 4a 02 00 00 c7 87 
c0 00 00 00 ff ff

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#55596: Guix/Guile segfaults on `guix import texlive`

[Akira Kyle]

Hi,

> I don’t think so; the error message that was reported is:
> 
>   command "svn" "export" "--non-interactive" "--trust-server-cert" "-r" "59745" "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/cite/" "/tmp/guix-directory.09UnsN/doc/latex/cite/" failed with signal 11
> 
> It’s a message from ‘report-invoke-error’ in (guix build utils).  It’s
> really svn that’s segfaulting.

I recently encountered this issue and did some digging. I don't think svn is actually segfaulting, just that the command svn doesn't exist so when 'system*' is called inside 'invoke' in (guix build utils) it for some reason gives signal 11.

On a recent guix system, I can reproduce this error by running 'guix import texlive' when inside 'guix shell guix --pure'. However there is no error when inside 'guix shell guix subversion --pure'. I think this is ultimately due to 'download-multi-svn-to-store' (and 'download-svn-to-store' but the texlive importer only calls the former) not setting '#:svn-command' when it calls 'build:svn-fetch' so it uses the default argument of 'svn' rather than trying to explicitly use an svn from the store.

Unfortunately my guile and gexp knowledge is quite lacking so I'm not sure that I have the know-how to create a patch to fix this, however hopefully this is enough for someone else to easily fix this issue.

Thanks,
Akira