bug#54973: Blender has no denoiser

bug#54973: Blender has no denoiser

[Haider Mirza]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

Blender in Guix has no denoiser, as Blender is not compiled with 
OpenImageDenoise or so Blender tells me.
Therefore, the denoiser just renders a black image if it's 
enabled.

Can you try and add this functionality as packaging 
OpenImageDenoise has turned out to be a massive pain.

[-- Attachment #2: Type: text/html, Size: 299 bytes --]

bug#54973: Blender has no denoiser

[raingloom]

On Sat, 16 Apr 2022 14:36:06 +0100
Haider Mirza <x7and7@gmail.com> wrote:

> Blender in Guix has no denoiser, as Blender is not compiled with 
> OpenImageDenoise or so Blender tells me.
> Therefore, the denoiser just renders a black image if it's 
> enabled.
> 
> Can you try and add this functionality as packaging 
> OpenImageDenoise has turned out to be a massive pain.

Can you send the WIP version of your OID package? Even if it's broken,
the person who tries to package it would benefit from seeing what
approach(es) have failed so far, so they don't repeat the same mistakes.
(That person could be me if no one gets on it. But I have uni stuff so
I'm not gonna promise anything.)

There are also other optional dependencies of Blender that would be
nice to have packages for.

bug#54973: Blender has no denoiser

[Haider Mirza]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

This is currently very broken but this is what I had:
It is requires a package called ISPC.

(define-module (oidn)
  #:use-module (guix packages)
  ;; #:use-module (gnu packages base)
  #:use-module (gnu packages gcc)
  #:use-module (gnu packages python)
  #:use-module (gnu packages tbb)
  #:use-module (gnu packages cmake)
  #:use-module (guix git-download)
  #:use-module (guix build-system cmake)
  #:use-module ((guix licenses) #:prefix license:))

(define-public oidn
  (package
   (name "oidn")
   (version "1.4.3")
   (source
    (origin
     (method git-fetch)
     (uri (git-reference
           (url "https://github.com/OpenImageDenoise/oidn.git")
           (commit (string-append "v" version))))
     (file-name (git-file-name name version))
     (sha256
      (base32 
      "14zga8xd7pxwhp50n36n0c8j12vdn92i90wf6nz868nlqvlpyakk"))))
   (build-system cmake-build-system)
   (inputs
    (list cmake gcc python tbb))     ; for scripts/MakeHeader.py
   (home-page "https://www.openimagedenoise.org/")
   (synopsis "A denoiser")
   (description
    "open source library of high-performance, high-quality 
    denoising filters for images rendered with ray tracing.")
   (license license:asl2.0)))


[-- Attachment #2: Type: text/html, Size: 1329 bytes --]

bug#54973: Blender has no denoiser

[Haider Mirza]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

I had tried to package ISPC but CMake doesnt seem to work with me.

(define-module (ispc)
  #:use-module (guix packages)
  #:use-module (gnu packages bison)
  #:use-module (gnu packages llvm)
  #:use-module (gnu packages python)
  #:use-module (gnu packages flex)
  #:use-module (gnu packages m4)
  #:use-module (gnu packages version-control)
  #:use-module (gnu packages cmake)
  #:use-module (guix git-download)
  #:use-module (guix build-system cmake)
  #:use-module ((guix licenses) #:prefix license:))

(define-public ispc
  (package
   (name "ispc")
   (version "1.17.0")
   (source
    (origin
     (method git-fetch)
     (uri (git-reference
           (url "https://github.com/ispc/ispc.git")
           (commit (string-append "v" version))))
     (file-name (git-file-name name version))
     (sha256
      (base32 
      "1klk1mhxjvyhzf1kqznimdb2f96czp76k8riv8yda87gfrk7cmfn"))))
   (build-system cmake-build-system)
   (inputs
    (list cmake python bison flex m4 git clang))     ; for 
    scripts/MakeHeader.py
   (home-page "https://www.openimagedenoise.org/")
   (synopsis "compiler for a variant of the C programming 
   language")
   (description
    "ispc is a compiler for a variant of the C programming 
    language, with extensions for single program, multiple data 
    programming.")
   (license license:bsd-3)))

[-- Attachment #2: Type: text/html, Size: 1434 bytes --]

bug#54973: Blender has no denoiser

[Haider Mirza]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

I will close this Issue as it is open for pretty much no reason.
Thank you to Raingloom and anyone else who responded!

I might send a patch in the future tackling this problem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

bug#54973: control message for bug #54973

[Haider Mirza]

[-- Attachment #1: Type: text/plain, Size: 17 bytes --]

close 54973
quit

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

bug#54973: control message for bug #54973

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hullo,

Haider Mirza 写道：
> close 54973
> quit

This kind of message works only if sent to the ‘control@’ address 
instead of the bug address.

The (IMO easier) way to close issues is to ‘Reply’ and simply edit 
the address to add ‘-done’ or ‘-close’ after the bug number, as 
I've done with this message.

Thanks!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]