From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aON1KhHT6GKbwQAAbAwnHQ (envelope-from ) for ; Tue, 02 Aug 2022 09:32:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KNddKhHT6GLpZgAAauVa8A (envelope-from ) for ; Tue, 02 Aug 2022 09:32:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 05121ECF9 for ; Tue, 2 Aug 2022 09:32:33 +0200 (CEST) Received: from localhost ([::1]:55434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oImOF-0005yI-WD for larch@yhetil.org; Tue, 02 Aug 2022 03:32:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oImNn-0005xy-Fl for bug-guix@gnu.org; Tue, 02 Aug 2022 03:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oImNm-0002bh-QX for bug-guix@gnu.org; Tue, 02 Aug 2022 03:32:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oImNm-0002Ak-L4 for bug-guix@gnu.org; Tue, 02 Aug 2022 03:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56799: (gnu services configuration) usage of *unspecified* is problematic Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 02 Aug 2022 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56799 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 56799@debbugs.gnu.org, attila@lendvai.name Received: via spool by 56799-submit@debbugs.gnu.org id=B56799.16594254888295 (code B ref 56799); Tue, 02 Aug 2022 07:32:02 +0000 Received: (at 56799) by debbugs.gnu.org; 2 Aug 2022 07:31:28 +0000 Received: from localhost ([127.0.0.1]:42162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oImND-00029j-Gn for submit@debbugs.gnu.org; Tue, 02 Aug 2022 03:31:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oImNB-00029H-Au for 56799@debbugs.gnu.org; Tue, 02 Aug 2022 03:31:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oImN4-0002We-A8; Tue, 02 Aug 2022 03:31:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=vR4wkYI3U0c9ARDdK7hveBQ5xBGZgIa4JXtYDY7rBak=; b=AV9GRcJ6jzjRlpWPzG2d KQv9C36PPieCe2ZWH0qAhd16dr8CgcEF1FOV5KvlMkQZLKfScGe4omrF44tkQsxmGcDPnx5I1vAbP Vrs0PIpkyekpQsSmRqYWO99a2Lc8i9UBCWYHiVIERy2PaegbtPzZpnHVa+bIKJ8Vfc1kWaukmxGBj ElCBUJBu4xGcLxQXYLvjzSuZ0pGkyzA/JXRLjz5Qr+N+sAa8XoLHBZ6lVcdf2+YtMtHGgq4181rq4 1ead/Tat0+HjNcsU6WNwRMd70+okKJpZaopOo4RujwigCUxOUeYb1eNi8ElLYrITD7QU7+Hi7clIE /EhYpk5Ji/y4IQ==; Received: from [193.50.110.235] (port=43288 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oImN3-0004cq-Ph; Tue, 02 Aug 2022 03:31:18 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87o7xa8qxt.fsf@gmail.com> <8735egxedv.fsf@gnu.org> <87les82c2f.fsf@gmail.com> Date: Tue, 02 Aug 2022 09:31:14 +0200 In-Reply-To: <87les82c2f.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 01 Aug 2022 11:55:20 -0400") Message-ID: <87v8rbumnx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659425553; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vR4wkYI3U0c9ARDdK7hveBQ5xBGZgIa4JXtYDY7rBak=; b=dUL5s23zjuUF9Sr6qK+USpZL3+KgH++vaS+MHkiQagN4JLLIRuETNHb+q0eO/4Jfm2MjgN vrK8GN9Z1gKr0462LZRdDyBjNE5hKXsQAzeb3ZE6kVOTnMFIuixAmBTRgRVb6bRbqLK8iY kK7TpbpAunIyzDkQk2ZBDXngklR2dwv38BM0/CrhpGvvn+j3QQOz9t5Jwsu02pWxsGUI2i WaQhvl0v0JkFadeAc5oLMti8hMt++fKxUGP3HY7TWcWbwwDva60sWnZYukPj1qya/TBiRu S9g4DE73hH2NVjeiffqNcSV9qoIg+zdGbSbeYOMsiTJwNqB9qeyC1Acsh639LQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659425553; a=rsa-sha256; cv=none; b=JfZhqvJjfcY9cNPsqexC9feYCno0xqK9jjojh2yepMbzd6watsPuT8bw/G/Sqh51LVMspI tLI2iutWYxFVdlDCIWQUllP3YVCk/dHYZzRzVFaIYh+kMHal62RNs0eqlQMO1dRreSrgmN UHhnuPp3wLtPMWrqH3ec2XCRwNfK8WQztttco87g6PgH7BEhDEUX7qe9FavnMktEsfZn2R 6nYxXeFZwqjyCoGru+WIvWfVzg/euzv0awzizJrYkzY3akH/BD1223itmrhe3e3a/ILpzE 8PUKCcGHsGPykskGUScUpv9DGbA4VlwCQaMes76Q1ObBwzv4suNvsdkZmu7/PQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=AV9GRcJ6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.82 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=AV9GRcJ6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 05121ECF9 X-Spam-Score: -3.82 X-Migadu-Scanner: scn1.migadu.com X-TUID: ctwzq3uckMR4 Hi, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> Hi! >> >> Maxim Cournoyer skribis: >> >>> Since commit 8cb1a49a3998c39f315a4199b7d4a121a6d66449, the >>> define-configuration machinery in (gnu services configuration) uses >>> *unspecified* instead of 'disabled for an unspecified field value. >> >> As Attila wrote, the rationale as discussed in >> was to specifically use a =E2=80=9Cs= pecial=E2=80=9D >> value without a read syntax in lieu of a symbol like 'disabled. >> >>> While this is indeed an improvement in readability, it introduces an >>> extra complication: because this new value is not self-quoting, it >>> cannot be used as is in G-Exps, and values using it must be carefully >>> expanded outside the gexp context, which is error prone. >> >> Could you give a simple example of how this can happen? >> >> In my experience, one would use =E2=80=98define-maybe=E2=80=99 and appro= priate field >> serializers such that *unspecified* never goes through. Previously >> you=E2=80=99d check for (eq? x 'disabled) and now you just check for >> (unspecified? x). > > Yes, I understand that. What changed is that previously you could have > the configuration serialized and used on the service side, which is what > using *unspecified* made impossible. Do you have an example? Even on the service side, I imagine one could check for =E2=80=98unspecified?=E2=80=99 just like one would check for 'dis= abled, no? > Granted, few services outside of Jami probably made use of this, but it > was nevertheless a useful property. I don=E2=80=99t know of any. Having spent time reviewing the original change that Attila proposed and then chiming in on this issue, I would have hoped for a longer discussion before enacting the change in a2b89a3319dc1d621c546855f578acae5baaf6da. In addition to these issues around the process, I think we should strive for more stability. One of the reasons it took time to review is that interface changes are a commitment. Now commit a2b89a3319dc1d621c546855f578acae5baaf6da introduces a second interface change for reasons that are unclear to me (if the conclusion had been to revert, I=E2=80=99d have favored an actual r= evert rather than introducing 'unset). How should we move forward? Thanks, Ludo=E2=80=99.