From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EKOWKTNy9WOsDgEAbAwnHQ (envelope-from ) for ; Wed, 22 Feb 2023 02:38:59 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mHFjKTNy9WPE7gAAauVa8A (envelope-from ) for ; Wed, 22 Feb 2023 02:38:59 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4603C3D0D6 for ; Wed, 22 Feb 2023 02:38:59 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUdpb-0002sf-3h; Tue, 21 Feb 2023 20:22:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUdpa-0002sN-1n for bug-guix@gnu.org; Tue, 21 Feb 2023 20:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUdpZ-0006eD-PT for bug-guix@gnu.org; Tue, 21 Feb 2023 20:22:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUdpZ-0003w8-Ku for bug-guix@gnu.org; Tue, 21 Feb 2023 20:22:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61676: package transformations not honored working from a manifest Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 22 Feb 2023 01:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61676 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61676@debbugs.gnu.org Received: via spool by 61676-submit@debbugs.gnu.org id=B61676.167702886915067 (code B ref 61676); Wed, 22 Feb 2023 01:22:01 +0000 Received: (at 61676) by debbugs.gnu.org; 22 Feb 2023 01:21:09 +0000 Received: from localhost ([127.0.0.1]:57578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUdoj-0003ux-7B for submit@debbugs.gnu.org; Tue, 21 Feb 2023 20:21:09 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:40560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUdoe-0003u4-1r for 61676@debbugs.gnu.org; Tue, 21 Feb 2023 20:21:07 -0500 Received: by mail-qt1-f181.google.com with SMTP id h19so3733479qtk.7 for <61676@debbugs.gnu.org>; Tue, 21 Feb 2023 17:21:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=pbvO7ZYR/L4EBJSAyQQ+CEMrIB/EqOoc8vWd9drVcLM=; b=KSvm5IKzPHfYaaXhfD1kA/j7Z2I0uu9uCdL+bqvT+VPl2uUXGM5Bd6DBwxReoouBwg h3nHHG/f/3E24gj6w/8UZ7DsSjnGfuCrpvznS6xDqoeeFjDFF+i4mPEa3ZuapkZGmf6f HTYvbkQr+Lz53XPWWvnCIZBR4PEXHT0bkN/LAuKAzsFak1h7/FnguRmG2Ks3HlsrWp1I NM1wyTkinK+rgm9T+jTJyvbzhukDzBgwG5YJkcISmttfdBEol0dgPgqN6prEkzu7MIX3 6CGhafKqZIVZKwPga91sAH3PphHzyIfTtASfkGfUxZcZXad0bh8PeX+4JndiZRgLZzHL 5pqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pbvO7ZYR/L4EBJSAyQQ+CEMrIB/EqOoc8vWd9drVcLM=; b=fPvXUs3EnvO3Jkc+wiuP1UrFjN8piIMkg53ix3Ay4U074E7k/1zUwJFQmFK0Wjo14S R7KaykEo3LQCwuuXgzWZNfHah44VC6UyeJuDeJV6C+EYhRj0Qy/EihFuRlBWZeZdMro+ LngrRGdcFWpKUgXSx24NRJwu/JHzrbysReP+PZEt4KIi1rprMqihHGuUTdUTMF0q4OMz 0VyN9jXVZFjCHbtj6UXkkOW4IcAV9D4g7BuxBj+ANQlRjBsBrNaFaGBVwEeDBRDpDJqY Wr4TGjlhZK5CwDjR1tNbcAM434kdXFEfuwnz6kWuEScWnkX/S0neaPoesXzLOsR7/8Eg I5Ww== X-Gm-Message-State: AO0yUKVePd2LwDxsotYAuT4h7m6nBNlIA+gO7IfrHf3QMIR/wF53jtu8 /ma1zyVkaXGQyuoUFx1CQ90ywHW0veHc/g== X-Google-Smtp-Source: AK7set8/ilIYcQOR2ucBCaW1GagbNgKrFCYJFa46ZFK93Bq5SnIVfEBfYTD2wtqVFzax65HjC/8+Zg== X-Received: by 2002:a05:622a:18a2:b0:3b8:2033:78e3 with SMTP id v34-20020a05622a18a200b003b8203378e3mr27352411qtc.55.1677028858183; Tue, 21 Feb 2023 17:20:58 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1002]) by smtp.gmail.com with ESMTPSA id d17-20020ac800d1000000b003bd0719cf20sm910802qtg.39.2023.02.21.17.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 17:20:57 -0800 (PST) From: Maxim Cournoyer References: <87mt57jgns.fsf@gmail.com> <87r0uid474.fsf@gnu.org> Date: Tue, 21 Feb 2023 20:20:56 -0500 In-Reply-To: <87r0uid474.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 21 Feb 2023 23:49:35 +0100") Message-ID: <87v8juebrb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KSvm5IKz; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677029939; a=rsa-sha256; cv=none; b=AGztFmnWglXqAugDz0JFLx4qCTfb7agNFSn9mIPlIVNE3RztgfqIIobncfIrZf/nAKMZ7M aEuV57hrPSCnyBYk+JEFwcvsc6LcqzjlH2OeksvZp+VC5wuedXiuI9Yg8q6JfjuoSGlT6D BvmizPdkjbwK+a4vhk4jV0wxUoqZ9rfUyV40D9O46hd+UiInG9w+bX5C5HTi2EZzRrllrJ 2z/JosNgvexEBXiquUgWntg/dducxWWaNFP6htm7LFGjf7a0jTL/XkDbmn8qAmZKaGuQjr GurVISNJckinb7zMxifYvuzJp4e1e4g9NiTKPcTaeHtqmSebn+1c58AmnC9bxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677029939; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pbvO7ZYR/L4EBJSAyQQ+CEMrIB/EqOoc8vWd9drVcLM=; b=u/UniEQc49Q3reIcgv1Bg/vYPRUA/la9W1I8J3MW2FD7aeIgS+r8Pfs+Jovd0j8TlFrXsx WBNtYkR6YD8Vep+9TUebaDXJfteogqHn/7kbJgen2oUK3+rqZCv6P8Fj6yTXpyVl4z30ej aLX/UKt/L2zbYgqaA9fVRdX8Axbm3KIxhVeJqdxJ8gl5WosIf8iGoHvL9UNCbIqLZdvHxO Pfdn8cDARbhlRY9EpWbKStRLuR0jYQjx0+MMsFP1SAwVUHPnQGOANZbuHXNV+9N1TmxE14 QTQ/aqWZpjnHU1d+UbHk3mIk+RoL+EoUpIrfztySuiFhpMCxHBiczGVOIiUqlA== X-Spam-Score: 5.84 X-Migadu-Queue-Id: 4603C3D0D6 X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: 5.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KSvm5IKz; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: k4b67UrmsFRK Hi Ludo! Ludovic Court=C3=A8s writes: [...] >> But noticed that --with-source and --with-patch were not effective for >> the jami-with-certs customized package provided by the >> guix-pack-manifest.scm manifest. > > Indeed, that=E2=80=99s expected. > >> It seems to me that the rewriting options should be honored on any >> packages being manipulated, whether they come from the Guix collection, >> a file, a manifest or another means. > > I=E2=80=99m not convinced; I think manifests should be interpreted litera= lly. Perhaps I do not have the full picture in my head, but if someone calls 'guix pack -m my-manifest.scm --with-source=3Dsome-package=3Dthe-source.tar.gz', it'd seem the --with-source option pretty useless in this case if it doesn't touch the manifest's packages graph. It'd rather it error out with a message like: "package rewriting options have no effects for manifests", although I'd rather it was possible. Is there another alternative for the use case I'm after? The only other option available seems to be to extend the GUIX_PACKAGE_PATH with a module and to use -e '(@@ (my module) jami-with-certs)'; would the jami-with-certs graph get rewritten then? I also got bit by #61684, which muddied the waters some more :-) --=20 Thanks, Maxim