From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KOxvHAFk/WOmVwEAbAwnHQ (envelope-from ) for ; Tue, 28 Feb 2023 03:16:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ULxoHAFk/WNCLAEA9RJhRA (envelope-from ) for ; Tue, 28 Feb 2023 03:16:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E41FFDFF7 for ; Tue, 28 Feb 2023 03:16:32 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=pZG6Zkbp; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677550593; a=rsa-sha256; cv=none; b=LFJj3cEIRUrL0klc0qpjECf0Bi2/9ZmS7f77eZp8+MasONKtC+x+rjNNqXzvib5RCWFGER JOAGO2RK90P4z1R5tNUD2UBc23OBM1o49PDxEcZiO8dNxdCaSIsJIuu8FZ3GkRrBEpTCOt Q72ReN9mRvtdEF26bCvt6jG2jeCjSpH6RaeGgq/Da9y+/fxLFqQG4Il9zf+6SvkfeetMgs 8YSU7Cny8PUkGxMEd3nlL1YQfe2Mb4VHfBdkAXSWdiYU/Bf2zmSwHvhc4L9s82QUV3xYUU pIKTbSq+dXw7oQQyUIu77bSrgtwiWOw+wMYqP1GhQ49RYXW27mq/wnVXsyi85Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=pZG6Zkbp; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677550593; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qu6s89WdOd4+KvCwPnbC8AxBI2o/qWoHeqrEjv2CfWM=; b=DwCZqR6GmXLzWsWXxg728VqeIdSdMHQrZXEqXE2QHldicKcrN4lOjcnOq8uI0+qjgp7p9m jJ3aHU3/jVh0dlMl7smjenjjpSv8Z6EWC2rVpQoX2lm5153DgYmwivyzUjjLC0kf92TpD7 CEmarSapydICvcPVlyq7ktaJx3DO8TxjXUFs7ixW4GlmwAPR6gVfMecLvnSSRSdwH84FJa F/Hzha+28R2IfuW6IbIIsLophHDLh047q3Oz/iZuOGZlIgauIBhJhEDpZwCKSAw9JkTnDZ pBC9VqW4uIyaVKQPxFRBn+14tSv41WcTt7bY1RseFBeqlXcc7wyzmGC8KQnhLg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWpXE-00010p-88; Mon, 27 Feb 2023 21:16:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWpX9-0000zA-T0 for bug-guix@gnu.org; Mon, 27 Feb 2023 21:16:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWpX9-0003GM-L3 for bug-guix@gnu.org; Mon, 27 Feb 2023 21:16:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pWpX9-0003Io-GP for bug-guix@gnu.org; Mon, 27 Feb 2023 21:16:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61853: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?pack=E2=80=99?= shell tests fail Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 28 Feb 2023 02:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61853 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61853@debbugs.gnu.org Received: via spool by 61853-submit@debbugs.gnu.org id=B61853.167755053012590 (code B ref 61853); Tue, 28 Feb 2023 02:16:03 +0000 Received: (at 61853) by debbugs.gnu.org; 28 Feb 2023 02:15:30 +0000 Received: from localhost ([127.0.0.1]:49388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWpWb-0003H0-Ub for submit@debbugs.gnu.org; Mon, 27 Feb 2023 21:15:30 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:39666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWpWY-0003Gj-NY for 61853@debbugs.gnu.org; Mon, 27 Feb 2023 21:15:28 -0500 Received: by mail-qt1-f173.google.com with SMTP id w23so9030762qtn.6 for <61853@debbugs.gnu.org>; Mon, 27 Feb 2023 18:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qu6s89WdOd4+KvCwPnbC8AxBI2o/qWoHeqrEjv2CfWM=; b=pZG6ZkbprMp6UoTUQKmd5Sn97AQ7+QT2xGWNkGHSGgNEb0486RPZzDViHfbdd/wbE/ 9Ca/fzpVVa5W66gTEXpt0igkT9LPXU1dW7ci39lNdGszrgbLNjeVHt8qqrZtmZahLO8K rT8xw5mgWjompHenfcutzcgzD7rEN404mTm2LDgdoyy+6Nfdgr4D4WB2Pvjvf/lFqQs4 I37ZZBr1gQxr9ZrQjVgNGGXEePSRR02DDp7TgLNVZt5GMyaynP9GFbgAm43g5KzwO2HM wkvA7mh/TM5rW/gItrkAq/A9kZahA29P0W9Dc90E2S8fJ2FzWarTu42FvoeKL1bf3KcM SAFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qu6s89WdOd4+KvCwPnbC8AxBI2o/qWoHeqrEjv2CfWM=; b=ukjsffk9tm/I0CWYI+I86PtVRuWmSqx8IzcwOMV/TCiHNKz1KWUKbdoK6hEg+CI2Ik G/cXL+lgpaMniaNyjcHMcw/zb3C6Ha4O9G4vYAlRSjh2VmvdrJxA6FNg+tVJ8gz/t1rl udeXPCvXa+hP49Q80exw0FNVKoqOS0PkCSY4QE3RIf1GKz0twyr2pTcKiIiXGJHuzbWz xONxGPFdiuSSJN0szqL8zGow3jAHN3ej2T57TGIcVm22vAbIvzI+6JRK007Dlp6Egnzp E2BPh0oxgL9TwMISuxJMM4bJrOhBCrxsVxamszLLeoieaZxY/8IUzMCmg9TNOGSIauYn pHgQ== X-Gm-Message-State: AO0yUKXnV/L2PisajR7CSTZkhB3SWuI2Wrv+/mnSmmW92ApMWB3LDS+L sOfFG78beWeHC5G5hKd9b8v6zzjEG2e2/tbL X-Google-Smtp-Source: AK7set9gVi6lQeJbqp42+gPZY9wkfA6NcAtf8Ox67ZuUxO+Nmwfbv7KVdfBxFqal3gQWSW4C1971ew== X-Received: by 2002:a05:622a:1206:b0:3bf:db29:b793 with SMTP id y6-20020a05622a120600b003bfdb29b793mr2246069qtx.20.1677550520928; Mon, 27 Feb 2023 18:15:20 -0800 (PST) Received: from hurd (dsl-156-86.b2b2c.ca. [66.158.156.86]) by smtp.gmail.com with ESMTPSA id c20-20020a05620a269400b0073b81e888bfsm5916465qkp.56.2023.02.27.18.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 18:15:20 -0800 (PST) From: Maxim Cournoyer References: <871qmahjcy.fsf@inria.fr> <87wn42emh8.fsf@gnu.org> Date: Mon, 27 Feb 2023 21:15:18 -0500 In-Reply-To: <87wn42emh8.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 28 Feb 2023 00:07:31 +0100") Message-ID: <87v8jmilhl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: E41FFDFF7 X-Spam-Score: -3.39 X-Migadu-Spam-Score: -3.39 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: dRuHctnNjnik Hi Ludovic, Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> In both cases this is because $test_directory is read-only: > > This in turn is due to a permission change in generated tarballs: > > $ guix describe > Generation 248 Feb 27 2023 16:36:12 (current) > guix cf9e050 > repository URL: https://git.savannah.gnu.org/git/guix.git > branch: master > commit: cf9e0508b26196dc985302776d860a0359652c59 > $ guix pack hello > /gnu/store/k0mjzvv76s0yn4r4mwzy6mvf71wxpbg2-hello-tarball-pack.tar.gz > ludo@ribbon ~/src/guix$ tar tzvf /gnu/store/k0mjzvv76s0yn4r4mwzy6mvf71wxp= bg2-hello-tarball-pack.tar.gz |head > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/include/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/ > -r--r--r-- root/root 2056 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/= crtbegin.o > > > Compared to: > > $ guix time-machine --commit=3Dv1.4.0 -- pack hello > /gnu/store/vjjavmn16mxzgrlfawjcgq5j4iqm7609-hello-tarball-pack.tar.gz > $ tar tzvf /gnu/store/vjjavmn16mxzgrlfawjcgq5j4iqm7609-hello-tarball-pack= .tar.gz | head > drwxr-xr-x root/root 0 1970-01-01 01:00 ./ > drwxr-xr-x root/root 0 1970-01-01 01:00 ./gnu/ > drwxrwxr-t root/root 0 1970-01-01 01:00 ./gnu/store/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/include/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/ > -r--r--r-- root/root 2056 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/= crtbegin.o > tar: stdout: write error > > That=E2=80=99s an acceptable change IMO, introduced in > 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were > evidently not run after that change, which is problematic. Interesting. I had done all my testing using tests/pack.scm (and the new tests/rpm.scm), and overlooked tests/pack.sh. > Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests > now pass for me. Thanks (again)! > One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that > it introduces a copy of the profile being built to the store > (=E2=80=9Cprofile-directory=E2=80=9D). This was purposefully avoided bef= ore because > it=E2=80=99s very I/O-intensive, space-consuming, and puts more pressure = on the > store. It=E2=80=99s a pattern we avoided for system images too, having n= oticed > its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.) > > We may need to come back to a single derivation well or creating packs > for big profiles will be too costly. I agree it's expensive; we're trading IO for storage though, so the case of generating the same pack in multiple format, it could be beneficial by only computing the union directory once. The real motivation was avoiding code duplication though; perhaps this could be accomplished by moving the common logic to (guix build pack-utils)? --=20 Thanks, Maxim