unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Emmanuel Beffara <manu@beffara.org>
Cc: 62140@debbugs.gnu.org, Michael Rohleder <mike@rohleder.de>,
	44877@debbugs.gnu.org
Subject: bug#44877: bug#62140: enable LVM in Grub
Date: Thu, 23 Mar 2023 08:48:46 -0400	[thread overview]
Message-ID: <87v8ireiq9.fsf@gmail.com> (raw)
In-Reply-To: <20230314222628.GE14391@beffara.org> (Emmanuel Beffara's message of "Tue, 14 Mar 2023 22:26:28 +0100")

Hi,

Emmanuel Beffara <manu@beffara.org> writes:

> De Michael Rohleder le 13/03/2023 à 14:56:
>> Hello Emmanuel!
>> 
>> Thx for the report!
>> 
>> I think this is bug 44877, maybe we can/should merge it.
>> Here [1] is a patch (and testcase).
>> 
>> 
>> [1]  https://issues.guix.gnu.org/60442
>
> Indeed, it seems to be the same issue.
>
> However, the patch sets the value of `GRUB_PRELOAD_MODULES`, which afaik is
> used by `grub-mkconfig` to produce `grub.cfg`, but there seems to be code in
> `grub.scm` that also produces `grub.cfg`, and no call to `grub-mkconfig`
> there. I'm not sure I understand how all this works anyway…

Guix indeed takes care to generate the grub.cfg itself, via the
make-grub-configuration procedure from (gnu bootloader grub), and
grub-mkconfig is *not* used.

grub-install is used though, so perhaps GRUB_PRELOAD_MODULES could be
honored by it (although it's not documented so I doubt it).  It seems to
me that since we produce grub.cfg ourselves if there's something to add
there for LVM support (which I'm not sure there is -- apparently it
already works for you ?), it should be explicitly coded in (gnu
bootloader grub).

info '(grub) Changes from GRUB Legacy' mentions that "* GRUB 2 can read
files directly from LVM and RAID devices.", so I would think there's
nothing special to do?

-- 
Thanks,
Maxim




  reply	other threads:[~2023-03-23 12:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 18:02 bug#62140: enable LVM in Grub Emmanuel Beffara
2023-03-13 13:56 ` bug#44877: " Michael Rohleder
2023-03-14 21:26   ` Emmanuel Beffara
2023-03-23 12:48     ` Maxim Cournoyer [this message]
2023-03-23 14:58       ` Emmanuel Beffara
2023-03-24 12:24         ` Maxim Cournoyer
2023-03-28 12:32           ` Emmanuel Beffara
2023-03-28 14:10             ` Maxim Cournoyer
2024-01-23 16:36 ` Erik Eduardo via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8ireiq9.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=44877@debbugs.gnu.org \
    --cc=62140@debbugs.gnu.org \
    --cc=manu@beffara.org \
    --cc=mike@rohleder.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).