From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4IueLJr1ImTnQQEASxT56A (envelope-from ) for ; Tue, 28 Mar 2023 16:11:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gC5ILJr1ImSEcwEAauVa8A (envelope-from ) for ; Tue, 28 Mar 2023 16:11:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 880D288CE for ; Tue, 28 Mar 2023 16:11:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phA2h-0000p0-CT; Tue, 28 Mar 2023 10:11:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phA2R-0000TH-UK for bug-guix@gnu.org; Tue, 28 Mar 2023 10:11:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phA2R-0003Um-1W for bug-guix@gnu.org; Tue, 28 Mar 2023 10:11:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phA2Q-00023i-T7 for bug-guix@gnu.org; Tue, 28 Mar 2023 10:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#62140: enable LVM in Grub Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 28 Mar 2023 14:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62140 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Emmanuel Beffara Cc: 62140@debbugs.gnu.org, Michael Rohleder , 44877@debbugs.gnu.org Received: via spool by 62140-submit@debbugs.gnu.org id=B62140.16800126477884 (code B ref 62140); Tue, 28 Mar 2023 14:11:02 +0000 Received: (at 62140) by debbugs.gnu.org; 28 Mar 2023 14:10:47 +0000 Received: from localhost ([127.0.0.1]:50347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phA2A-000231-IO for submit@debbugs.gnu.org; Tue, 28 Mar 2023 10:10:46 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]:36504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phA29-00022i-5N; Tue, 28 Mar 2023 10:10:45 -0400 Received: by mail-qt1-f172.google.com with SMTP id hf2so11982170qtb.3; Tue, 28 Mar 2023 07:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680012639; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=g4yGCBBGK/wjlUSZJbhXOcl46KKBl5wauDk4Mb/oYzk=; b=LgDmgJlNkr/h01aQ93BzicECmVfKU4GWxQ0FoCalGwEycLPamPpFw9172z3mttRuHs CYOmaZcZsje0xy7Pd/HhLJbH3FkQVCCFqAuDSq917Xci0Mbk9Bf8B8LgKgdoX+3cJg9s v8ZcksVtSpfI+ItlxbH5TRD/Fsm+QnBzJKN1sQL/63l+MYAh+AngLt+lrK1bzgRmBPOW tDwEaackmci6KWQ9X4v09K5ywf9HY/OmSQfqxPICobS6HKa4iFBrrQ1h4y6u7wMBReBS e3cW9Pz0tuE+LVNNokFK5wm5ZsF0c/pFpG3uNMBErTgPsvmhOYXmo++0vyU/1HK0Nowm evBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680012639; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=g4yGCBBGK/wjlUSZJbhXOcl46KKBl5wauDk4Mb/oYzk=; b=GNn5Fm4QUptBe417LRm+dhNRCsFmfaQgJALnBB28agX6hduKcXlmuEAvxE0E/VqwNL k2SZB2L8erwtcx054fmOi37Y0nzTUIDRcpDZ/LBy51cCxzV87AD1VQtAUvlRe3tpl8Fc 5iLFjwVZej9PxzzjoB9hbu/pF3j7qFThsrSCfCbbA2G8dHUdn2b7zc1PCtqyoR3S0ybi Q/uDp4f/ZleY0d0aMkTBp/LG3PEjZbuG5CpBTkf6ct13HeWUMIjCwbKghtbzI+LW8UA3 B4rxSvHgglOoaiNeIxKbwdaEcgQSH/0BdJ+RA5uHszo1b/0wsKIIoz2oXOn9rjSmHIgG 1bRA== X-Gm-Message-State: AO0yUKVK8NkXFX3T6RGCWLBfWe7jz3fFKp2rVsnAINAr93MOApCKez6K IiKq+/gSltHHDxA2sX2KpHVRmcSvwVM= X-Google-Smtp-Source: AK7set8rvDOJD/F+N+KeW4ss/afTpYCrKze9Scy82OR6ka1Z7la2a1JNiIDKCVcyqbWWszIindtNVg== X-Received: by 2002:ac8:5e0c:0:b0:3bf:c3be:758e with SMTP id h12-20020ac85e0c000000b003bfc3be758emr27752413qtx.16.1680012639172; Tue, 28 Mar 2023 07:10:39 -0700 (PDT) Received: from hurd (dsl-205-151-56-156.b2b2c.ca. [205.151.56.156]) by smtp.gmail.com with ESMTPSA id 11-20020a37030b000000b00745a55db5a3sm11966435qkd.24.2023.03.28.07.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 07:10:38 -0700 (PDT) From: Maxim Cournoyer References: <20230311190206.GD20567@beffara.org> <87sfe8n4ao.fsf@rohleder.de> <20230314222628.GE14391@beffara.org> <87v8ireiq9.fsf@gmail.com> <20230323155819.GC5268@beffara.org> <87edpe1gn5.fsf@gmail.com> <20230328143236.GD1964@beffara.org> Date: Tue, 28 Mar 2023 10:10:37 -0400 In-Reply-To: <20230328143236.GD1964@beffara.org> (Emmanuel Beffara's message of "Tue, 28 Mar 2023 14:32:36 +0200") Message-ID: <87v8ilnezm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680012698; a=rsa-sha256; cv=none; b=uPeW3W2jXrbjEjUdhNDgA+joTe/TE9qmq4GtuI6Znws6LIMOPKOqyyHp7iU62yo3B5c9Tx 6pEZvji//X3XgvZyfYseYjhOs+2XpeP7s2kqy4klPeSxsHB3gffnCNSGBLEEP6+wvLGtu3 RTuNyojSbUoj3lRNd7w3BBZg7P+LQtXJzsV6JFrzEarpH4k/DHYEVw+5cC9GIRSXkGyPFs GdXIA1I4vPVO5Jsa1HH9tZKOzTI2xOuNTKbT0HfkbcYenDLooZLpkdtvKjR32BiP+R0jeM dnurDRWF3GKbpVoXqiuK3wfWO1DV806UmY91AWqL57L9ZuNcJWs/8dghWg792Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LgDmgJlN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680012698; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=g4yGCBBGK/wjlUSZJbhXOcl46KKBl5wauDk4Mb/oYzk=; b=RISMHS5Wecd2BBuxxJlZvwugV2LfPlTa2JuaEJloUN+E1a6HaZCm3glZyOLus6woOqZZIc g5HKYVJd6EqZpHNQJYJRoxtMbt7u1RhX/oXNVQnyGw4SETFzRlqy28Lmpa81X54HK8tBc8 tu4jetaYQWt3wbhyQ79sAiPRuPEdhjoTVZxFHQ9y4PXT4olbBJ7nTKVV1yCsprQJtZbCUM ADhn5cGRpgkKd+FmVGfmJFTOfYbltJwzrWEkj1i0V/SXyrBTDD2TB/n/V95xk+eQxTdC0S RUHP+Vte+rPPhdCj9sSFT6I22WkLGX1mgHjKh3H0d1EMcV9q3w1fZW1kw7/sYg== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LgDmgJlN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.63 X-Spam-Score: -0.63 X-Migadu-Queue-Id: 880D288CE X-TUID: kUk+GtrwJgTW Hi, Emmanuel Beffara writes: > Hi, > > De Maxim Cournoyer le 24/03/2023 =C3=A0 13:24: >> OK, thanks for explaining. Could you please try >> https://issues.guix.gnu.org/60442 (by applying the patch to a local guix >> checkout, building it, then 'sudo -E ./pre-inst-env sudo guix system >> reconfigure /path/to/your/config.scm)? The test suite was broken it >> seems (it passed without the fix), but perhaps the fix still does work? > > I did as you suggested, and unfortunately the patch has no observable eff= ect > on my system. Thanks for testing it! > I can't say it comes as a surprise. Indeed, what the patch does is set the > environment variable `GRUB_PRELOAD_MODULES` before calling `grub-install`, > which is expected to have no effect: this variable is used by `grub-mkcon= fig` > to generate a `grub.cfg`, but the code in Guix assembles a Grub configura= tion > file itself and never calls `grub-mkconfig`. The same applies to the vari= able > `GRUB_ENABLE_CRYPTODISK`, by the way. Maybe the way `grub.cfg` is produce= d has > changed at some point in history ? I'm not sure, but I agree it's confusing to have extraneous setenv there if they serve no purpose (and my understanding is the same as yours: I don't see how that'd work). > The only hypothesis I can make is that it would influence `grub-install` = by > preloading the given modules in the installed image, but that is not the = case. > According to Grub's documentation, passing `--modules=3D...` to `grub-ins= tall` > would have this effect, but I'm not sure it is the right approach. Since we already generate a custom grub.cfg, the right approach is probably to add any needed directive directly to it. --=20 Thanks, Maxim