From: "Ludovic Courtès" <ludo@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
Christopher Baines <mail@cbaines.net>,
Simon Tournier <zimon.toutoune@gmail.com>,
Mathieu Othacehe <othacehe@gnu.org>,
Tobias Geerinckx-Rice <me@tobias.gr>,
64358@debbugs.gnu.org
Subject: bug#64358: [PATCH] refresh: Sort update specs by package location.
Date: Mon, 10 Jul 2023 23:49:55 +0200 [thread overview]
Message-ID: <87v8er5tdo.fsf@gnu.org> (raw)
In-Reply-To: <74997f913e60491d74afcea38a13e5edb0c71b09.1689014499.git.rekado@elephly.net> (Ricardo Wurmus's message of "Mon, 10 Jul 2023 20:41:41 +0200")
Hi,
Ricardo Wurmus <rekado@elephly.net> skribis:
> Fixes <https://issues.guix.gnu.org/64358>.
>
> * guix/scripts/refresh.scm (guix-refresh): Sort update specs by location from
> bottom to top before updating packages.
[…]
> + (let* ((get-line
> + (compose location-line
> + package-location
> + update-spec-package))
Maybe s/get-line/spec-line/ ?
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2023-07-10 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 21:26 bug#64358: “guix refresh” chokes on cran.scm Ricardo Wurmus
[not found] ` <handler.64358.B.168807427428659.ack@debbugs.gnu.org>
2023-07-03 19:29 ` Ricardo Wurmus
2023-07-07 13:42 ` Ludovic Courtès
2023-07-07 20:13 ` Ricardo Wurmus
2023-07-10 18:41 ` bug#64358: [PATCH] refresh: Sort update specs by package location Ricardo Wurmus
2023-07-10 21:49 ` Ludovic Courtès [this message]
2023-07-10 22:17 ` Ricardo Wurmus
2023-07-14 13:19 ` Ludovic Courtès
2023-07-12 12:35 ` bug#64358: “guix refresh” chokes on cran.scm Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8er5tdo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=64358@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=mail@cbaines.net \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).