From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KLJsLFKSHWUSrgAAG6o9tA:P1 (envelope-from ) for ; Wed, 04 Oct 2023 18:26:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KLJsLFKSHWUSrgAAG6o9tA (envelope-from ) for ; Wed, 04 Oct 2023 18:26:58 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 77F1C4202C for ; Wed, 4 Oct 2023 18:26:58 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="rdiC+m/P"; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696436818; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=SQoTH37yHJ8y7JD4mNWUny3u6dkGCVLnVbIdIzDq6QM=; b=dH8+VHOtrhijZLsdd2mVKfNwSHdqe5xPrMJzdtjVaGt8QE4qnxz1svs0fdo2PfMgkLS49h KUBmzkMzLLYZvceDQ0ixcKSoQaUbBE5fSgRvmu38cyKOpkRaSTKyF+PxeTKtco/gS4Kpej wdnVgV9Y2lFnPwniyTXvCBwCTaqbDQXuVnuBwo9YRAb78Y35R2jfKwCn4/GXxh+qMkxjBS 6mS7kvRrYPLhx+jsalNChPAcrvqXE57IP4uZ+MRjxH1ZYEUlrmYB7AULUKqwBbdftcRzdB rqsWRMetlPdWLmugFc+UwMhR2/WmAccvXVU8cIQNsISI+ljui+TEoZwKVur0vA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="rdiC+m/P"; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696436818; a=rsa-sha256; cv=none; b=akUBy30PxbG54DrHPUPHxPRipNSDkKo1PhY5GBlOwEFBsa4c9O8LXK73WT9JZvz+l5UlYp MWwxfY6vGBKp7xMvGvWgODJhuiHXNis4NPYCW5bnq3UMUyBEHTW2oxa8ChZSUaSSDVVxWS m0aU+PIvEVIwD2RJj6xVgUCzD/U4Si9vckRSOz/hblFfHyfoGn0c+6ouny2LfVE6fUzH91 P7crxXr5T1MgBku9Pwc7E8xCT/Ko0qWuqm2Bx4w15tEkf5noTRAICD0uNpD9d/gN2hX5x8 F0x8EzIfzSI/rxtMCUye6tnncd0zBvD6g3AftLRj7qbvlApU4S29UhCv37lDoA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qo4hx-0001mk-EV; Wed, 04 Oct 2023 12:26:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qo4hw-0001mH-Fj for bug-guix@gnu.org; Wed, 04 Oct 2023 12:26:44 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qo4hw-0006a9-6x for bug-guix@gnu.org; Wed, 04 Oct 2023 12:26:44 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qo4iD-000571-KG for bug-guix@gnu.org; Wed, 04 Oct 2023 12:27:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#66305: Error with recursive git checkout Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 04 Oct 2023 16:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66305 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon Tournier Cc: Guillaume Le Vaillant , 66305@debbugs.gnu.org Received: via spool by 66305-submit@debbugs.gnu.org id=B66305.169643679519615 (code B ref 66305); Wed, 04 Oct 2023 16:27:01 +0000 Received: (at 66305) by debbugs.gnu.org; 4 Oct 2023 16:26:35 +0000 Received: from localhost ([127.0.0.1]:45184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qo4hn-00056I-9T for submit@debbugs.gnu.org; Wed, 04 Oct 2023 12:26:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qo4hk-000562-Ii for 66305@debbugs.gnu.org; Wed, 04 Oct 2023 12:26:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qo4hM-0006V9-C7; Wed, 04 Oct 2023 12:26:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=SQoTH37yHJ8y7JD4mNWUny3u6dkGCVLnVbIdIzDq6QM=; b=rdiC+m/P4++tx7wq9ywY VgS1DnIfr+vp7oh39vZ63CrfkpINO7OOfbwx8AU/LM/gU6/sHt9A3OpywmsEaXbn2/t+WTx5DVGti 4pAy2//8IKO80D87MyHpZC637Gc1nAy4OTUVjzHA9KApT3+NllI6iWJdbC6raUC/PUqgcDr9oCWPc AD1e2LhSAV0/mqn9uTiF6/k9Gb56MGARFUXkmTNMF0/SoECjaDgcCqzoNprnqR2ZyR1+uI87KH0b+ YudJJDK08WZnPRRgClhNlha37dim4gc3k2IC5Q6ngNOsGn/ENKcVEl6ZW8ONbCAotsMkey5Sh1KZl 0aM32DL4x2xbIw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <877co34ide.fsf@gmail.com> (Simon Tournier's message of "Tue, 03 Oct 2023 21:26:53 +0200") References: <877co34ide.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 13 =?UTF-8?Q?Vend=C3=A9miaire?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Potiron X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 04 Oct 2023 18:25:56 +0200 Message-ID: <87v8bm9wx7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.89 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 77F1C4202C X-Spam-Score: -6.89 X-TUID: 1fMbKrKzb9PY --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Simon Tournier skribis: > On Mon, 02 Oct 2023 at 11:17, Guillaume Le Vaillant wrot= e: > >> With Guix at 47d0346553fdad9795c9390a60944ccaad7e5255, I'm unable to >> build a package (see attached patch) requiring a recursive git-fetch to >> get the sources: > > [...] > >> HEAD is now at 41ef634 Revert "libbladeRF: update compatibility for FPGA= v0.15.0 from libbladeRF 2.4.0 to 2.5.0" >> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/g= it-core/git-submodule: line 7: basename: command not found >> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/g= it-core/git-submodule: line 7: sed: command not found >> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/g= it-core/git-sh-setup: line 77: basename: command not found >> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/g= it-core/git-sh-setup: line 77: sed: command not found >> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/g= it-core/git-sh-setup: line 292: uname: command not found >> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/g= it-core/git-submodule: line 613: sed: command not found >> /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/g= it-core/git-submodule: line 613: cmd_: command not found >> git-fetch: '/gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41= .0/bin/git submodule update --init --recursive' failed with exit code 127 > > It looks very similar as bug#65924: > > bug#65924: git searches coreutils and util-linux commands in PATH > Maxim Cournoyer D=E2=80=99oh! Thanks Simon and Guillaume for the heads-up (I had totally overlooked that you raised this during the review, Simon; my bad). Here=E2=80=99s a patch that fixes it for me: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/scripts/perform-download.scm b/guix/scripts/perform-download.scm index 045dd84ad6..c869f19502 100644 --- a/guix/scripts/perform-download.scm +++ b/guix/scripts/perform-download.scm @@ -108,6 +108,10 @@ (define* (perform-git-download drv output (drv-output (assoc-ref (derivation-outputs drv) "out")) (algo (derivation-output-hash-algo drv-output)) (hash (derivation-output-hash drv-output))) + ;; Commands such as 'git submodule' expect Coreutils and sed (among + ;; others) to be in $PATH. + (setenv "PATH" "/run/current-system/profile/bin:/bin:/usr/bin") + (git-fetch-with-fallback url commit output #:recursive? recursive? #:git-command %git)))) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To test it, you need to run the daemon from your checkout, with something like: sudo herd stop guix-daemon sudo -E ./pre-inst-env guix-daemon --build-users-group=3Dguixbuild & (Once we=E2=80=99ve applied the fix, we=E2=80=99ll have to update the =E2= =80=98guix=E2=80=99 package.) I think we should eventually our =E2=80=98git=E2=80=99 package as discussed= in , but that won=E2=80=99t help on foreign distros anyway, hence the fix above. WDYT? Ludo=E2=80=99. --=-=-=--