From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bug-guix-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:403:4876::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms8.migadu.com with LMTPS
	id 6D/YBFtiU2XPGQAAauVa8A:P1
	(envelope-from <bug-guix-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 14 Nov 2023 13:04:43 +0100
Received: from aspmx1.migadu.com ([2001:41d0:403:4876::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id 6D/YBFtiU2XPGQAAauVa8A
	(envelope-from <bug-guix-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 14 Nov 2023 13:04:43 +0100
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id C443A217D5
	for <larch@yhetil.org>; Tue, 14 Nov 2023 13:04:42 +0100 (CET)
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=AwP+SsOP;
	dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none);
	spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1699963482;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=ylTF2Qwpjb3oXQkbeS9e3AnLlKkJ1OUyQRtwgU+E1+Q=;
	b=e3PpwXuRMEjg86h/StwAtRjSF6aX7s5MHZrR+m3ZNlUYV9/go7mGjQklDHc/QQ3dgVgtZr
	LDBWiygAu5iK4GOenKEyTnl9KJGS8O4RJFn5M2XCvVjCYK6yIbxWSU2Ed2JfAzcgDvcM2w
	WSxwVbfL6z/aKpmF3E8AD7mLO6NR+pBc0Ufm8ECvHsVxsRZ7jgk688Ajid0YTLMSeBtjm1
	2dWI34iaCcnEBlSOHjpEXchA1SJWWzINXeo8Zkp4R36ILj23mSRbPCWhgKABcm1YbR9Z2I
	dMk9laHfaFe4lUBwk4FK4hUzmS8DZUSHDW5KTcrm4f7yXfv6lVrtkkLopw18Tw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=AwP+SsOP;
	dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none);
	spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699963482; a=rsa-sha256; cv=none;
	b=MPK2Pg1jXePl5Kn8EWRvQUQ3CZ1q+KqxPzLYK0g0XLm9d0ve/mHDjZXvCyc0w5U4jQeSQv
	IInthc7e2lGUOM5cxL3BnpqRGhG/80ZooOLrLFFH+HYDL2XjG4z8J6tKEgJ3+XTaRaHX1J
	54qqS85Oryj3FaF6PEfsVQxbgrR8Lm4BgwIqn5BVVx41Ke6GqpwHYrChrBUVy7rQDM8e6u
	RsbVX+AKQcImCkulHQslsSPPgjML26JIbBuOBLK4dzTPoJEPcvt0GwhreDQh/7JaMdKPBO
	iGh57fNCmar/dQl1YYyrE0jyo0oUS2koEhrpMhoL/SkZuOUBL60BxJMxmrxiMg==
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-guix-bounces@gnu.org>)
	id 1r2s9V-0002Pq-Of; Tue, 14 Nov 2023 07:04:21 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r2s9U-0002P9-J8
 for bug-guix@gnu.org; Tue, 14 Nov 2023 07:04:20 -0500
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r2s9T-000248-Vr
 for bug-guix@gnu.org; Tue, 14 Nov 2023 07:04:20 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r2sA9-0005Ma-OP
 for bug-guix@gnu.org; Tue, 14 Nov 2023 07:05:01 -0500
X-Loop: help-debbugs@gnu.org
Subject: bug#65720: [bug#66650] [PATCH] git: Shell out to
 =?UTF-8?Q?=E2=80=98git_?= =?UTF-8?Q?gc=E2=80=99?= when necessary.
Resent-From: Simon Tournier <zimon.toutoune@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-guix@gnu.org
Resent-Date: Tue, 14 Nov 2023 12:05:01 +0000
Resent-Message-ID: <handler.65720.B65720.169996346620563@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 65720
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>,
 Christopher Baines <mail@cbaines.net>
Cc: Josselin Poiret <dev@jpoiret.xyz>, 65720@debbugs.gnu.org,
 66650@debbugs.gnu.org
Received: via spool by 65720-submit@debbugs.gnu.org id=B65720.169996346620563
 (code B ref 65720); Tue, 14 Nov 2023 12:05:01 +0000
Received: (at 65720) by debbugs.gnu.org; 14 Nov 2023 12:04:26 +0000
Received: from localhost ([127.0.0.1]:60188 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1r2s9a-0005LV-7C
 for submit@debbugs.gnu.org; Tue, 14 Nov 2023 07:04:26 -0500
Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:39148)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@gmail.com>)
 id 1r2s9X-0005Kr-ND; Tue, 14 Nov 2023 07:04:24 -0500
Received: by mail-wr1-x42c.google.com with SMTP id
 ffacd0b85a97d-32f831087c6so1028145f8f.0; 
 Tue, 14 Nov 2023 04:03:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699963416; x=1700568216; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
 :reply-to; bh=ylTF2Qwpjb3oXQkbeS9e3AnLlKkJ1OUyQRtwgU+E1+Q=;
 b=AwP+SsOPMQHvKYvI/o4aU2byBlVjQ/CaHhUssWI6cpQiahhd1zCpvl6U2/utawpQBx
 ZTZvA+Vk2sSqMnvz/OHFVRQsTUHRPNqJ0Iyf7sQVS7FbXNtxnL5f3zmXfSnqv8fw7uRO
 9S8lXYSKh66vvSv7jcDKKU4XqDUTUoms6CoyLcIx3xyXhCY2eZ3azAt8b9Y5EtTuLEUz
 A/zdHK2nJ5BWAxqjUccSJ5LQz3yvypZcd2bZ1pjHB/3Yf9cxz3PW7AdYrhdqIzlBtWTN
 iX3kqQ9rD8TgASpm7v/AZBgUPeOemaIPBgrEHVwTajcVa0ktjskYEx2SY0CAqPoWjSwc
 38iw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699963416; x=1700568216;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=ylTF2Qwpjb3oXQkbeS9e3AnLlKkJ1OUyQRtwgU+E1+Q=;
 b=lH24OIockUIOGanmqFgbxrGRc7zttqbK3ESKamxrsLW7PnpTCsdHXI0phtt6zvCLml
 8yBP7XfUHD4onbzgiItQW/c7qSXWqsVg4mYvFbVf+GNl5BYpADFPkhwsGx5AgC+L01Iy
 rCkmsMgmlVhHCZxn1EeZ5fyBNlP88KEXX9n84Na/mKgS/y29/dJeYMQQ+NOyRq1UbwHR
 inOwBbax1uVPo/df/xqlNEXppNOm2756cw9ZyG+0fvYL6ixJEkhHZBINOuEHdJC88ZBp
 UO5PPoi8tLHIOxQLUtDpdf6MjbJlb5yWVCH+/JGyTytulOszcRIm6qUqQVwQmotqrNTK
 dS8w==
X-Gm-Message-State: AOJu0YxmDycvu0Kzn756BoKs/IPx6TdQsZTlu7/M2iYMK2IL5k9fZlHf
 sMvVouVj9jniSrUgVTcBwkM2c3I4ZV4=
X-Google-Smtp-Source: AGHT+IGxrX8kNQ98k5MVjas+2EFIinZ9YvkPaQ15MARAjwxnTfVMWW20wlN2YlpNmNhmPTWnsvkRBQ==
X-Received: by 2002:a5d:648c:0:b0:331:3cec:214f with SMTP id
 o12-20020a5d648c000000b003313cec214fmr1209144wri.7.1699963415483; 
 Tue, 14 Nov 2023 04:03:35 -0800 (PST)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
 u30-20020adfa19e000000b00318147fd2d3sm7718993wru.41.2023.11.14.04.03.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 14 Nov 2023 04:03:35 -0800 (PST)
From: Simon Tournier <zimon.toutoune@gmail.com>
In-Reply-To: <87o7fwae0q.fsf@gnu.org>
References: <87jzswsrlt.fsf@gnu.org>
 <f588bb38b4b9fdaff29dd8af8c62aa3c55902f7c.1697818202.git.ludo@gnu.org>
 <87sf5swc3j.fsf@cbaines.net> <87o7fwae0q.fsf@gnu.org>
Date: Tue, 14 Nov 2023 10:32:41 +0100
Message-ID: <87v8a4el3a.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-guix@gnu.org
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org
Sender: bug-guix-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
X-Migadu-Spam-Score: 2.91
X-Spam-Score: 2.91
X-Migadu-Queue-Id: C443A217D5
X-Migadu-Scanner: mx10.migadu.com
X-TUID: O9RYwuCnbtpH

Hi,

On Tue, 14 Nov 2023 at 10:19, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:

> Any other comments?  I=E2=80=99d like to push the patch within a few days=
 if
> there are no objections.

As mentioned in [1],

>> * guix/git.scm (packs-in-git-repository, maybe-run-git-gc): New
>> procedures.
>> (update-cached-checkout): Use it.
>> ---
>>  guix/git.scm | 39 ++++++++++++++++++++++++++++++++++++---
>>  1 file changed, 36 insertions(+), 3 deletions(-)

LGTM.  Just two colors for the bikeshed. :-)


>> +  (when (> (packs-in-git-repository directory) 25)

Why 25?  And not 10 or 50 or 100?


>>  (define* (update-cached-checkout url
>>                                   #:key
>>                                   (ref '())
>> @@ -515,6 +545,9 @@ (define* (update-cached-checkout url
>>                     seconds seconds
>>                     nanoseconds nanoseconds))))
>>=20=20
>> +       ;; Run 'git gc' if needed.
>> +       (maybe-run-git-gc cache-directory)

Why not trigger it by =E2=80=9Cguix gc=E2=80=9D?

Well, I expect =E2=80=9Cguix gc=E2=80=9D to take some time and I choose whe=
n.  However,
I want =E2=80=9Cguix pull=E2=80=9D or =E2=80=9Cguix time-machine=E2=80=9D t=
o be as fast as possible and
here some extra time is added, and I cannot control exactly when.


Cheers,
simon


1: bug#65720: [PATCH] git: Shell out to =E2=80=98git gc=E2=80=99 when neces=
sary.
Simon Tournier <zimon.toutoune@gmail.com>
Mon, 23 Oct 2023 12:08:07 +0200
id:87il6xlkhk.fsf@gmail.com
https://issues.guix.gnu.org/65720
https://issues.guix.gnu.org/msgid/87il6xlkhk.fsf@gmail.com
https://yhetil.org/guix/87il6xlkhk.fsf@gmail.com