From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#22650: guixSD default umask is 0000
Date: Tue, 08 Mar 2016 23:33:49 +0100
Message-ID: <87twkgfvle.fsf@gnu.org>
References: <874mdcoex8.fsf@gmail.com> <878u2dr6u4.fsf@gnu.org>
	<87k2lw67cb.fsf@gmail.com> <8760xef73w.fsf@gnu.org>
	<87egbmtra3.fsf@gnu.org>
	<5395DF11-541F-40A8-A704-26E2FF6D0654@openmailbox.org>
	<87k2lekjrc.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43028)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adQDa-0006yU-IS
	for bug-guix@gnu.org; Tue, 08 Mar 2016 17:35:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adQDW-00012I-EH
	for bug-guix@gnu.org; Tue, 08 Mar 2016 17:35:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:43089)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adQDW-000126-C3
	for bug-guix@gnu.org; Tue, 08 Mar 2016 17:35:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adQDW-00056t-7O
	for bug-guix@gnu.org; Tue, 08 Mar 2016 17:35:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.22650.D22650.145747644819545.done@debbugs.gnu.org>
In-Reply-To: <87k2lekjrc.fsf@gmail.com> (Alex Kost's message of "Tue, 08 Mar
	2016 01:25:59 +0300")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@openmailbox.org>, iyzsong@member.fsf.org, 22650-done@debbugs.gnu.org

Alex Kost <alezost@gmail.com> skribis:

> =E5=AE=8B=E6=96=87=E6=AD=A6 (2016-03-07 18:18 +0300) wrote:
>
>> =E4=BA=8E 2016=E5=B9=B43=E6=9C=887=E6=97=A5 GMT+08:00=E4=B8=8B=E5=8D=888=
:18:44, ludo@gnu.org =E5=86=99=E5=88=B0:
>>
>>     ludo@gnu.org (Ludovic Court=C3=A8s) skribis:
>>
>>          myglc2 <myglc2@gmail.com> skribis:
>>
>>              glc@g1 ~$ ssh glc4@g1
>>              glc4@g1's password:
>>              glc4@g1 ~$ umask
>>              0000
>>
>>          Oh indeed, I can reproduce it.
>>
>>          The problem is that lshd resets the umask when it starts (in
>>          src/daemon.c:daemon_init) but never changes it again.
>>
>>          Perhaps we should be using pam_umask and login.defs (although I=
=E2=80=99m unsure
>>          if lshd would honor it), or alternately add explicitly set the =
umask in
>>          /etc/profile.
>>
>>          Thoughts?
>>
>>     =E5=AE=8B=E6=96=87=E6=AD=A6 & Alex: WDYT?  (Asking you since I know =
you=E2=80=99re already familiar
>>     with these things.  :-))
>>
>>     Ludo=E2=80=99.
>>
>>
>> I never pay attention to umask, but set it in /etc/profile seem the
>> right thing to me. IIRC, debian and exherbo set it in there too.
>
> I agree ("ArchLinux" also has "umask 022" in /etc/profile).

Done in 112024826d3283284654475a50ccef81c697e2c9.

Thanks for your feedback,
Ludo=E2=80=99.