From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: bug#29337: Bash reads system-wide bashrc unconditionally.
Date: Mon, 11 Dec 2017 12:35:22 +0100
Message-ID: <87tvwxqyzf.fsf@gnu.org>
References: <878tf5ksmq.fsf@gnu.org> <87o9o039cb.fsf@gnu.org>
	<87mv3gsjt6.fsf@gnu.org> <8760a4nhhi.fsf@gnu.org>
	<87fu93n0jr.fsf@gnu.org> <878tev9z8t.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57974)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOMNU-0000xX-Ni
	for bug-guix@gnu.org; Mon, 11 Dec 2017 06:36:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOMNO-0006Zc-To
	for bug-guix@gnu.org; Mon, 11 Dec 2017 06:36:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:47416)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eOMNO-0006ZS-Qk
	for bug-guix@gnu.org; Mon, 11 Dec 2017 06:36:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOMNO-0000DA-Iw
	for bug-guix@gnu.org; Mon, 11 Dec 2017 06:36:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.29337.D29337.1512992147785@debbugs.gnu.org>
In-reply-to: <878tev9z8t.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 29337-done@debbugs.gnu.org


Ludovic Courtès writes:

> Roel Janssen <roel@gnu.org> skribis:
>
>> Ludovic Courtès writes:
>>
>>> Heya,
>>>
>>> Roel Janssen <roel@gnu.org> skribis:
>>>
>>>> Roel Janssen <roel@gnu.org> skribis:
>>>>
>>>>>> On CentOS 7, the following happens (yes, I added the echo-statement to
>>>>>> /etc/bashrc on CentOS as well):
>>>>>> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
>>>>>> Goodbye, world
>>>>>>
>>>>>> On GuixSD:
>>>>>> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
>>>>>> Hello, world
>>>>>> Goodbye, world
>>>
>>>> Well it seems that it isn't ignored when it ought to be ignored -> when
>>>> specifying --init-file.  This is a difference between how Bash works on
>>>> CentOS 7, and how Bash works on Guix(SD).  I can't find a
>>>> user-configurable option to make it work the same as on CentOS 7.
>>>
>>> Now, we’re compiling Bash with "-DSYS_BASHRC='\"/etc/bashrc\"'".  I
>>> wonder if removing that flag solves the --init-file case.
>>
>> It does.  So, I have a custom bash package for my specific use-case.
>> I'm not sure how it affects other functionality, but I would like it if
>> we could make this change upstream at some point.
>
> Now’s the time to make that change in ‘core-updates’!
>
> I don’t think it breaks things on GuixSD because /etc/profile sources
> /etc/bashrc anyway.
>
> Thoughts?

I don't think it'll break things.  So I guess I'm too late for the
core-updates cycle.  Should I push this change to core-updates for the
next cycle?

Kind regards,
Roel Janssen