unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 35585@debbugs.gnu.org
Subject: bug#35585: GRUB does not work with USB keyboards when using keyboard-layout
Date: Tue, 07 May 2019 18:11:55 +0200	[thread overview]
Message-ID: <87tve62qic.fsf@gnu.org> (raw)
In-Reply-To: <20190505173544.f3tjaznsbniyqj5z@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Sun, 5 May 2019 19:35:44 +0200")

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:

> From c0c8167cf4f7ddd68567618effc665dd950c2f93 Mon Sep 17 00:00:00 2001
> From: Florian Pelz <pelzflorian@pelzflorian.de>
> Date: Sun, 5 May 2019 17:38:47 +0200
> Subject: [PATCH] bootloader: grub: Support USB keyboards when using a
>  keyboard-layout.
>
> With this USB keyboards are recognized again, the layout does not currently
> get used by GRUB though.
>
> * gnu/booloader/grub.scm (keyboard-layout-config): Add usb_keyboard terminal
> to terminal_input command.

Oh, interesting.  I guess on “PCs” the BIOS/UEFI emulates AT keyboard
even when the keyboard is really an external USB keyboard, which is why
we don’t see that problem.

> --- a/gnu/bootloader/grub.scm
> +++ b/gnu/bootloader/grub.scm
> @@ -360,7 +360,7 @@ entries corresponding to old generations of the system."
>                               (keyboard-layout-file layout #:grub grub))))
>            (when keymap
>              (format port "\
> -terminal_input at_keyboard
> +terminal_input at_keyboard usb_keyboard

What do others think?  Danny?

I’d like to make sure this is as harmless as it looks.

Ludo’.

  reply	other threads:[~2019-05-07 16:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05 17:35 bug#35585: GRUB does not work with USB keyboards when using keyboard-layout pelzflorian (Florian Pelz)
2019-05-07 16:11 ` Ludovic Courtès [this message]
2019-05-07 16:39   ` Danny Milosavljevic
2019-05-07 22:09     ` pelzflorian (Florian Pelz)
2019-05-08 10:03     ` Ludovic Courtès
2019-05-08 12:23       ` pelzflorian (Florian Pelz)
2019-05-09 10:14         ` Ludovic Courtès
2019-05-09 12:52           ` Danny Milosavljevic
2019-05-13 13:59           ` Giovanni Biscuolo
2019-05-13 20:34             ` Ludovic Courtès
2019-05-07 17:25   ` pelzflorian (Florian Pelz)
2019-05-07 17:48     ` pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tve62qic.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=35585@debbugs.gnu.org \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).