From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UG/KNBLbU1/TJgAA0tVLHw (envelope-from ) for ; Sat, 05 Sep 2020 18:38:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YCihMBLbU1+2VwAAbx9fmQ (envelope-from ) for ; Sat, 05 Sep 2020 18:38:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 343D59404C2 for ; Sat, 5 Sep 2020 18:38:10 +0000 (UTC) Received: from localhost ([::1]:48056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEd4i-00041Q-1d for larch@yhetil.org; Sat, 05 Sep 2020 14:38:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEd4c-00041I-7O for bug-guix@gnu.org; Sat, 05 Sep 2020 14:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEd4b-0007FG-SL for bug-guix@gnu.org; Sat, 05 Sep 2020 14:38:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEd4b-0000aR-Op for bug-guix@gnu.org; Sat, 05 Sep 2020 14:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43228: r-v8 doesn't build since node 10.22 update Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 05 Sep 2020 18:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43228 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Pierre Langlois , 43228@debbugs.gnu.org Received: via spool by 43228-submit@debbugs.gnu.org id=B43228.15993310352203 (code B ref 43228); Sat, 05 Sep 2020 18:38:01 +0000 Received: (at 43228) by debbugs.gnu.org; 5 Sep 2020 18:37:15 +0000 Received: from localhost ([127.0.0.1]:44057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEd3q-0000ZS-ST for submit@debbugs.gnu.org; Sat, 05 Sep 2020 14:37:15 -0400 Received: from world.peace.net ([64.112.178.59]:59420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEd3p-0000ZD-5O for 43228@debbugs.gnu.org; Sat, 05 Sep 2020 14:37:13 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEd3i-00022w-BU; Sat, 05 Sep 2020 14:37:06 -0400 From: Mark H Weaver In-Reply-To: <87sgbwi0dn.fsf@gmx.com> References: <87sgbwi0dn.fsf@gmx.com> Date: Sat, 05 Sep 2020 14:35:52 -0400 Message-ID: <87tuwcqdek.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 593bef0/2s2U Hi Pierre, I'm quoting your message out of order to ease my reply. Pierre Langlois writes: > I'm afraid I broke r-v8 and a few of its dependants by updating node, > sorry about that! [...] > I'm not sure how to fix this, I'm happy to revert the node update if > needed, let me know! Then we'd have to wait for the next core-updates > cycle so that we no longer graft nghttp2. We will actually need node-10.22 (or at least 10.21) in 'master' in just over 2 weeks, when we'll be compelled to update IceCat to version 78. On Sept 22, Mozilla is scheduled to release a new batch of security fixes in 78.3, and there will be no corresponding 68.x release. (In fact, I had an *identical* commit on my private branch to update 'node' to 10.22, to allow testing IceCat 78 WIP.) However, if needed, I suppose it might be sufficient for my purposes to leave 'node' at 10.19.0, and to bind a separate 'node-10.22' variable to the new version. > AFAIK, the new node uses a function from nghttp2 1.41 that's not > present in 1.40, `nghttp2_option_set_max_settings'. However, since curl > depends on nghttp2 we've grafted 1.40 -> 1.41 to avoid a full rebuild. > > Looking at r-v8's log [0], it complains that the symbol is missing, > indicating it's trying to link with the old version 1.40. I /believe/ > it's inherited it through r-curl. If grafting is working as it should, then nghttp2-1.40 should never be linked at runtime. However, it is certainly the case that most things (except node-10.22) are *built* against nghttp2-1.40, where the aforementioned symbol is missing. One possible solution might be to update the replacement (graft) for _curl_ so that it's *built* against nghttp2-1.41. Something like this (untested): --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 55b7e4393b..bfcb52b678 100644 --- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -183,6 +183,9 @@ tunneling, and so on.") (sha256 (base32 "0wlppmx9iry8slh4pqcxj7lwc6fqwnlhh9ri2pcym2rx76a8gwfd")))) + (inputs + `(("nghttp2" ,nghttp2-1.41 "lib") + ,@(alist-delete "nghttp2" (package-inputs curl)))) (arguments (substitute-keyword-arguments (package-arguments curl) ((#:phases phases) --8<---------------cut here---------------end--------------->8--- Would you like to try this and see if it solves the problem? Mark