From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6HbSAKZhVV+ePwAA0tVLHw (envelope-from ) for ; Sun, 06 Sep 2020 22:24:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SJQ2OKVhVV8QCgAAbx9fmQ (envelope-from ) for ; Sun, 06 Sep 2020 22:24:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8EDA9402A2 for ; Sun, 6 Sep 2020 22:24:36 +0000 (UTC) Received: from localhost ([::1]:51452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kF35P-0001Ju-Ec for larch@yhetil.org; Sun, 06 Sep 2020 18:24:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kF34s-0001Eb-EP for bug-guix@gnu.org; Sun, 06 Sep 2020 18:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35811) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kF34s-0002VJ-4S for bug-guix@gnu.org; Sun, 06 Sep 2020 18:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kF34r-0004YJ-W9 for bug-guix@gnu.org; Sun, 06 Sep 2020 18:24:01 -0400 Subject: bug#43228: r-v8 doesn't build since node 10.22 update Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Sun, 06 Sep 2020 22:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43228 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Mail-Followup-To: 43228@debbugs.gnu.org, pierre.langlois@gmx.com, pierre.langlois@gmx.com Received: via spool by 43228-done@debbugs.gnu.org id=D43228.159943101917466 (code D ref 43228); Sun, 06 Sep 2020 22:24:01 +0000 Received: (at 43228-done) by debbugs.gnu.org; 6 Sep 2020 22:23:39 +0000 Received: from localhost ([127.0.0.1]:47355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF34V-0004Xc-GA for submit@debbugs.gnu.org; Sun, 06 Sep 2020 18:23:39 -0400 Received: from mout.gmx.net ([212.227.17.22]:34557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF34T-0004XP-N1 for 43228-done@debbugs.gnu.org; Sun, 06 Sep 2020 18:23:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599431011; bh=KZIQRa7wQL1kCNeVAyS7WbTDL9InJCz/BgqJM9Lk5gk=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=IG291RdQqnvPBrMQ64eygGuxRgGC7oNbWNjwzg3Uv8xbwT3RwHkw2v6y6WdH+xv/U ASvh8p/BTHHfhNqJo+brQTDuygPeQTa4Bhljd6E9fdW+Z9nDWmfl/RPLM9Bfhfd0xZ YEzEOANX2zQ0quT95dBAeQh9Jgr4dXdQA6FdzbsA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MCKBm-1kOMj30OeI-009Na1; Mon, 07 Sep 2020 00:23:31 +0200 References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> <87blikhvj2.fsf@gmx.com> <87o8mjrf3u.fsf@netris.org> <87pn6z5f4j.fsf@gmx.com> <878sdmr8sh.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <878sdmr8sh.fsf@netris.org> Date: Sun, 06 Sep 2020 23:23:35 +0100 Message-ID: <87tuwalf2w.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:AUoEz6wCOv+VfToFr9Nvq+tj1iEOqjoQPAUcQ/yr2Zc/IZuceLk UmCh0tYXp7jGzTgmmZkLUmKY4XcZTjkgZkEPnIG/GCrQMpvioe5XnguaFZJrcFjBQP4KmIn ge7YnH4cMET+tbYu9BoJtz4qiv2g7MxcUIFIacFmY9pEQaM5Y5l/wO81dXnA/qHHCjylZ7f g3H1dYXW19dQht09HgvwQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:NnbrJkh5weE=:0UiBshS7mMoOvghT+6yZdz EBIdLpzrH8tNpg66NGrJ3fN6ccyYrOPQ2ttcBUSKjJgspmzhEeq3SsteoRLFAT2GgxERGDO88 J4CG6y5mEx5b5GwClTvW8+XMmrPeO3/w4sIZ6rd9ICnm+uA1n9IPuy4TutKJgVic01KVPwetY fZA0mfv3hbmcnJjvyKpykDF9bfOwwyx0Vb1y5Mb5lAx4CdzIyh4pakaVMuJdWc5Ba3aYFHsY8 7Xl+ZPtrhDXAtGHZuVSefp9YN5Ib4YWzNymwp4QqeW3dMsUf/M70SWeD4RM5Jb2KbKkwayAQD VCVSq2Pd+QIh1vYxDLs3gr6FDpWWfLbo5OUXYmEIMmkvmlzb8uWTjJddPXFKfEKSGwxRVHsqj egI0TnNRn91obBMxLTDcDWby+h+H5H7x0pW4oMNu5bRljF3n3l1AU4FbDvROznw68MYInztye yOcoMHNQ+B0aqoXyQa4HEP7aLyYkgJJbmDaKilmRC1kJ8BIqo9lvgzcV47KVqe45Ek5RSrKpK q+DJoVTyclVFT1f4dBKCTk4Ypglj85BTEe8XiGTsgSflMWE1Ah8X1MEJ05Q5JLUdQlT0E2Uhq chTP/1oZy6x2dkvmDaVtnmFE+LhSNUnjzWjyqGcZB5bfolj5Wmf7ZOYHL4mMsLOXSLf0/pswK LTarLdj0aNge4Oc5DPTZy5ADsOIfVdfkTOjfJOf4ZbDzPqOmUOm8iI1zLvJIAJcycsrA/1Qy0 EN7m2yHZkJc+f5CjMxV/UwFbaw6jZH/5Lxjf/f6vibVZ4dgSKEog3vENytwlpDS/16uRWWwPz jALIyg/n5BWkI5h74hAzBMzXKxRvFOFaaqHekLL1GI6GZgIWpXNcVvj8ft/ryzeR5dLkwKY5n 76f+EYgrQQMZmjrU9hzsVoRKjRcPZZ/QpXnyZnP/WJW23I6AJ4cJCI5dSqRB65QcKRFjkjhda f6WRs5MsSW2ij12sDWS4UmU+sIAi8YcNhSfqSXiCFkRmegDLsnXczc/sWtyZ9nOIRmplwWOf3 FU94rE8JxMGGypW4DNUJVfW2yqRruHNFZHMPlaF0cjkxHYpD/VMOGnZVm9opB2E5dZMD8mpCE oheu6k/dTaF2FDENM+LTtctxpCN6lbziIFPqrS4biftrUbjdbg64Cy6lij1nOZrnubj+ODYcv OoHs+xpH9wsjrXxqnXfBdf2s2iVIXjcVpMkockMCm3Qn9XdF/8caHrvdKpDFX3Hea6IVc9G5N NAUcdfhfrckVuM6XGNMiqyUHAV4eq03LA38+t7w== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43228-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmx.net header.s=badeba3b8450 header.b=IG291RdQ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -2.11 X-TUID: R514KjsWeeE9 --=-=-= Content-Type: text/plain Hi Mark, Mark H Weaver writes: > Hi Pierre, > > Your new patch looks good to me, but the node-10.22 source field could > be simplified to avoid repeating the unchanged field (especially the > snippet), by inheriting from (package-source node) like this: > > --8<---------------cut here---------------start------------->8--- > (source (origin > (inherit (package-source node)) > (uri (string-append "https://nodejs.org/dist/v" version > "/node-v" version ".tar.xz")) > (sha256 > (base32 > "1nz18fa550li10r0kzsm28c2rvvq61nq8bqdygip0rmvbi2paxg0")))) > --8<---------------cut here---------------end--------------->8--- Oh yeah, that's much better. > > Also, it would be great to find a way to fit in the subject line that > 10.22 is also being kept as a separate binding, especially since "guix > build node" and most other user commands will still build 10.22. Maybe > something like this: > > gnu: node: Downgrade to 10.20.0; add separate 'node-10.22' binding. > > What do you think? Actually, even better, I can split this into two separate commits. > > Anyway, feel free to push this, preferably after incorporating these > suggestions. If I'm not mistaken, the simplification suggested above > should not change the .drv file, and therefore not entail a rebuild, so > testing it should be very quick. Pushed as 6b7cba0fa897e97b43e76612e3736429426f4d9d and 92db0d39e2aa64be390e86172bd670d98e121c4b, thanks for the review! Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9VYWgYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UIA0H/RBdW+hGtQOhwS8jipG9nCyV b8TPnQWapBCq22lYG0PI51VzlflFWgyJznFLpu2aXK4If2H4BSiywYwTjQJanLiB LAfe2FpvdpqcHgT1Hs/DNPl0gi1zMfEw9Bal1MjULYoVIerUxP0iwCiVr/3wHVgk nkQ6KgQzLy87FhvROm8j3gc8UYgWblAzMHnesXVz4hMvS0MAQdKcMjad+MC8/6mD LoAi3O7CPNuYLk1xT/h0M8AuGM/zaCUd8eQ6wOtdtnImzRPNWjPy36Km+okY/19C hXAyvIgHWcuP2Z2vuGwTjA21C/PtU8UzLxF1ihK3DkEnC0ZXIAHbYyR0DMlQQBU= =HYSC -----END PGP SIGNATURE----- --=-=-=--