From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 55139-done@debbugs.gnu.org
Subject: bug#55139: package-location is wrong for transformed packages
Date: Wed, 08 Jun 2022 17:29:08 -0400 [thread overview]
Message-ID: <87tu8uj13v.fsf@gmail.com> (raw)
In-Reply-To: <87czg47505.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 23 May 2022 15:28:10 +0200")
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Yeah, I ended up with this [0]:
>>
>> (define (locate-package-via-git name)
>> "Return the location object corresponding to package NAME, searched via git."
>> (let* ((input-pipe (open-pipe* OPEN_READ
>> "git" "grep" "-n" "--column"
>> (format #f "^(define-public ~a$" name)))
>> (output (get-string-all input-pipe)) ;file:line:column:match
>> (exit-val (status:exit-val (close-pipe input-pipe))))
>> (case exit-val
>> ((0)
>> (let ((components (string-split output #\:)))
>> (location
>> (first components) ;file
>> (string->number (second components)) ;1-indexed line
>> ;; FIXME: Comment discrepancy in (guix diagnostics), which
>> ;; says the column is 0-indexed.
>> (and=> (string->number (third components)) 1-)))) ;0-indexed column
>> ((1) #f) ;no match
>> (else (error "git grep failed with status" exit-val)))))
>>
>> and it does feel silly to have to shell out to git, but it did the job.
>>
>> Thanks,
>>
>> Maxim
>>
>> [0] https://notabug.org/apteryx/guix-api-examples/src/master/purge-python2-packages.scm#L42
>
> Nice, it’s good to have these examples—and hopefully we’ll soon be able
> to remove a whole bunch of ‘python2-’ packages!
>
> As for ‘package-definition-location’, I don’t think we can reasonably do
> any better, so I’m tempted to close the bug.
OK; thanks for your input.
At least it'll be recorded somewhere for the next person stumbling on
this behavior to discover.
Maxim
prev parent reply other threads:[~2022-06-08 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 1:48 bug#55139: package-location is wrong for transformed packages Maxim Cournoyer
2022-04-27 12:23 ` Liliana Marie Prikler
2022-05-02 20:57 ` Ludovic Courtès
2022-05-22 5:16 ` Maxim Cournoyer
2022-05-23 13:28 ` Ludovic Courtès
2022-06-08 21:29 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu8uj13v.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=55139-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).