unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#51639: The home-environment example on Guix manual has an error
@ 2021-11-06 12:50 Luis Henrique Gomes Higino
  2022-06-10  7:16 ` Andrew Tropin
  0 siblings, 1 reply; 3+ messages in thread
From: Luis Henrique Gomes Higino @ 2021-11-06 12:50 UTC (permalink / raw)
  To: 51639


Hi,

the example present in the 11.1 section of the guix manual ((guix)
Declaring the Home Environment) uses a list of strings in the
bash-profile field of home-bash-configuration, which is incorrect, 
as it
expects a list of file-like objects.

The example is as follows:

  (use-modules (gnu home)
               (gnu home services)
               (gnu home services shells)
               (gnu services)
               (gnu packages admin)
               (guix gexp))
  
  
  (home-environment
   (packages (list htop))
   (services
    (list
     (service home-bash-service-type
              (home-bash-configuration
               (guix-defaults? #t)
               (bash-profile '("\
  export HISTFILE=$XDG_CACHE_HOME/.bash_history"))))
  
     (simple-service 'test-config
                     home-files-service-type
                     (list `("config/test.conf"
                             ,(plain-file "tmp-file.txt"
                                          "the content of 
                                          ~/.config/test.conf")))))))

Running "guix home build" with a file containing this returns this 
error:

  building 
  /gnu/store/cvmpzmvb0p73dvbf813rcmpplj6fnbk8-bash_profile.drv...
  Backtrace:
             8 (primitive-load 
             "/gnu/store/w6nikzvdk66d1b8x579ra0vz0wl?")
  In ice-9/ports.scm:
     463:17  7 (call-with-output-file _ _ #:binary _ #:encoding _)
  In ice-9/eval.scm:
      159:9  6 (_ #(#(#<directory (guile-user) 7ffff3bb3f00>) 
      #<outp?>))
      163:9  5 (_ #(#(#<directory (guile-user) 7ffff3bb3f00>) 
      #<outp?>))
      155:9  4 (_ #(#(#<directory (guile-user) 7ffff3bb3f00>) 
      #<outp?>))
      159:9  3 (_ #(#(#<directory (guile-user) 7ffff3bb3f00>) 
      #<outp?>))
  In ice-9/boot-9.scm:
      152:2  2 (with-fluid* _ _ _)
  In ice-9/ports.scm:
     440:11  1 (call-with-input-file "     export 
     HISTFILE=$XDG_CACHE?" ?)
  In unknown file:
             0 (open-file "     export 
             HISTFILE=$XDG_CACHE_HOME/.bash?" ?)
  
  ERROR: In procedure open-file:
  In procedure open-file: No such file or directory: "     export 
  HISTFILE=$XDG_CACHE_HOME/.bash_history"
  builder for 
  `/gnu/store/cvmpzmvb0p73dvbf813rcmpplj6fnbk8-bash_profile.drv' 
  failed with exit code 1

I believe it should be changed to something like this:

  (use-modules (gnu home)
               (gnu home services)
               (gnu home services shells)
               (gnu services)
               (gnu packages admin)
               (guix gexp))
  
  
  (home-environment
   (packages (list htop))
   (services
    (list
     (service home-bash-service-type
              (home-bash-configuration
               (guix-defaults? #t)
               (bash-profile (list (plain-file "bash-profile" "\
  export HISTFILE=$XDG_CACHE_HOME/.bash_history")))))
  
     (simple-service 'test-config
                     home-files-service-type
                     (list `("config/test.conf"
                             ,(plain-file "tmp-file.txt"
                                          "the content of 
                                          ~/.config/test.conf")))))))

This manages to build correctly.

Greetings,
Luis

-- 
Luis H. Higino




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#51639: The home-environment example on Guix manual has an error
  2021-11-06 12:50 bug#51639: The home-environment example on Guix manual has an error Luis Henrique Gomes Higino
@ 2022-06-10  7:16 ` Andrew Tropin
  2022-06-10  9:24   ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Tropin @ 2022-06-10  7:16 UTC (permalink / raw)
  To: Luis Henrique Gomes Higino, 51639; +Cc: Oleg Pykhalov, Ludovic Courtès


[-- Attachment #1.1: Type: text/plain, Size: 3592 bytes --]

On 2021-11-06 09:50, Luis Henrique Gomes Higino wrote:

> Hi,
>
> the example present in the 11.1 section of the guix manual ((guix)
> Declaring the Home Environment) uses a list of strings in the
> bash-profile field of home-bash-configuration, which is incorrect, 
> as it
> expects a list of file-like objects.
>
> The example is as follows:
>
>   (use-modules (gnu home)
>                (gnu home services)
>                (gnu home services shells)
>                (gnu services)
>                (gnu packages admin)
>                (guix gexp))
>   
>   
>   (home-environment
>    (packages (list htop))
>    (services
>     (list
>      (service home-bash-service-type
>               (home-bash-configuration
>                (guix-defaults? #t)
>                (bash-profile '("\
>   export HISTFILE=$XDG_CACHE_HOME/.bash_history"))))
>   
>      (simple-service 'test-config
>                      home-files-service-type
>                      (list `("config/test.conf"
>                              ,(plain-file "tmp-file.txt"
>                                           "the content of 
>                                           ~/.config/test.conf")))))))
>
> Running "guix home build" with a file containing this returns this 
> error:
>
>   building 
>   /gnu/store/cvmpzmvb0p73dvbf813rcmpplj6fnbk8-bash_profile.drv...
>   Backtrace:
>              8 (primitive-load 
>              "/gnu/store/w6nikzvdk66d1b8x579ra0vz0wl?")
>   In ice-9/ports.scm:
>      463:17  7 (call-with-output-file _ _ #:binary _ #:encoding _)
>   In ice-9/eval.scm:
>       159:9  6 (_ #(#(#<directory (guile-user) 7ffff3bb3f00>) 
>       #<outp?>))
>       163:9  5 (_ #(#(#<directory (guile-user) 7ffff3bb3f00>) 
>       #<outp?>))
>       155:9  4 (_ #(#(#<directory (guile-user) 7ffff3bb3f00>) 
>       #<outp?>))
>       159:9  3 (_ #(#(#<directory (guile-user) 7ffff3bb3f00>) 
>       #<outp?>))
>   In ice-9/boot-9.scm:
>       152:2  2 (with-fluid* _ _ _)
>   In ice-9/ports.scm:
>      440:11  1 (call-with-input-file "     export 
>      HISTFILE=$XDG_CACHE?" ?)
>   In unknown file:
>              0 (open-file "     export 
>              HISTFILE=$XDG_CACHE_HOME/.bash?" ?)
>   
>   ERROR: In procedure open-file:
>   In procedure open-file: No such file or directory: "     export 
>   HISTFILE=$XDG_CACHE_HOME/.bash_history"
>   builder for 
>   `/gnu/store/cvmpzmvb0p73dvbf813rcmpplj6fnbk8-bash_profile.drv' 
>   failed with exit code 1
>
> I believe it should be changed to something like this:
>
>   (use-modules (gnu home)
>                (gnu home services)
>                (gnu home services shells)
>                (gnu services)
>                (gnu packages admin)
>                (guix gexp))
>   
>   
>   (home-environment
>    (packages (list htop))
>    (services
>     (list
>      (service home-bash-service-type
>               (home-bash-configuration
>                (guix-defaults? #t)
>                (bash-profile (list (plain-file "bash-profile" "\
>   export HISTFILE=$XDG_CACHE_HOME/.bash_history")))))
>   
>      (simple-service 'test-config
>                      home-files-service-type
>                      (list `("config/test.conf"
>                              ,(plain-file "tmp-file.txt"
>                                           "the content of 
>                                           ~/.config/test.conf")))))))
>
> This manages to build correctly.
>
> Greetings,
> Luis

Hi, you are right!  Sorry for long reply.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-doc-Update-example-of-a-minimalistic-home-environmen.patch --]
[-- Type: text/x-patch, Size: 1496 bytes --]

From b1b448078a5382caf906c84064094f25aef7c689 Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Fri, 10 Jun 2022 10:08:24 +0300
Subject: [PATCH] doc: Update example of a minimalistic home environment.

* doc/he-config-bare-bones.scm: Adujst example according to changes in
bash-service-type and home-files-service-type.
---
 doc/he-config-bare-bones.scm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/doc/he-config-bare-bones.scm b/doc/he-config-bare-bones.scm
index d2e4736e29..f948d85277 100644
--- a/doc/he-config-bare-bones.scm
+++ b/doc/he-config-bare-bones.scm
@@ -13,12 +13,13 @@
    (service home-bash-service-type
             (home-bash-configuration
              (guix-defaults? #t)
-             (bash-profile '("\
-export HISTFILE=$XDG_CACHE_HOME/.bash_history"))))
+             (bash-profile (list (plain-file "bash-profile" "\
+export HISTFILE=$XDG_CACHE_HOME/.bash_history")))))
 
    (simple-service 'test-config
-                   home-files-service-type
-                   (list `("config/test.conf"
+                   home-xdg-configuration-files-service-type
+                   (list `("test.conf"
                            ,(plain-file "tmp-file.txt"
-                                        "the content of ~/.config/test.conf")))))))
+                                        "the content of
+                                          ~/.config/test.conf")))))))
 
-- 
2.36.1


[-- Attachment #1.3: Type: text/plain, Size: 37 bytes --]


-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#51639: The home-environment example on Guix manual has an error
  2022-06-10  7:16 ` Andrew Tropin
@ 2022-06-10  9:24   ` Ludovic Courtès
  0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2022-06-10  9:24 UTC (permalink / raw)
  To: Andrew Tropin; +Cc: Oleg Pykhalov, Luis Henrique Gomes Higino, 51639-done

Hi,

Andrew Tropin <andrew@trop.in> skribis:

> From b1b448078a5382caf906c84064094f25aef7c689 Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Fri, 10 Jun 2022 10:08:24 +0300
> Subject: [PATCH] doc: Update example of a minimalistic home environment.
>
> * doc/he-config-bare-bones.scm: Adujst example according to changes in
> bash-service-type and home-files-service-type.

Applied, thanks!

Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-10 10:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-06 12:50 bug#51639: The home-environment example on Guix manual has an error Luis Henrique Gomes Higino
2022-06-10  7:16 ` Andrew Tropin
2022-06-10  9:24   ` Ludovic Courtès

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).