From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AL3KIstAfmM0dQAAbAwnHQ (envelope-from ) for ; Wed, 23 Nov 2022 16:48:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GJ2lIstAfmOoUgAAauVa8A (envelope-from ) for ; Wed, 23 Nov 2022 16:48:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F71A21DB3 for ; Wed, 23 Nov 2022 16:48:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxryz-0006bZ-QN; Wed, 23 Nov 2022 10:48:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxrym-0006ZF-2c for bug-guix@gnu.org; Wed, 23 Nov 2022 10:48:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxryl-00056U-FJ for bug-guix@gnu.org; Wed, 23 Nov 2022 10:48:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxryk-0007gx-BT for bug-guix@gnu.org; Wed, 23 Nov 2022 10:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#59493: cuirass-remote-worker crash Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 23 Nov 2022 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59493 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 59493@debbugs.gnu.org Received: via spool by 59493-submit@debbugs.gnu.org id=B59493.166921846529463 (code B ref 59493); Wed, 23 Nov 2022 15:48:02 +0000 Received: (at 59493) by debbugs.gnu.org; 23 Nov 2022 15:47:45 +0000 Received: from localhost ([127.0.0.1]:55952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxryT-0007f8-5U for submit@debbugs.gnu.org; Wed, 23 Nov 2022 10:47:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxryO-0007eo-Ud for 59493@debbugs.gnu.org; Wed, 23 Nov 2022 10:47:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxryJ-00054R-HI for 59493@debbugs.gnu.org; Wed, 23 Nov 2022 10:47:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=N3dIj9WZwinlNrXiEoEd8l0WTZQZEiJXa9e+umeyHaE=; b=iEGTwTCncGLWrbqjR6aC HvfoPE9/lSjRA+WdUOy02T/zYBb4Phr9fgwSXRfEb6M5nVTvpWbsanZ1Z7QicYmf/vNW0dvcVQ2tF 2pJWiqBmhE7RsrrJLScKBo8yhoJfHnBDktE04AUAahPYqj4ef3q8QkbkieL49jzVvdnoDKYWIkWQD 7wr9DwgRDkKi1dt0i5zM3xE3SpmvHkW9NrEnbJEEbpifJVnOwf405a0/vrIcM1nfkijUfqlTXRTBB hVMETdXz6WDWYh4S16tqcEPJGRHAaVz/klsAZQYVJA56bSDIN7eTJc/5hH35gguRC4OIqTPOPJGlz 8Jv1vnX90jZZNQ==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxryI-0001WL-Kl; Wed, 23 Nov 2022 10:47:35 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87ilj6hc2a.fsf@inria.fr> <87h6yqw0sf.fsf@gnu.org> Date: Wed, 23 Nov 2022 16:47:32 +0100 In-Reply-To: <87h6yqw0sf.fsf@gnu.org> (Mathieu Othacehe's message of "Wed, 23 Nov 2022 09:08:32 +0100") Message-ID: <87tu2pfzaj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669218507; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=N3dIj9WZwinlNrXiEoEd8l0WTZQZEiJXa9e+umeyHaE=; b=KXCPvZ33UkBCCzRZm108JjoKZRRjieyy1Omusnvbc56o3VjVhV/VCKgZD+1Q53qHjmZsQz CnSjsfW7AwjPE/aS0sjQ6n6mLNMb4ZLPF0QFF0xjtiH+pOHLgMYyfv12GBLtxRhaZq0PH4 P1CHBI/hEP0VsFBIzlrrlWrkgqWnnsdJbRrpCPwBGZh1Jx3NpaVRIehrQ1tZDvgYoqjpCz 0tCHdf0a6eEtgxkvusYHSFXYjEwi5fC1cDIl+K5HF/RoJ4vwHkfaXUIouJrEgp0lFJY2qe us+PgfXCpr9NctG1tXfXux9O3qvYJWmo2WG+4yFeXtr16TpA5bETrrTdorK+tQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669218507; a=rsa-sha256; cv=none; b=jXVwlq+xRnmXjXSQabk/01MvvmBMPMrSN2YwNMYsIHEZMv8j6QhdInkyi3MswEBEBNJOyi NYmlbnPBRoTGZjqwXJvKjiv4SKD+qhcXM++wC+wg5YU++QFs0oc1AYC0jEbU2AneDOBTa5 nFs8Ev5alY2Cv2UcTnkiUkLB6MoA6FXFQen/pyxq5a1Wo8G/76ao6lPJMdJftYc3n23D1m t3jZG5oXsI2fMqoGmX9NxPj0GpFxcjMeV1ZIgFMctHWKHmae7bXKiWKRVw20NWU9pw9tLk abBTJDJ9KpJA+llMP+IWmqxJnVcpQaMmjq7TwTMHyX0Y75x6Ho37hmp+irhL7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iEGTwTCn; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iEGTwTCn; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3F71A21DB3 X-Spam-Score: -3.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: WyUD1lOtk/i9 Hi, Mathieu Othacehe skribis: >> 2022-11-21 14:27:24 1685:16 0 (raise-exception _ #:continuable? _) >> 2022-11-21 14:27:24 >> 2022-11-21 14:27:24 ice-9/boot-9.scm:1685:16: In procedure raise-excepti= on: >> 2022-11-21 14:27:24 Throw to key `match-error' with args `("match" "no m= atching pattern" (#vu8()))'. > > Yes this is because a new remote-server is running on Berlin and it > sends an empty sequence at every connection: > https://git.savannah.gnu.org/cgit/guix/guix-cuirass.git/commit/?id=3Dfc16= 41381d2a8a0472a71ef5ad2b64361faaaab4 Oh I see. It would be nice to avoid non-backward-compatible changes in the protocol so we can upgrade more smoothly. > All remote-workers must update, and I have deployed Cuirass > 1.1.0-13.1341725 on all hydra workers + guix9p. > > I have been trying to deploy that to overdrive1 for two days but Berlin > offloads the builds to kreuzberg which has some issues because a lot of > builds are timeouting: Done now! --8<---------------cut here---------------start------------->8--- ludo@overdrive1 ~$ guix system describe Generation 37 Nov 23 2022 15:58:08 (current) file name: /var/guix/profiles/system-37-link canonical file name: /gnu/store/62dr875n7i30l375j87flbqfym78kddg-system label: GNU with Linux-Libre 6.0.9 bootloader: grub-efi root device: /dev/sda3 kernel: /gnu/store/p4impcxw8lba8600acrxs21lgzc06xzq-linux-libre-6.0.9/Ima= ge channels: guix: repository URL: https://git.savannah.gnu.org/git/guix.git commit: 78f03567f44f704dfbc03cb64368aa42a01e78ad configuration file: /gnu/store/myvzd1kpw2pfzfj3krl4lzpcbqsdn48x-configura= tion.scm --8<---------------cut here---------------end--------------->8--- Running the Shepherd 0.9.3 and all, wonderful. >> (Stuttering is due to the unprotected use of =E2=80=98primitive-fork=E2= =80=99: a >> non-local exit in the child leads it to execute the same code as its >> parent. We should fix that, but should we really fork in the first >> place? :-)) Fixed in Cuirass commit 9fb6f21d29c5398b35f4c1a77cf6c20f207c9ebb. > Right, this is problematic. I can't remember why I chose to fork. One concern is that, in the Avahi case, we create at least one thread before forking, and as we know that doesn=E2=80=99t work (as in: it might w= ork sometimes). ZMQ may also create threads behind our back. The parent doesn=E2=80=99t call =E2=80=98waitpid=E2=80=99 on its children, = which isn=E2=80=99t great. To me, ideally this would be either multi-threaded or Fiberized. The latter would be more fruitful but what might be difficult is guile-simple-zmq integration with Fibers (but maybe not: zmq_getsockopt + ZMQ_FD lets us get the file descriptor of a socket). Something to consider=E2=80=A6 Thanks, Ludo=E2=80=99.