bug#66072: Duplicate/conflicting definitions for ocl-icd

bug#66072: Duplicate/conflicting definitions for ocl-icd

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

Hi.
There are currently two conflicting definitions of ocl-icd in
"opencl.scm":

--8<---------------cut here---------------start------------->8---
(define-public ocl-icd
  (deprecated-package "ocl-icd" opencl-icd-loader))
--8<---------------cut here---------------end--------------->8---

and

--8<---------------cut here---------------start------------->8---
(define-public ocl-icd
  (package
    (name "ocl-icd")
    (version "2.3.2")
    (source
     (origin
       (method git-fetch)
       (uri (git-reference
             (url "https://github.com/OCL-dev/ocl-icd")
             (commit (string-append "v" version))))
       (file-name (git-file-name name version))
       (sha256
        (base32 "0y0lnxb6zlhfb5vxxib5n1vvxa4b23qc0j3lsih6yjz9j37mj7wz"))))
    (build-system gnu-build-system)
    (native-inputs
     (list autoconf automake libtool ruby))
    (home-page "https://github.com/OCL-dev/ocl-icd")
    (synopsis "Generic OpenCL @acronym{ICD, Installable Client Driver} loader")
    (description
     "This package provides an OpenCL @acronym{ICD, Installable Client Driver}
loader.  It maintains a YAML database of all known and guessed function pointers
from vendor-specific drivers.  It also delivers a skeleton of bindings to
incorporate inside an OpenCL implementation to give it ICD functionalities.")
    (license license:bsd-2)))
--8<---------------cut here---------------end--------------->8---

Which is the good one?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#66072: Duplicate/conflicting definitions for ocl-icd

[Lars-Dominik Braun]

Hi,

> Which is the good one?

according to commit 4d1157fca7627c11672df0cd80fae4f4d27e2185 ocl-icd
was dead, which is why I replaced it. I cannot tell which one is better
though. Tobias maybe?

Lars

bug#66072: Duplicate/conflicting definitions for ocl-icd

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

Hi Lars, Guillaume,

Thanks for catching the duplicate!  I removed the ‘deprecated’ one in 
commit 71ec12d8bacd3901e8c7853d3c9403f3d09dfb31.

On 2023-09-18 16:23, Lars-Dominik Braun wrote:
>> Which is the good one?
> 
> according to commit 4d1157fca7627c11672df0cd80fae4f4d27e2185 ocl-icd
> was dead, which is why I replaced it.

It's not clear to me how opencl-icd-loader is related to ocl-icd, so I 
can't partake in that discussion.  They look like totally different 
packages to me.

My only motivation was to fix beignet, which was broken by the 
ocl-icd(.h) removal.

Kind regards,

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.

bug#66072: Duplicate/conflicting definitions for ocl-icd

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

As the duplicate has been removed, I'm closing the issue.
If one day we find a conflict between open-icd-loader and ocl-icd, we'll
open a new bug report.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]