From: "Ludovic Courtès" <ludo@gnu.org>
To: 67988@debbugs.gnu.org
Subject: bug#67988: [Cuirass] ‘request-work’ responses received by several workers
Date: Fri, 31 May 2024 21:55:16 +0200 [thread overview]
Message-ID: <87ttidrc2j.fsf@gnu.org> (raw)
In-Reply-To: <87wmt5704i.fsf@inria.fr> ("Ludovic Courtès"'s message of "Sat, 23 Dec 2023 10:13:01 +0100")
Ludovic Courtès <ludovic.courtes@inria.fr> skribis:
> I’m under the impression that sometimes, when the server replies to
> ‘worker-request-work’ messages, its reply is received by more than just
> the target worker, leading to builds being performed twice:
On closer inspection, the theory of the message being received by two
different peers doesn’t hold.
Instead, I believe ‘db-get-pending-build’ would return the same build at
two different points in time, typically while the first one is still
running.
That’s normally not possible because the build’s status is changed to
‘submitted’ once it’s been picked up. Turns out that, due to slowness
of the query in ‘db-get-pending-build’ (fixed in
17338588d4862b04e9e405c1244a2ea703b50d98), ‘remote-server’ would
sometimes fail to see worker pings in a timely fashion. Thus, it would
call ‘db-remove-unresponsive-workers’, which would reschedule builds
that were being carried out by said worker(s). And that’s how we would
end up with multiple concurrent builds of the same derivation.
I added logging in c2061ca845d05694ebeb88935a6ff2254711beb2, which
should give a hint, should that happen again.
Ludo’.
prev parent reply other threads:[~2024-05-31 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 9:13 bug#67988: [Cuirass] ‘request-work’ responses received by several workers Ludovic Courtès
2024-05-28 21:50 ` Ludovic Courtès
2024-05-31 19:55 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttidrc2j.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=67988@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).