unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#73898: MPV should not propagate all inputs
@ 2024-10-20  2:33 Antero Mejr
  2024-10-23 12:52 ` Maxim Cournoyer
  0 siblings, 1 reply; 3+ messages in thread
From: Antero Mejr @ 2024-10-20  2:33 UTC (permalink / raw)
  To: 73898

Currently, MPV propagates most of its inputs, which is not correct.

When MPV tries to propagate a different version of a dependency (like
ffmpeg) that is a different version what is currently installed, Guix
operations will fail.

The source code in video.scm says that the inputs are propagated so
pkg-config will work, but that is not a valid reason. The pkg-config
file should be patched so that pkg-config will work without unnecessary
propagated-inputs.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#73898: MPV should not propagate all inputs
  2024-10-20  2:33 bug#73898: MPV should not propagate all inputs Antero Mejr
@ 2024-10-23 12:52 ` Maxim Cournoyer
  2024-10-23 16:53   ` Antero Mejr
  0 siblings, 1 reply; 3+ messages in thread
From: Maxim Cournoyer @ 2024-10-23 12:52 UTC (permalink / raw)
  To: Antero Mejr; +Cc: 73898

Hi Antero,

Antero Mejr <mail@antr.me> writes:

> Currently, MPV propagates most of its inputs, which is not correct.
>
> When MPV tries to propagate a different version of a dependency (like
> ffmpeg) that is a different version what is currently installed, Guix
> operations will fail.
>
> The source code in video.scm says that the inputs are propagated so
> pkg-config will work, but that is not a valid reason. The pkg-config
> file should be patched so that pkg-config will work without unnecessary
> propagated-inputs.

Maybe we could have a mpv package that doesn't propagate anything, and a libmpv
that does, if there are any users (other packages) of mpv as a library?

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#73898: MPV should not propagate all inputs
  2024-10-23 12:52 ` Maxim Cournoyer
@ 2024-10-23 16:53   ` Antero Mejr
  0 siblings, 0 replies; 3+ messages in thread
From: Antero Mejr @ 2024-10-23 16:53 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 73898

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Maybe we could have a mpv package that doesn't propagate anything, and a libmpv
> that does, if there are any users (other packages) of mpv as a library?

There was already some discussion about that here:
https://issues.guix.gnu.org/68250

It seems like once the pkgconf stuff is merged, mpv can be built as a
shared library, move the propagated-inputs to inputs, and meson will
output the correct pkg-config file without breaking downstream
dependencies. Not sure though.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-23 16:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-20  2:33 bug#73898: MPV should not propagate all inputs Antero Mejr
2024-10-23 12:52 ` Maxim Cournoyer
2024-10-23 16:53   ` Antero Mejr

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).