From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] Add (guix build-system cmake).
Date: Tue, 26 Mar 2013 23:09:10 +0100
Message-ID: <87sj3hu83d.fsf@gnu.org>
References: <1364333243-27199-1-git-send-email-tipecaml@gmail.com>
	<1364333243-27199-2-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:37994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UKc3X-0008GW-C1
	for bug-guix@gnu.org; Tue, 26 Mar 2013 18:09:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UKc3V-0005Yk-VV
	for bug-guix@gnu.org; Tue, 26 Mar 2013 18:09:23 -0400
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=46889
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UKc3V-0005X1-OV
	for bug-guix@gnu.org; Tue, 26 Mar 2013 18:09:21 -0400
In-Reply-To: <1364333243-27199-2-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Tue, 26 Mar 2013 22:27:22 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: bug-guix@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * guix/build/cmake-build-system.scm, guix/build-system/cmake.scm: New fil=
es.
> * Makefile.am (MODULES): Add them.

Overall looks good to me, nice!

> +;; Standard build procedure for packages using cmake. This is implemente=
d as an

Please spell it as =E2=80=9CCMake=E2=80=9D.  Also, two spaces after a perio=
d ending a
sentence.

> +(define* (cmake-build store name source inputs

Admittedly these bits look like copy/pasting, but I=E2=80=99m not sure how =
to
factorize more.

> +                (description "The standard cmake build system")

=E2=80=9CCMake=E2=80=9D.

> +;; XXX Parallel tests are disabled by default because I have no idea how=
 they
> +;; work in cmake.

CMake generates a Makefile, so running =E2=80=98make -jX=E2=80=99 just work=
s.  Thus you
can leave #:parallel-{build,tests}? to #t by default.

> +(define* (check #:key (tests? #t) (parallel-tests? #f) (test-target "tes=
t")
> +                #:allow-other-keys)
> +  (let ((gnucheck (assoc-ref gnu:%standard-phases 'check)))

s/gnucheck/gnu-check/

Cool!

Please push after fixing these.

Ludo=E2=80=99.