From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: bug#27222: [PATCH] emacs-build-system install phase doesn't honor directory hierarchy Date: Sun, 04 Jun 2017 22:41:43 +0300 Message-ID: <87shjf5ymg.fsf@gmail.com> References: <87h8zwptdn.fsf@gmail.com> <874lvwp7km.fsf@gmail.com> <87wp8rq57k.fsf@gmail.com> <87zidnog85.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHbPZ-0000v2-5t for bug-guix@gnu.org; Sun, 04 Jun 2017 15:42:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHbPW-00064t-2e for bug-guix@gnu.org; Sun, 04 Jun 2017 15:42:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHbPV-00064e-Uj for bug-guix@gnu.org; Sun, 04 Jun 2017 15:42:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHbPV-0007Jt-M5 for bug-guix@gnu.org; Sun, 04 Jun 2017 15:42:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87zidnog85.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 04 Jun 2017 09:44:10 -0700") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Maxim Cournoyer Cc: 27222@debbugs.gnu.org Maxim Cournoyer (2017-06-04 09:44 -0700) wrote: [...] >>> (phases '(@ (guix build emacs-build-system) >>> %standard-phases)) >>> (outputs '("out")) >>> - (include ''("^[^/]*\\.el$" "^[^/]*\\.info$" "^doc/.*\\.info$")) >>> + (include ''("\\.el$" "^[^/]*\\.info$" "^doc/.*\\.info$")) >> >> As far as I understand it, it was done for purpose: some packages >> include "uninteresting" (for tests, maintenance, etc.) *.el files in >> subdirs, that's why they are excluded by default. So probably a better >> solution would be to fix 'ert-runner' package (as it is done in commit >> b1d32ec0e23bfec1dab4c56909228a494b2b0d60, for example). WDYT? > > I acknowledge the intent, but I think the default set of rexgeps > should be more lenient; filtering (inoffensive) files is desirable, but > not at the cost of breaking perfectly valid packages. That's one extra > hurdle the packagers shouldn't have to bear in my opinion. > > This change also doesn't prevent excluding subfolders if they are truly > unnecessary (such as tests subfolder), but this should happen due to > explicit regexp in the exclude option, not because *all* subfolders are > excluded. > > What do you think? I think my view is not what most people would like: I am for excluding as much as possible (as it is now), and for manual adjusting packages when it is needed. -- Alex