From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#27811: net-tools patch has no effect?
Date: Tue, 25 Jul 2017 10:27:00 +0200
Message-ID: <87shhkncq3.fsf@gnu.org>
References: <20170725041225.GA31642@jasmine.lan>
	<20170725045947.GA531@jasmine.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53168)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dZvCH-0004z9-Jx
	for bug-guix@gnu.org; Tue, 25 Jul 2017 04:28:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dZvCE-0007ZG-Fw
	for bug-guix@gnu.org; Tue, 25 Jul 2017 04:28:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:52386)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dZvCE-0007ZA-Co
	for bug-guix@gnu.org; Tue, 25 Jul 2017 04:28:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dZvCE-0002TD-42
	for bug-guix@gnu.org; Tue, 25 Jul 2017 04:28:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27811.B27811.15009712349443@debbugs.gnu.org>
In-Reply-To: <20170725045947.GA531@jasmine.lan> (Leo Famulari's message of
	"Tue, 25 Jul 2017 00:59:47 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 27811@debbugs.gnu.org

Hi Leo,

Leo Famulari <leo@famulari.name> skribis:

> On Tue, Jul 25, 2017 at 12:12:25AM -0400, Leo Famulari wrote:
>> This problem with the wrong number of arguments being passed to
>> parse_media() is introduced in the Debian patch, so we should check if
>> there is a better version of the patch or if fixes are being applied
>> upstream.
>
> Actually, the first issue is that the patch doesn't apply to the source
> fully. I tried a later patch from Debian, but it also doesn't apply. I
> haven't been able to try fetching a later revision of the net-tools Git
> repo, because I first have to make Git not depend on net-tools.
>
> This patch will try to apply the patch and handle the exit codes of
> gunzip and patch correctly:

Good catch, this LGTM.  I wonder how this went unnoticed for so long!

As for the actual update, the intent is to add a second =E2=80=98net-tools=
=E2=80=99
variant, right?

Thanks for looking into this!

Ludo=E2=80=99.