unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#25631: epiphany: Ad blocker does not work.
@ 2017-02-06 11:02 Ricardo Wurmus
  2017-02-06 12:02 ` Ricardo Wurmus
  2018-08-30  0:19 ` Leo Famulari
  0 siblings, 2 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2017-02-06 11:02 UTC (permalink / raw)
  To: 25631

Epiphany comes with an ad blocker extension that can be enabled in the
settings.  When starting epiphany, however, the following message can be
seen on VT1:

** (WebKitWebProcess:12345): WARNING **: Error retrieving adblock filter: Operation not supported

In fact, Epiphany does not store any filter list anywhere and as a
result no ads are blocked.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25631: epiphany: Ad blocker does not work.
  2017-02-06 11:02 bug#25631: epiphany: Ad blocker does not work Ricardo Wurmus
@ 2017-02-06 12:02 ` Ricardo Wurmus
  2017-02-07 10:14   ` Mark H Weaver
  2018-08-30  0:19 ` Leo Famulari
  1 sibling, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2017-02-06 12:02 UTC (permalink / raw)
  To: 25631

“g_file_new_for_uri” triggers the download via dbus, so it must be made
aware of the dbus session.  When running “dbus-launch epiphany” the
error changes to

    ** (WebKitWebProcess:30867): WARNING **: Error retrieving adblock filter: HTTP Error: TLS/SSL support not available; install glib-networking

If I first export the same environment variables (for GIO modules) that
are set in the epiphany wrapper the error disappears:

    guix environment --ad-hoc dbus
    source <(sed $(readlink -f $(which epiphany)) -e "s/exec.*//")
    dbus-launch epiphany

Should we use dbus-launch in the wrapper script or should we ensure
system-wide that after logging in the DBUS_SESSION_BUS_ADDRESS is
exported?

I’m using stumpwm so I don’t know if GNOME usually takes care of this.
Maybe it is sufficient to run “dbus-launch” in .xsession and eval the
variable definitions it generates.

If this is so, should we handle this by default in some global file like
/etc/environment or similar?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25631: epiphany: Ad blocker does not work.
  2017-02-06 12:02 ` Ricardo Wurmus
@ 2017-02-07 10:14   ` Mark H Weaver
  2017-02-07 10:29     ` Ricardo Wurmus
  0 siblings, 1 reply; 6+ messages in thread
From: Mark H Weaver @ 2017-02-07 10:14 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 25631

Ricardo Wurmus <rekado@elephly.net> writes:

> “g_file_new_for_uri” triggers the download via dbus, so it must be made
> aware of the dbus session.  When running “dbus-launch epiphany” the
> error changes to
>
>     ** (WebKitWebProcess:30867): WARNING **: Error retrieving adblock filter: HTTP Error: TLS/SSL support not available; install glib-networking
>
> If I first export the same environment variables (for GIO modules) that
> are set in the epiphany wrapper the error disappears:
>
>     guix environment --ad-hoc dbus
>     source <(sed $(readlink -f $(which epiphany)) -e "s/exec.*//")
>     dbus-launch epiphany
>
> Should we use dbus-launch in the wrapper script or should we ensure
> system-wide that after logging in the DBUS_SESSION_BUS_ADDRESS is
> exported?
>
> I’m using stumpwm so I don’t know if GNOME usually takes care of this.

It seems that both GNOME and Xfce take care of setting
DBUS_SESSION_BUS_ADDRESS, since that variable is set on both my x86_64
GuixSD system running GNOME and my mips64el GuixSD system running Xfce.

      Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25631: epiphany: Ad blocker does not work.
  2017-02-07 10:14   ` Mark H Weaver
@ 2017-02-07 10:29     ` Ricardo Wurmus
  0 siblings, 0 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2017-02-07 10:29 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: 25631


Mark H Weaver <mhw@netris.org> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
[…]
>> Should we use dbus-launch in the wrapper script or should we ensure
>> system-wide that after logging in the DBUS_SESSION_BUS_ADDRESS is
>> exported?
>>
>> I’m using stumpwm so I don’t know if GNOME usually takes care of this.
>
> It seems that both GNOME and Xfce take care of setting
> DBUS_SESSION_BUS_ADDRESS, since that variable is set on both my x86_64
> GuixSD system running GNOME and my mips64el GuixSD system running Xfce.

Thanks for confirming.

Recent versions of systemd’s pam-systemd set DBUS_SESSION_BUS_ADDRESS as
well.  Our version of elogind does not.  I just backported the changes
from systemd 226 to elogind and will test this on my system.

Doing this in pam-elogind would probably be best.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25631: epiphany: Ad blocker does not work.
  2017-02-06 11:02 bug#25631: epiphany: Ad blocker does not work Ricardo Wurmus
  2017-02-06 12:02 ` Ricardo Wurmus
@ 2018-08-30  0:19 ` Leo Famulari
  2018-08-30  7:54   ` Ricardo Wurmus
  1 sibling, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2018-08-30  0:19 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 25631-done

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

On Mon, Feb 06, 2017 at 12:02:25PM +0100, Ricardo Wurmus wrote:
> Epiphany comes with an ad blocker extension that can be enabled in the
> settings.  When starting epiphany, however, the following message can be
> seen on VT1:
> 
> ** (WebKitWebProcess:12345): WARNING **: Error retrieving adblock filter: Operation not supported
> 
> In fact, Epiphany does not store any filter list anywhere and as a
> result no ads are blocked.

Epiphany's ad blocker is now working for me on GuixSD with GNOME and a
foreign distro.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25631: epiphany: Ad blocker does not work.
  2018-08-30  0:19 ` Leo Famulari
@ 2018-08-30  7:54   ` Ricardo Wurmus
  0 siblings, 0 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2018-08-30  7:54 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 25631-done


Leo Famulari <leo@famulari.name> writes:

> On Mon, Feb 06, 2017 at 12:02:25PM +0100, Ricardo Wurmus wrote:
>> Epiphany comes with an ad blocker extension that can be enabled in the
>> settings.  When starting epiphany, however, the following message can be
>> seen on VT1:
>>
>> ** (WebKitWebProcess:12345): WARNING **: Error retrieving adblock filter: Operation not supported
>>
>> In fact, Epiphany does not store any filter list anywhere and as a
>> result no ads are blocked.
>
> Epiphany's ad blocker is now working for me on GuixSD with GNOME and a
> foreign distro.

Yes, it does work in GNOME.  I think I used it in StumpWM when it didn’t
work.  The session was not wrapped in dbus-launch.  Now I’m using EXWM,
which is started within dbus-launch, and the ad blocker does work.

I suspect that the only problem was that DBus wasn’t working properly
when starting StumpWM without the dbus-launch wrapper.  I hope this
information will be helpful to people from the future who find this old
bug report through a web search.

--
Ricardo

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-08-30  8:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-06 11:02 bug#25631: epiphany: Ad blocker does not work Ricardo Wurmus
2017-02-06 12:02 ` Ricardo Wurmus
2017-02-07 10:14   ` Mark H Weaver
2017-02-07 10:29     ` Ricardo Wurmus
2018-08-30  0:19 ` Leo Famulari
2018-08-30  7:54   ` Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).