From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#33300: hplip 3.18.9 contains non-free binary blobs Date: Wed, 07 Nov 2018 11:19:35 +0100 Message-ID: <87sh0dur48.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKKxM-0004N3-CF for bug-guix@gnu.org; Wed, 07 Nov 2018 05:21:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKKxK-0007gm-NC for bug-guix@gnu.org; Wed, 07 Nov 2018 05:21:04 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKKxJ-0007fD-VH for bug-guix@gnu.org; Wed, 07 Nov 2018 05:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKKxJ-0005Ai-Q0 for bug-guix@gnu.org; Wed, 07 Nov 2018 05:21:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKKwF-0004F5-HT for bug-guix@gnu.org; Wed, 07 Nov 2018 05:19:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKKwB-0006d9-6h for bug-guix@gnu.org; Wed, 07 Nov 2018 05:19:53 -0500 List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 33300@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, The tarball of hplip 3.18.9 contains several .so files that it installs as-is: --8<---------------cut here---------------start------------->8--- ludo@ribbon ~/src/guix$ (cd /tmp; tar xf $(guix build -S hplip)) ludo@ribbon ~/src/guix$ find /tmp/hplip-3.18.9 -name \*.so /tmp/hplip-3.18.9/prnt/plugins/hbpl1-arm32.so /tmp/hplip-3.18.9/prnt/plugins/hbpl1-x86_64.so /tmp/hplip-3.18.9/prnt/plugins/lj-x86_32.so /tmp/hplip-3.18.9/prnt/plugins/hbpl1-arm64.so /tmp/hplip-3.18.9/prnt/plugins/hbpl1-x86_32.so /tmp/hplip-3.18.9/prnt/plugins/lj-arm64.so /tmp/hplip-3.18.9/prnt/plugins/lj-x86_64.so /tmp/hplip-3.18.9/prnt/plugins/lj-arm32.so /tmp/hplip-3.18.9/prnt/hpcups/libImageProcessor-x86_32.so /tmp/hplip-3.18.9/prnt/hpcups/libImageProcessor-x86_64.so --8<---------------cut here---------------end--------------->8--- I tried removing them with a snippet (patch attached), but installation eventually fails while trying to link against libImageProcessor, which is now missing. In people suggest that 3.18.6 is the last known-good version. Indeed that version does not have the obnoxious libImageProcessor, so that should be fine. It does come with the non-free binary plug-ins, though these are just plugins so removing them will be easier: --8<---------------cut here---------------start------------->8--- ludo@ribbon ~/src/guix$ find /tmp/hplip-3.18.6/ -name \*.so /tmp/hplip-3.18.6/prnt/plugins/hbpl1-arm32.so /tmp/hplip-3.18.6/prnt/plugins/hbpl1-x86_64.so /tmp/hplip-3.18.6/prnt/plugins/lj-x86_32.so /tmp/hplip-3.18.6/prnt/plugins/hbpl1-arm64.so /tmp/hplip-3.18.6/prnt/plugins/hbpl1-x86_32.so /tmp/hplip-3.18.6/prnt/plugins/lj-arm64.so /tmp/hplip-3.18.6/prnt/plugins/lj-x86_64.so /tmp/hplip-3.18.6/prnt/plugins/lj-arm32.so --8<---------------cut here---------------end--------------->8--- Thus, I propose to: 1. Revert to 3.18.6 (we=E2=80=99ll upgrade if and when hplip becomes free again.) 2. Add a snippet to remove the non-free plugins. Thoughts? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm index 4259648c69..c0ac365691 100644 --- a/gnu/packages/cups.scm +++ b/gnu/packages/cups.scm @@ -410,6 +410,19 @@ device-specific programs to convert and print many types of files.") '(begin (substitute* "prnt/hpcups/genPCLm.cpp" (("boolean") "bool")) + + ;; Starting from version 3.18.9, hplip comes with binary + ;; blobs under prnt/hpcups and prnt/plugins. Remove them. + (for-each delete-file (find-files "." "\\.so$")) + + ;; This trick changes the behavior of the + ;; 'install-data-hook' target so that it doesn't install the + ;; binary blobs. + (substitute* "Makefile.in" + (("^UNAME =.*") + "UNAME = free-software-only-thanks\n") + (("prnt/hpcups/libImageProcessor-([[:graph:]]+)\\.so") + "")) #t)))) (build-system gnu-build-system) (home-page "https://developers.hp.com/hp-linux-imaging-and-printing") --=-=-=--