From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: bug#35941: Newt installer failure when wifi name is #f Date: Tue, 28 May 2019 11:17:31 +0200 Message-ID: <87sgsz9bv8.fsf@gmail.com> References: <87h89fj6p3.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:35492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVYFB-0007Rh-3D for bug-guix@gnu.org; Tue, 28 May 2019 05:18:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVYF9-0001Y0-BX for bug-guix@gnu.org; Tue, 28 May 2019 05:18:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVYF8-0001XO-1S for bug-guix@gnu.org; Tue, 28 May 2019 05:18:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVYF7-0004jG-Rh for bug-guix@gnu.org; Tue, 28 May 2019 05:18:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([209.51.188.92]:35411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVYEj-000791-2F for bug-guix@gnu.org; Tue, 28 May 2019 05:17:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVYEi-0001Ly-2V for bug-guix@gnu.org; Tue, 28 May 2019 05:17:37 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:50641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVYEh-0001Kk-RO for bug-guix@gnu.org; Tue, 28 May 2019 05:17:36 -0400 Received: by mail-wm1-x331.google.com with SMTP id f204so2029920wme.0 for ; Tue, 28 May 2019 02:17:35 -0700 (PDT) In-reply-to: <87h89fj6p3.fsf@ambrevar.xyz> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Pierre Neidhardt Cc: 35941@debbugs.gnu.org Hey Pierre, You can find the backtrace in /tmp/last-installer-error file. About the bug itself, it has been reported here: https://issues.guix.gnu.org/issue/35622 Both patches seems fine to me, but I'd like to understand why the regex fails. Could you run this command and report the result: --8<---------------cut here---------------start------------->8--- for s in $(connmanctl services | cut -c 25- | grep wifi) ; do connmanctl service $s ; done --8<---------------cut here---------------end--------------->8--- Thanks, Mathieu > Apparently it fails because a wifi service name is #f. > > I can think of two fixes (untested). In wifi.scm: > > --8<---------------cut here---------------start------------->8--- > @@ -144,6 +144,7 @@ of records present in LISTBOX." > (let ((services (connman-services))) > (filter (lambda (service) > (and (string=? (service-type service) "wifi") > + (service-name service) > (not (string-null? (service-name service))))) > services))) > --8<---------------cut here---------------end--------------->8--- > > Or, more directly in connman.scm: > > --8<---------------cut here---------------start------------->8--- > @@ -108,7 +108,8 @@ > (define-record-type* > service make-service > service? > - (name service-name) ; string > + (name service-name > + (default "")) > (type service-type) ; string > (path service-path) ; string > (strength service-strength) ; integer > --8<---------------cut here---------------end--------------->8--- > > Thoughts?