From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: bug#24450: [PATCHv2] Re: pypi importer outputs strange character series in optional dependency case. Date: Mon, 10 Jun 2019 11:10:58 +0900 Message-ID: <87sgsi5gwd.fsf@gmail.com> References: <87pnod7ot4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:55385) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ha9nC-0006jb-7p for bug-guix@gnu.org; Sun, 09 Jun 2019 22:12:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ha9n8-0005xg-9Q for bug-guix@gnu.org; Sun, 09 Jun 2019 22:12:12 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ha9n0-0005uq-HB for bug-guix@gnu.org; Sun, 09 Jun 2019 22:12:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ha9n0-0002RU-Au for bug-guix@gnu.org; Sun, 09 Jun 2019 22:12:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: (Ricardo Wurmus's message of "Mon, 27 May 2019 16:48:43 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ricardo Wurmus Cc: 24450@debbugs.gnu.org Hello Ricardo! Ricardo Wurmus writes: > Hi Maxim, > >> Subject: [PATCH 1/9] import: pypi: Do not consider requirements.txt file= s. >> >> * guix/import/pypi.scm (guess-requirements): Update comment. >> [guess-requirements-from-source]: Do not attempt to parse the file >> requirements.txt. Streamline logic. > > Why remove the handling of the requirements.txt? Is it no longer > popular enough to expect its availability in the source archives? > > Please also mention in the commit message that and how you adjusted the > tests. The commit message now explains the above: import: pypi: Do not consider requirements.txt files. PyPI packages are mandated to have a setup.py file, which contains a li= sting of the required dependencies. The setuptools/distutils machinery embed metadata in the archives they produce, which contains this information.= There is no need nor gain to collect the requirements from a "requirements.tx= t" file, as it is not the true record of dependencies for PyPI packages an= d may contain extraneous requirements or not exist at all. * guix/import/pypi.scm (guess-requirements): Update comment. [guess-requirements-from-source]: Do not attempt to parse the file requirements.txt. Streamline logic. * tests/pypi.scm (test-requires.txt): Rename from test-requirements, to= hint at the file being tested. ("pypi->guix-package"): Adapt so that the fake package contains a requi= res.txt file rather than a requirements.txt file. ("pypi->guix-package, wheels"): Likewise. > You removed the comments from the example requires.txt =E2=80=94 are > comments no longer permitted in these files? If they are, please don=E2= =80=99t > include those changes. The comments are now preserved. Thank you! Maxim