bug#36930: NSS 3.45 fails to build on armhf-linux

[Mark H Weaver <mhw@netris.org>]

Hi Marius,

Marius Bakke <mbakke@fastmail.com> writes:

> On armhf-linux, 'nss' fails early in the build process due to an
> undefined reference to "PR_Assert":
>
> https://ci.guix.gnu.org/log/5cqmmjd9a8h05l8y352z1pq4mlyd6w21-nss-3.45
>
> This is almost certainly because of this upstream commit, which swaps
> out the curve25519 implementation for 32-bit ARM systems:
>
> https://hg.mozilla.org/projects/nss/rev/7b749ff400db3ecab87f394c091ea0831254e674
>
> There is some discussion about it in this ticket:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1550579
>
> I don't know how all those people were able to benchmark the change.
> Perhaps we are missing something in our build flags?
>
> With NSS 3.45 now in the 'master' branch, we should fix this issue
> quickly as armhf users are currently unable to update their systems.
>
> I filed an upstream ticket here, but no response yet:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1571316

For now, we could simply revert my commit that updates NSS to 3.45.
Although I mentioned in the commit log that it fixed some CVEs, I later
discovered that 3.44.1 includes fixes for the same CVEs.  NSS 3.44.1 was
the version of NSS in 'master' before my commit.

       Mark