From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rosset Subject: bug#38148: [PATCH 1/2] gnu: Add python-pyqtwebengine. Date: Tue, 14 Jan 2020 02:25:36 -0800 Message-ID: <87sgkibai3.fsf@gmail.com> References: <20191109100530.zdfrewfmengq7pud@hooch.localdomain> <20200113103304.9093-1-mike.rosset@gmail.com> <87o8v7qw5t.fsf@ambrevar.xyz> <87tv4yc1hb.fsf@gmail.com> <871rs2z84h.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:41750) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irJOg-0000dB-PT for bug-guix@gnu.org; Tue, 14 Jan 2020 05:26:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irJOc-0000Uh-52 for bug-guix@gnu.org; Tue, 14 Jan 2020 05:26:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54714) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irJOc-0000UQ-1m for bug-guix@gnu.org; Tue, 14 Jan 2020 05:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1irJOb-0003HF-Uu for bug-guix@gnu.org; Tue, 14 Jan 2020 05:26:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <871rs2z84h.fsf@ambrevar.xyz> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Pierre Neidhardt Cc: 38148@debbugs.gnu.org Pierre Neidhardt writes: > Mike Rosset writes: > >>> Please apply the above pyqt change to a separate commit. >> >> I missed this comment with my new series. If this really needs to be >> done, I'll have to redo all of the commits and resend the series. Can >> this be avoided if possible? > > Yes, this is really necessary, commits must be atomic or else the log > gets easily tangled. > > This is not hard to do though: > > - rebase-edit the offending commit ("r m" with magit), this will leave > git in a detached state. > > - Soft-reset HEAD~. > > - Commit the first changes to a new commit. > > - Commit the rest. > > Let me know if you need more help. > Forgive me. After I had replied here, I realized your suggestion was the right way to go about this. I was tired and lazy when I responded. I will fix the commits. I'm not sure how this will effect the series worse case I'll just send the final series. We can treat this as a squash in away. Mike