From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YLH6DN0JSV95eAAA0tVLHw (envelope-from ) for ; Fri, 28 Aug 2020 13:42:53 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6MznCN0JSV+5YwAA1q6Kng (envelope-from ) for ; Fri, 28 Aug 2020 13:42:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 76568940A5B for ; Fri, 28 Aug 2020 13:42:52 +0000 (UTC) Received: from localhost ([::1]:40570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBeeY-0005Yw-9m for larch@yhetil.org; Fri, 28 Aug 2020 09:42:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBedm-00058C-1d for bug-guix@gnu.org; Fri, 28 Aug 2020 09:42:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBedl-0007nk-OP for bug-guix@gnu.org; Fri, 28 Aug 2020 09:42:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBedl-00083P-Lk for bug-guix@gnu.org; Fri, 28 Aug 2020 09:42:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42983: "sudo -E guix pull" breaks ~/.config/guix/current for regular user Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 28 Aug 2020 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42983 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Danny Milosavljevic Received: via spool by 42983-submit@debbugs.gnu.org id=B42983.159862207630905 (code B ref 42983); Fri, 28 Aug 2020 13:42:01 +0000 Received: (at 42983) by debbugs.gnu.org; 28 Aug 2020 13:41:16 +0000 Received: from localhost ([127.0.0.1]:45693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBed1-00082P-KU for submit@debbugs.gnu.org; Fri, 28 Aug 2020 09:41:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBed0-00082D-8v for 42983@debbugs.gnu.org; Fri, 28 Aug 2020 09:41:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58373) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBecu-0007iy-9U; Fri, 28 Aug 2020 09:41:08 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=49106 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBect-0007ub-Qm; Fri, 28 Aug 2020 09:41:08 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200822122750.78ddc111@scratchpost.org> <20200824021113.71a79f10@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 28 Aug 2020 15:41:05 +0200 In-Reply-To: <20200824021113.71a79f10@scratchpost.org> (Danny Milosavljevic's message of "Mon, 24 Aug 2020 02:11:13 +0200") Message-ID: <87sgc6q45q.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42983@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: hZ8YX4AUtVjN Hi Danny, Danny Milosavljevic skribis: > The culprit, I think, is this: > > (define (ensure-default-profile) > (ensure-profile-directory) > > ;; In 0.15.0+ we'd create ~/.config/guix/current-[0-9]*-link symlinks. = Move > ;; them to %PROFILE-DIRECTORY. > ;; > ;; XXX: Ubuntu's 'sudo' preserves $HOME by default, and thus the second > ;; condition below is always false when one runs "sudo guix pull". As a > ;; workaround, skip this code when $SUDO_USER is set. See > ;; . > (unless (or (getenv "SUDO_USER") > (string=3D? %profile-directory > (dirname > (canonicalize-profile %user-profile-directory)))) > (migrate-generations %user-profile-directory %profile-directory)) > > where > > %profile-directory =3D "/var/guix/profiles/per-user/dannym" > %user-profile-directory =3D "/home/dannym/.config/guix/current" (which = is a > symlink to /var/guix/profiles/per-user/root/current-guix) We could detect such inconsistencies and emit a warning/hint. I=E2=80=99m unsure just how far we need to go in trying to prevent users from shooting themselves in the foot, though. Thoughts? > Ohh, yeah, sudo without "-E" works fine (sudo guix pull, too). Yes. Ludo=E2=80=99.