From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OI14OlP1j19cXwAA0tVLHw (envelope-from ) for ; Wed, 21 Oct 2020 08:46:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oHNMNlP1j19YSAAAB5/wlQ (envelope-from ) for ; Wed, 21 Oct 2020 08:46:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32238940A39 for ; Wed, 21 Oct 2020 08:46:11 +0000 (UTC) Received: from localhost ([::1]:36276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kV9l3-0004fn-83 for larch@yhetil.org; Wed, 21 Oct 2020 04:46:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kV9kw-0004fg-RW for bug-guix@gnu.org; Wed, 21 Oct 2020 04:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kV9kw-0005qJ-JA for bug-guix@gnu.org; Wed, 21 Oct 2020 04:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kV9kw-0004Lb-H6 for bug-guix@gnu.org; Wed, 21 Oct 2020 04:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 21 Oct 2020 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43984 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Received: via spool by 43984-submit@debbugs.gnu.org id=B43984.160326993416664 (code B ref 43984); Wed, 21 Oct 2020 08:46:02 +0000 Received: (at 43984) by debbugs.gnu.org; 21 Oct 2020 08:45:34 +0000 Received: from localhost ([127.0.0.1]:47891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kV9kU-0004Ki-32 for submit@debbugs.gnu.org; Wed, 21 Oct 2020 04:45:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kV9kT-0004KV-1J for 43984@debbugs.gnu.org; Wed, 21 Oct 2020 04:45:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44808) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kV9kL-0005es-Hf; Wed, 21 Oct 2020 04:45:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43026 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kV9kH-0001h9-5n; Wed, 21 Oct 2020 04:45:24 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201014015558.09d6702a@runbox.com> <87wnzsapwh.fsf@gnu.org> <20201015195013.335eaefd@runbox.com> <87sgae8qlh.fsf@gnu.org> <20201017020311.0c68f3d5@runbox.com> <87h7qobn6y.fsf@gnu.org> <87d01c8r2k.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?UTF-8?Q?Vend=C3=A9miaire?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 21 Oct 2020 10:45:19 +0200 In-Reply-To: <87d01c8r2k.fsf@netris.org> (Mark H. Weaver's message of "Tue, 20 Oct 2020 18:34:00 -0400") Message-ID: <87sga89dcw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pkill9 , 43984@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: hD7Ico+zJ3nD Hi Mark, Mark H Weaver skribis: > Ludovic Court=C3=A8s writes: > >> pkill9 skribis: >> >>>> All I=E2=80=99m saying is that nothing can be done when the new name i= s longer >>>> than the old one: we just cannot graft. >>> >>> If a symlink is used though, it wouldn't matter if the new name is >>> longer, the symlink would point to the new package, and the name of the >>> symlink would match the length of the old package. >> >> But who would refer to that symlink? The thing on which the graft is >> applied can only refer to the store item that has the right length. > > If I understand correctly, pkill9's idea is that intermediate symlink(s) > (presumably one for each output of the replacement package) would have > the same length as the original store item, but could point to a > replacement store item of greater length. > > For example, whereas now we must *build* our replacement libx11 with > munged version number "1.6.A", under pkill9's approach we could instead > build it with normal version number "1.6.10", and only the intermediate > symlink(s) would have their names munged to fit within the original > length limit. The grafting process would then rewrite the original > store references to point to the symlink(s). > > An advantage to this approach is that the replacement packages would no > longer need to have their version numbers munged, which would be more > aesthetically pleasing and perhaps less confusing for users. The lack > of munging might also make the replacement package more attractive for > _direct_ usage as a package input by non-core packages that need the > newer version of the replaced package for other reasons. Oh that makes sense, thanks for explaining. It could be useful to implement this; it would make =E2=80=98--with-graft= =E2=80=99 more generally applicable, which was pkill9=E2=80=99s initial goal. Package replacements often have the same length as the original, so for those we wouldn=E2=80=99t change anything; it would make a difference in ot= her cases though. > Disadvantages include potentially slower file system lookups in the > replaced packages, and added complexity in Guix. Yes, though that=E2=80=99s probably reasonable. Thanks, Ludo=E2=80=99.