unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 52520@debbugs.gnu.org
Subject: bug#52520: Multicast is off by default
Date: Sun, 19 Dec 2021 12:08:05 +0100	[thread overview]
Message-ID: <87sfuovomi.fsf@gnu.org> (raw)
In-Reply-To: <87czlvqn3b.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 17 Dec 2021 16:15:36 +0100")


Hey,

> Is it #:multicast-on or #:allmulticast-on ?

The "ip link set multicast ..." command corresponds to the the
IFF_MULTICAST flag hence to the #:multicast-on parameter.

> Anyhow, I suggest adding a ‘multicast?’ field to <network-address>, with
> #t as its default value, and honoring this.

I'm not sure <network-address> is the right place for this flag. If
there are two <network-address> records in the same list, one for ipv4
and one for ipv6 it means that we need to repeat this flag twice.

Same for the MTU, having different MTU for ipv4 and ipv6 addresses
doesn't have any meaning. The MTU and multicast properties belong to the
device itself.

I think we should introduce a <network-device> record that would gather
the properties that can be passed to the "link-set" method of
Guile-Netlink. The <static-networking> record would point to a unique
<network-device>. We would remove the device field from
<network-address>.

Then each <static-networking> service would provision (concat
'networking- (network-device-name device)) or something like that, to fix
https://issues.guix.gnu.org/52511 as well.

How does that sounds?

Thanks,

Mathieu




  reply	other threads:[~2021-12-19 11:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 19:36 bug#52520: Multicast is off by default Mathieu Othacehe
2021-12-17 15:15 ` Ludovic Courtès
2021-12-19 11:08   ` Mathieu Othacehe [this message]
2021-12-20 15:29     ` Maxim Cournoyer
     [not found]     ` <87h7b3jt8i.fsf@gnu.org>
2021-12-20 16:38       ` Mathieu Othacehe
2021-12-20 21:33         ` Ludovic Courtès
2021-12-21 19:40           ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfuovomi.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=52520@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).